Re: RFR: 8022213 Intermittent test failures in java/net/URLClassLoader (Add jdk/testlibrary/FileUtils.java)

Hi Chris, In deleteFileWithRetry0(), the following lines 79 while (true) { 80 if (Files.notExists(path)) 81 break; can be combined to while (Files.exists(path)) { ... And L99 99Thread.sleep(RETRY_DELETE_MILLIS); se

hg: jdk8/tl/nashorn: 4 new changesets

Changeset: f109bb255b80 Author:cl Date: 2013-10-31 12:36 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/nashorn/rev/f109bb255b80 Added tag jdk8-b114 for changeset 79f7b79bf97b ! .hgtags Changeset: f0d3ac2474ee Author:lana Date: 2013-10-31 16:47 -0700 URL: http://hg.o

hg: jdk8/tl/hotspot: 37 new changesets

Changeset: ddc3758f68db Author:cl Date: 2013-10-31 12:36 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/ddc3758f68db Added tag jdk8-b114 for changeset 7fd913010dbb ! .hgtags Changeset: 205834867346 Author:lana Date: 2013-10-31 16:31 -0700 URL: http://hg.o

hg: jdk8/tl/jaxp: 3 new changesets

Changeset: d3b6da1b3e25 Author:cl Date: 2013-10-31 12:36 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/jaxp/rev/d3b6da1b3e25 Added tag jdk8-b114 for changeset 1b1e12117fe2 ! .hgtags Changeset: f610fd46463e Author:lana Date: 2013-10-31 16:31 -0700 URL: http://hg.open

hg: jdk8/tl/langtools: 4 new changesets

Changeset: fea486d30d41 Author:cl Date: 2013-10-31 12:36 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/fea486d30d41 Added tag jdk8-b114 for changeset 850d2602ae98 ! .hgtags Changeset: 6b4d6205366c Author:lana Date: 2013-10-31 16:46 -0700 URL: http://hg

hg: jdk8/tl: 3 new changesets

Changeset: b65d48f6938a Author:cl Date: 2013-10-31 12:36 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/rev/b65d48f6938a Added tag jdk8-b114 for changeset 4f2011496393 ! .hgtags Changeset: 763ada2a1d8c Author:lana Date: 2013-10-31 16:24 -0700 URL: http://hg.openjdk.j

hg: jdk8/tl/jaxws: 2 new changesets

Changeset: e126d8eca69b Author:cl Date: 2013-10-31 12:36 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/jaxws/rev/e126d8eca69b Added tag jdk8-b114 for changeset 9ad289610fc6 ! .hgtags Changeset: 587560c222a2 Author:cl Date: 2013-11-07 08:16 -0800 URL: http://hg.openj

hg: jdk8/tl/corba: 4 new changesets

Changeset: d425685e0b74 Author:cl Date: 2013-10-31 12:36 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/corba/rev/d425685e0b74 Added tag jdk8-b114 for changeset 0bbccf77c23e ! .hgtags Changeset: 8d07115924b7 Author:lana Date: 2013-10-31 16:30 -0700 URL: http://hg.ope

hg: jdk8/tl/jdk: 8028041: Serialized Form description of j.l.String is not consistent with the implementation

Changeset: df2f7f288353 Author:rriggs Date: 2013-11-08 17:50 -0500 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/df2f7f288353 8028041: Serialized Form description of j.l.String is not consistent with the implementation Summary: Replaced incorrect description with reference to the

qualified host parameter for UnknownHostException? (was: hg: jdk8/tl/jdk: 8028074: InetAddress.getByName fails with UHE "invalid IPv6 address" if host name starts with a-f)

Hello, BTW: it would be good if UHE had a data member of the not-found host value. Actually the javadoc hints in that direction: # public UnknownHostException(String host) # # Parameters: #host - the detail message. which is quite confusing. Maybe a new constructor like UHE(String cause,

hg: jdk8/tl/jdk: 8028074: InetAddress.getByName fails with UHE "invalid IPv6 address" if host name starts with a-f

Changeset: 50df04934e86 Author:alanb Date: 2013-11-08 21:07 + URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/50df04934e86 8028074: InetAddress.getByName fails with UHE "invalid IPv6 address" if host name starts with a-f Reviewed-by: chegar ! src/share/classes/java/net/InetAdd

Re: 8028074: InetAddress.getByName fails with UnknownHostException: invalid IPv6 address if host name starts with a-f

Ah, I noticed this today. Thanks for fixing it so quickly. Michael On 08/11/13 20:43, Chris Hegarty wrote: The change looks good to me. Thanks for spotting this and jumping on it so quickly. -Chris. On 08/11/2013 20:39, Alan Bateman wrote: There's a small problem with the fix for JDK- 8019

Re: 8028074: InetAddress.getByName fails with UnknownHostException: invalid IPv6 address if host name starts with a-f

The change looks good to me. Thanks for spotting this and jumping on it so quickly. -Chris. On 08/11/2013 20:39, Alan Bateman wrote: There's a small problem with the fix for JDK- 8019834 that was pushed to jdk8/tl today. The patch means that UHE is thrown when doing a lookup of hosts that sta

8028074: InetAddress.getByName fails with UnknownHostException: invalid IPv6 address if host name starts with a-f

There's a small problem with the fix for JDK- 8019834 that was pushed to jdk8/tl today. The patch means that UHE is thrown when doing a lookup of hosts that start with a-f. I ran into it because I happen to be on a machine that starts with "a" :-) I'd like to get a patch into jdk8/tl quickly

hg: jdk8/tl/jdk: 8028076: Correct raw type lint warnings in core reflection implementation classes

Changeset: 11376ad23e21 Author:darcy Date: 2013-11-08 12:19 -0800 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/11376ad23e21 8028076: Correct raw type lint warnings in core reflection implementation classes Reviewed-by: lancea, alanb ! src/share/classes/sun/reflect/generics/ref

hg: jdk8/tl/jdk: 8025985: com.sun.management.OSMBeanFactory should not be public

Changeset: 40ca9e4866de Author:mchung Date: 2013-11-08 12:13 -0800 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/40ca9e4866de 8025985: com.sun.management.OSMBeanFactory should not be public Reviewed-by: alanb, erikj, ihse, jbachorik ! makefiles/lib/ServiceabilityLibraries.gmk ! m

hg: jdk8/tl/jdk: 8023462: TEST_BUG: test/com/sun/net/httpserver/bugs/B6433018.java fails on slow/single core machine

Changeset: 46982ca895b4 Author:tyan Date: 2013-11-08 18:54 + URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/46982ca895b4 8023462: TEST_BUG: test/com/sun/net/httpserver/bugs/B6433018.java fails on slow/single core machine Reviewed-by: chegar ! test/com/sun/net/httpserver/bugs/

Re: RFR for JDK-8023462: TEST_BUG: test/com/sun/net/httpserver/bugs/B6433018.java fails on slow/single core machine

Looks fine to me Tristan, I'll sponsor this change for you. Trivially, I will add a 30sec timeout to the wait, just in case there is a problem in the future. -Chris. On 11/04/2013 03:12 AM, Tristan Yan wrote: Hi Everyone Please review the fix for JDK-8023462

hg: jdk8/tl/jdk: 8028069: (ref) Finalizer.c not deleted in the changeset for JDK-8027351

Changeset: 1c9ba18198d5 Author:mchung Date: 2013-11-08 09:43 -0800 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/1c9ba18198d5 8028069: (ref) Finalizer.c not deleted in the changeset for JDK-8027351 Reviewed-by: alanb - src/share/native/java/lang/ref/Finalizer.c

hg: jdk8/tl/jdk: 8019834: InetAddress.getByName hangs for bad IPv6 literals

Changeset: 771c77b49bb6 Author:chegar Date: 2013-11-08 15:15 + URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/771c77b49bb6 8019834: InetAddress.getByName hangs for bad IPv6 literals Reviewed-by: alanb ! src/share/classes/java/net/InetAddress.java ! test/java/net/ipv6tests/BadI

hg: jdk8/tl/jdk: 8022963: java/net/NetworkInterface/Equals.java fails equality for Windows Teredo Interface

Changeset: 3112729d6b74 Author:tyan Date: 2013-11-08 15:12 + URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/3112729d6b74 8022963: java/net/NetworkInterface/Equals.java fails equality for Windows Teredo Interface Reviewed-by: chegar ! test/java/net/MulticastSocket/TestInterfac

hg: jdk8/tl/jdk: 8027351: (ref) Private finalize method invoked in preference to protected superclass method

Changeset: 41d7ce111bd8 Author:mchung Date: 2013-11-08 07:53 -0800 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/41d7ce111bd8 8027351: (ref) Private finalize method invoked in preference to protected superclass method Reviewed-by: alanb, dholmes, mr, plevart, psandoz ! makefiles

Re: RFR for JDK-8022963 /java/net/NetworkInterface/Equals.java fails with java.lang.RuntimeException: equality different for net8

I have not seen any objections, so I will push this for you. -Chris. On 08/11/2013 14:18, Tristan Yan wrote: Hi Chris I didn't this has been pushed, can you sponsor this for me. Thank you so much Tristan On Nov 5, 2013, at 2:40 AM, Chris Hegarty mailto:chris.hega...@oracle.com>> wrote: On 0

Re: RFR: 8022213 Intermittent test failures in java/net/URLClassLoader (Add jdk/testlibrary/FileUtils.java)

On 08/11/2013 15:01, roger riggs wrote: Hi, Does renaming the file/directory suffer the same delay? I have not tried, but I read that MoveFileEx does not suffer from this. I could see a cleanup mechanism that renames them to hidden files (or entirely out of the work directory) and then delet

Re: RFR: 8022213 Intermittent test failures in java/net/URLClassLoader (Add jdk/testlibrary/FileUtils.java)

Hi, Does renaming the file/directory suffer the same delay? I could see a cleanup mechanism that renames them to hidden files (or entirely out of the work directory) and then deletes them. That would immediately clear the namespace for tests to proceed. That technique should work on all pla

Re: RFR: 8022213 Intermittent test failures in java/net/URLClassLoader (Add jdk/testlibrary/FileUtils.java)

Alan, > An alternative might be to just throw the IOException with > InterruptedException as the cause. Perfect. Updated in the new webrev. Dan, You are completely correct. I was only catering for the case where "java.nio.file.FileSystemException: : The process cannot access the file beca

Re: RFR for JDK-8022963 /java/net/NetworkInterface/Equals.java fails with java.lang.RuntimeException: equality different for net8

Hi Chris I didn't this has been pushed, can you sponsor this for me. Thank you so much Tristan On Nov 5, 2013, at 2:40 AM, Chris Hegarty wrote: > > On 01/11/2013 14:43, Tristan Yan wrote: >> Hi everyone >> Please review the fix for JDK-8022963. >> >> http://cr.openjdk.java.net/~pzhang/Tristan/

Re: RFR 8019834: InetAddress.getByName should always throw UHE for bad IPv6 literals

On 08/11/2013 13:15, Alan Bateman wrote: ... http://cr.openjdk.java.net/~chegar/8019834/webrev.00/ This looks okay to me. You might want to adjust the bug summary slightly as UHE for bad IPv6 literal addresses is correct (it's just the hang due to the lookup). Thanks Alan, I'll update the sy

Re: RFR 8019834: InetAddress.getByName should always throw UHE for bad IPv6 literals

On 08/11/2013 11:32, Chris Hegarty wrote: This is an interesting little product bug that was originally thought to be a test stabilization issue, with java/net/ipv6tests/BadIPv6Addresses.java. Depending on the input/configuration/patch level getaddrinfo may try to lookup a malformed IPv6 lite

RFR 8019834: InetAddress.getByName should always throw UHE for bad IPv6 literals

This is an interesting little product bug that was originally thought to be a test stabilization issue, with java/net/ipv6tests/BadIPv6Addresses.java. Depending on the input/configuration/patch level getaddrinfo may try to lookup a malformed IPv6 literal, and block for several seconds waiting

hg: jdk8/tl/jdk: 8027752: sun/tools/jstatd/TestJstatdExternalRegistry.java: java.lang.SecurityException: attempt to add a Permission to a readonly Permissions object

Changeset: 8a4405fb40ba Author:ykantser Date: 2013-11-07 16:55 +0100 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/8a4405fb40ba 8027752: sun/tools/jstatd/TestJstatdExternalRegistry.java: java.lang.SecurityException: attempt to add a Permission to a readonly Permissions object Re