hg: jdk8/tl/corba: 8027943: serial version of com.sun.corba.se.spi.orbutil.proxy.CompositeInvocationHandlerImpl changed in 7u45

2013-11-07 Thread mandy . chung
Changeset: b99535e22efe Author:mchung Date: 2013-11-07 20:48 -0800 URL: http://hg.openjdk.java.net/jdk8/tl/corba/rev/b99535e22efe 8027943: serial version of com.sun.corba.se.spi.orbutil.proxy.CompositeInvocationHandlerImpl changed in 7u45 Reviewed-by: msheppar, alanb, lancea ! s

hg: jdk8/tl/langtools: 8027730: Fix release-8 type visitors to support intersection types

2013-11-07 Thread joe . darcy
Changeset: e39bd9401ea5 Author:darcy Date: 2013-11-07 20:11 -0800 URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/e39bd9401ea5 8027730: Fix release-8 type visitors to support intersection types Reviewed-by: jjg, jlahoda, sogoel ! src/share/classes/javax/lang/model/util/Simple

hg: jdk8/tl/jdk: 8024458: DataInput.readDouble refers to "readlong" instead of "readLong"

2013-11-07 Thread roger . riggs
Changeset: 04f071a95c29 Author:rriggs Date: 2013-11-07 20:56 -0500 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/04f071a95c29 8024458: DataInput.readDouble refers to "readlong" instead of "readLong" Summary: fix the typo Reviewed-by: lancea, chegar, dxu ! src/share/classes/java/i

Re: RFR: 8022213 Intermittent test failures in java/net/URLClassLoader (Add jdk/testlibrary/FileUtils.java)

2013-11-07 Thread Dan Xu
On 11/07/2013 11:04 AM, Alan Bateman wrote: On 07/11/2013 14:59, Chris Hegarty wrote: Given both Michael and Alan's comments. I've update the webrev: http://cr.openjdk.java.net/~chegar/fileUtils.01/webrev/ 1) more descriptive method names 2) deleteXXX methods return if interrupted, leaving t

Re: RFR: 8022213 Intermittent test failures in java/net/URLClassLoader (Add jdk/testlibrary/FileUtils.java)

2013-11-07 Thread Alan Bateman
On 07/11/2013 14:59, Chris Hegarty wrote: Given both Michael and Alan's comments. I've update the webrev: http://cr.openjdk.java.net/~chegar/fileUtils.01/webrev/ 1) more descriptive method names 2) deleteXXX methods return if interrupted, leaving the interrupt status set 3) Use Files.copy w

hg: jdk8/tl/jdk: 8027930: ResourceBundle test failures in fr locale

2013-11-07 Thread naoto . sato
Changeset: fb7abd509bd2 Author:naoto Date: 2013-11-07 10:03 -0800 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/fb7abd509bd2 8027930: ResourceBundle test failures in fr locale Reviewed-by: smarks ! test/java/util/ResourceBundle/ResourceBundleTest.java ! test/java/util/ResourceBun

Re: RFR: 8022213 Intermittent test failures in java/net/URLClassLoader (Add jdk/testlibrary/FileUtils.java)

2013-11-07 Thread Chris Hegarty
Given both Michael and Alan's comments. I've update the webrev: http://cr.openjdk.java.net/~chegar/fileUtils.01/webrev/ 1) more descriptive method names 2) deleteXXX methods return if interrupted, leaving the interrupt status set 3) Use Files.copy with REPLACE_EXISTING 4) Use SimpleFileVisit

Re: RFR: 8022213 Intermittent test failures in java/net/URLClassLoader (Add jdk/testlibrary/FileUtils.java)

2013-11-07 Thread Alan Bateman
On 07/11/2013 11:34, Chris Hegarty wrote: : I've also received another comment offline about the method names. They should be more descriptive, and highlight the difference between these methods and regular delete. So maybe move to public deleteWithRetry? That might be a bit better as otherwi

Re: RFR: 8022213 Intermittent test failures in java/net/URLClassLoader (Add jdk/testlibrary/FileUtils.java)

2013-11-07 Thread Michael McMahon
On 07/11/13 11:34, Chris Hegarty wrote: On 11/07/2013 11:19 AM, Michael McMahon wrote: Chris, Would it be useful to add some instrumentation/logging (to System.err) if it's taking more than one iteration to delete a file? We could end up with degraded test performance if there is a general prob

Re: RFR: 8022213 Intermittent test failures in java/net/URLClassLoader (Add jdk/testlibrary/FileUtils.java)

2013-11-07 Thread Chris Hegarty
On 11/07/2013 11:19 AM, Michael McMahon wrote: Chris, Would it be useful to add some instrumentation/logging (to System.err) if it's taking more than one iteration to delete a file? We could end up with degraded test performance if there is a general problem deleting files, and otherwise would h

Re: RFR: 8022213 Intermittent test failures in java/net/URLClassLoader (Add jdk/testlibrary/FileUtils.java)

2013-11-07 Thread Michael McMahon
Chris, Would it be useful to add some instrumentation/logging (to System.err) if it's taking more than one iteration to delete a file? We could end up with degraded test performance if there is a general problem deleting files, and otherwise would have no way of understanding what the problem

hg: jdk8/tl/jdk: 8027881: test/java/net/URLPermission/nstest/LookupTest.java failing intermittently, output insufficient

2013-11-07 Thread michael . x . mcmahon
Changeset: 88d1ed05a246 Author:michaelm Date: 2013-11-07 10:22 + URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/88d1ed05a246 8027881: test/java/net/URLPermission/nstest/LookupTest.java failing intermittently, output insufficient Reviewed-by: chegar ! test/java/net/URLPermissi

RFR: 8022213 Intermittent test failures in java/net/URLClassLoader (Add jdk/testlibrary/FileUtils.java)

2013-11-07 Thread Chris Hegarty
Virus checkers and, on more modern Windows OSes, Windows Experience Service, and other external processes, have been causing trouble when it comes to tests deleting files. On a number of occasions in the past retry logic has been added to tests that need to delete files. Also, the jtreg harnes

Re: RFR: 8027221 test/java/net/URLPermission/nstest/LookupTest.java failing intermittently, output insufficient

2013-11-07 Thread Chris Hegarty
Looks ok to me. -Chris. On 11/07/2013 09:31 AM, Michael McMahon wrote: This is a test fix. The test currently uses a fixed port number (in the policy file and Java test) We need to change to use a shell script so that a port can be chosen dynamically and the appropriate policy file created. T

RFR: 8027221 test/java/net/URLPermission/nstest/LookupTest.java failing intermittently, output insufficient

2013-11-07 Thread Michael McMahon
This is a test fix. The test currently uses a fixed port number (in the policy file and Java test) We need to change to use a shell script so that a port can be chosen dynamically and the appropriate policy file created. The change also adds the correct bug number to a different test change I pu

hg: jdk8/tl/jdk: 8027961: Inet[4|6]Address native initializing code should check field/MethodID values

2013-11-07 Thread chris . hegarty
Changeset: 82b276590b85 Author:chegar Date: 2013-11-07 08:23 + URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/82b276590b85 8027961: Inet[4|6]Address native initializing code should check field/MethodID values Reviewed-by: michaelm, rriggs ! src/share/native/java/net/Inet4Addr

hg: jdk8/tl/jdk: 8027822: ProblemList.txt Updates (11/2013)

2013-11-07 Thread chris . hegarty
Changeset: f37d62e295c0 Author:chegar Date: 2013-11-07 08:04 + URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/f37d62e295c0 8027822: ProblemList.txt Updates (11/2013) Reviewed-by: chegar, alanb Contributed-by: Amy Lu ! test/ProblemList.txt