hg: jdk8/tl/jdk: 8027612: java/io/File/MaxPathLength.java fails intermittently in the clean-up stage

2013-11-04 Thread dan . xu
Changeset: 6d1f3ba68db2 Author:dxu Date: 2013-11-04 15:48 -0800 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/6d1f3ba68db2 8027612: java/io/File/MaxPathLength.java fails intermittently in the clean-up stage Reviewed-by: chegar ! test/java/io/File/MaxPathLength.java

Re: hg: jdk8/tl/jdk: 8027687: The constructors of URLPermission class do not behave as described in javad

2013-11-04 Thread Michael McMahon
On 04/11/13 18:05, mark.reinh...@oracle.com wrote: 2013/11/4 1:49 -0800, michael.x.mcma...@oracle.com: Changeset: 48449b5390fa Author:michaelm Date: 2013-11-04 17:47 + URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/48449b5390fa 8027687: The constructors of URLPermission clas

Re: RFR for JDK-8022963 /java/net/NetworkInterface/Equals.java fails with java.lang.RuntimeException: equality different for net8

2013-11-04 Thread Chris Hegarty
On 01/11/2013 14:43, Tristan Yan wrote: Hi everyone Please review the fix for JDK-8022963. http://cr.openjdk.java.net/~pzhang/Tristan/8022963/webrev/ This is not pretty, but I don't have a better alternative. Any objections? Otherwise, I can help sponsor this. -Chris. Description: Since w

Re: hg: jdk8/tl/jdk: 8027687: The constructors of URLPermission class do not behave as described in javad

2013-11-04 Thread mark . reinhold
2013/11/4 1:49 -0800, michael.x.mcma...@oracle.com: > Changeset: 48449b5390fa > Author:michaelm > Date: 2013-11-04 17:47 + > URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/48449b5390fa > > 8027687: The constructors of URLPermission class do not behave as described > in javad >

hg: jdk8/tl/jdk: 8027687: The constructors of URLPermission class do not behave as described in javad

2013-11-04 Thread michael . x . mcmahon
Changeset: 48449b5390fa Author:michaelm Date: 2013-11-04 17:47 + URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/48449b5390fa 8027687: The constructors of URLPermission class do not behave as described in javad Reviewed-by: chegar, mduigou ! src/share/classes/java/net/HostPort

Re: RFR 8027687: The constructors of URLPermission class do not behave as described in javadoc

2013-11-04 Thread Chris Hegarty
The latest changes look better to me. Trivially ( and in agreement with Vitaly ), I would, but you don't have to, change: static final int CAP_DIFF = 0x20; // 'a' - 'A'; static String toLowerCase(String s) { final int len = s.length(); StringBuilder sb = null;

hg: jdk8/tl/jdk: 8027625: test/java/math/BigInteger/ExtremeShiftingTests.java needs @run tag to specify heap size

2013-11-04 Thread brian . burkhalter
Changeset: 92fb6baaebc4 Author:bpb Date: 2013-11-04 08:05 -0800 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/92fb6baaebc4 8027625: test/java/math/BigInteger/ExtremeShiftingTests.java needs @run tag to specify heap size Summary: Add @run tag to specify heap size Reviewed-by: alan

Re: RFR 8027687: The constructors of URLPermission class do not behave as described in javadoc

2013-11-04 Thread Vitaly Davidovich
That looks better. One suggestion is to use StringBuilder.append(s, 0, i) to avoid temp substring. Thanks Sent from my phone On Nov 4, 2013 8:35 AM, "Michael McMahon" wrote: > Vitaly, > > Good points, I agree. I think the optimisation is worthwhile > and not costly. I also found a small casti

Re: RFR 8027687: The constructors of URLPermission class do not behave as described in javadoc

2013-11-04 Thread Michael McMahon
Vitaly, Good points, I agree. I think the optimisation is worthwhile and not costly. I also found a small casting issue with StringBuilder.append(char) being interpreted as StringBuilder.append(int) Here is the updated webrev: http://cr.openjdk.java.net/~michaelm/8027687/webrev.2/ Thanks, Mich

hg: jdk8/tl/jdk: 8027755: Anti-delta incorrect push for 8025198

2013-11-04 Thread david . holmes
Changeset: 23982079ad49 Author:dholmes Date: 2013-11-04 07:39 -0500 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/23982079ad49 8027755: Anti-delta incorrect push for 8025198 Reviewed-by: alanb ! makefiles/CompileLaunchers.gmk ! makefiles/lib/CoreLibraries.gmk ! src/share/bin/java

Re: URGENT - In correct push Fwd: [JBS] (JDK-8025198) Intermittent test failure: java/util/concurrent/ThreadPoolExecutor/ThrowingTasks.java

2013-11-04 Thread David Holmes
On 4/11/2013 10:35 PM, Alan Bateman wrote: On 04/11/2013 12:10, David Holmes wrote: My commit pulled in a bunch of local changes that should never have been pushed (the import commit failed due to whitespace and when I re-issued the commit I didn't restrict it to the single test file). Can anyo

Re: URGENT - In correct push Fwd: [JBS] (JDK-8025198) Intermittent test failure: java/util/concurrent/ThreadPoolExecutor/ThrowingTasks.java

2013-11-04 Thread Alan Bateman
On 04/11/2013 12:10, David Holmes wrote: My commit pulled in a bunch of local changes that should never have been pushed (the import commit failed due to whitespace and when I re-issued the commit I didn't restrict it to the single test file). Can anyone roll this back on the actual server? It

URGENT - In correct push Fwd: [JBS] (JDK-8025198) Intermittent test failure: java/util/concurrent/ThreadPoolExecutor/ThrowingTasks.java

2013-11-04 Thread David Holmes
My commit pulled in a bunch of local changes that should never have been pushed (the import commit failed due to whitespace and when I re-issued the commit I didn't restrict it to the single test file). Can anyone roll this back on the actual server? Thanks, David Original Message --

hg: jdk8/tl/jdk: 8025198: Intermittent test failure: java/util/concurrent/ThreadPoolExecutor/ThrowingTasks.java

2013-11-04 Thread david . holmes
Changeset: d19ab5da83cc Author:dholmes Date: 2013-11-04 06:58 -0500 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/d19ab5da83cc 8025198: Intermittent test failure: java/util/concurrent/ThreadPoolExecutor/ThrowingTasks.java Reviewed-by: martin, dholmes Contributed-by: Tristan Yan