hg: jdk8/tl/jdk: 8024140: [TESTBUG] Profile based regression test groups for jdk repo

2013-09-03 Thread david . holmes
Changeset: 2cdd1078f45b Author:dholmes Date: 2013-09-03 23:47 -0400 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/2cdd1078f45b 8024140: [TESTBUG] Profile based regression test groups for jdk repo Reviewed-by: alanb, chegar ! test/TEST.groups

hg: jdk8/tl/langtools: 8023545: Misleading error message when using diamond operator with private constructor

2013-09-03 Thread vicente . romero
Changeset: 9be0afbdf244 Author:vromero Date: 2013-09-03 23:41 +0100 URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/9be0afbdf244 8023545: Misleading error message when using diamond operator with private constructor Reviewed-by: jjg ! src/share/classes/com/sun/tools/javac/co

hg: jdk8/tl: 8024200: handle hg wrapper with space after #!

2013-09-03 Thread mike . duigou
Changeset: 6d7f27953da6 Author:mduigou Date: 2013-09-03 15:23 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/rev/6d7f27953da6 8024200: handle hg wrapper with space after #! Reviewed-by: tbell ! common/bin/hgforest.sh

hg: jdk8/tl/langtools: 8023389: Javac fails to infer type for lambda used with intersection type and wildcards

2013-09-03 Thread vicente . romero
Changeset: fb5a846c4a49 Author:vromero Date: 2013-09-03 23:31 +0100 URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/fb5a846c4a49 8023389: Javac fails to infer type for lambda used with intersection type and wildcards Reviewed-by: jjg, vromero Contributed-by: maurizio.cimadam.

hg: jdk8/tl/langtools: 8023549: Compiler emitting spurious errors when constructor reference type is inferred and explicit type arguments are supplied

2013-09-03 Thread vicente . romero
Changeset: 438547d895dc Author:vromero Date: 2013-09-04 00:01 +0100 URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/438547d895dc 8023549: Compiler emitting spurious errors when constructor reference type is inferred and explicit type arguments are supplied Reviewed-by: jjg, v

hg: jdk8/tl/corba: 8017195: Introduce option to setKeepAlive parameter on CORBA sockets

2013-09-03 Thread sean . coffey
Changeset: af8e5bc3a150 Author:coffeys Date: 2013-09-03 22:35 +0100 URL: http://hg.openjdk.java.net/jdk8/tl/corba/rev/af8e5bc3a150 8017195: Introduce option to setKeepAlive parameter on CORBA sockets Reviewed-by: chegar, msheppar ! src/share/classes/com/sun/corba/se/impl/transport

hg: jdk8/tl/jdk: 8017195: Introduce option to setKeepAlive parameter on CORBA sockets

2013-09-03 Thread sean . coffey
Changeset: 5920155dd080 Author:coffeys Date: 2013-09-03 22:37 +0100 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/5920155dd080 8017195: Introduce option to setKeepAlive parameter on CORBA sockets Reviewed-by: chegar, msheppar + test/com/sun/corba/transport/KeepAliveSockets.java

hg: jdk8/tl/jdk: 8024015: TEST.groups: move jdk/lambda tests from jdk_other to jdk_lang

2013-09-03 Thread mike . duigou
Changeset: 4bdbe25b1e04 Author:mduigou Date: 2013-09-03 11:29 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/4bdbe25b1e04 8024015: TEST.groups: move jdk/lambda tests from jdk_other to jdk_lang Reviewed-by: alanb, mchung ! test/TEST.groups

RFR: 7180557 - InetAddress.getLocalHost throws UnknownHostException on java7u5 on OSX

2013-09-03 Thread Rob McKenna
Hi folks, Mac seems to have trouble looking up local hostnames using getaddrinfo unless a domain is set. The solution is to add a check with getifaddrs . This fix replaces a usage of _ALLBSD_SOURCE with MACOSX. I haven't seen a canonical answer on whether this is the way to go so I figured tr

Re: RFR:JDK-8021372 NetworkInterface.getNetworkInterfaces() returns duplicate hardware address

2013-09-03 Thread Mark Sheppard
Thanks for the feedback. yes, we can merge the conditional, that was my comment about the getAdapter function and the if else statement because of a spurious IPv4 comment. the 267(old) and 281(new) is the core of the issue old 262 if (nif->index == index) { 263

Re: RFR:JDK-8021372 NetworkInterface.getNetworkInterfaces() returns duplicate hardware address

2013-09-03 Thread Michael McMahon
On 03/09/13 10:45, Dmitry Samersoff wrote: Mark, 1. If I read the code correctly, ll. 168 - 177 is exactly the same as ll. 180 - 189 Could you refactor the fix to avoid code duplication? Would something like if ( (ptr->IfIndex != 0 && ptr->IfIndex == index) || (ptr->Ipv6IfIndex != 0

Re: RFR:JDK-8021372 NetworkInterface.getNetworkInterfaces() returns duplicate hardware address

2013-09-03 Thread Dmitry Samersoff
Mark, 1. If I read the code correctly, ll. 168 - 177 is exactly the same as ll. 180 - 189 Could you refactor the fix to avoid code duplication? Would something like if ( (ptr->IfIndex != 0 && ptr->IfIndex == index) || (ptr->Ipv6IfIndex != 0 && ptr->Ipv6IfIndex == index) ) { ... } work?

RFR:JDK-8021372 NetworkInterface.getNetworkInterfaces() returns duplicate hardware address

2013-09-03 Thread Mark Sheppard
Hi please oblige and review the fix below to address the issue in JDK-8021372: NetworkInterface.getNetworkInterfaces() returns duplicate hardware address http://cr.openjdk.java.net/~msheppar/8021372/webrev/ the handling of the Ipv6IfIndex was suspect when setting the interface index and when ret