hg: jdk8/tl/jdk: 8023881: IDN.USE_STD3_ASCII_RULES option is too strict to use Unicode in IDN.toASCII

2013-08-29 Thread xuelei . fan
Changeset: cdf68747b0fb Author:xuelei Date: 2013-08-29 18:58 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/cdf68747b0fb 8023881: IDN.USE_STD3_ASCII_RULES option is too strict to use Unicode in IDN.toASCII Reviewed-by: michaelm ! src/share/classes/java/net/IDN.java + test/j

hg: jdk8/tl/langtools: 8023833: Replace direct use of AnnotatedType in javadoc code

2013-08-29 Thread jonathan . gibbons
Changeset: 23f0f3c9c44a Author:jjg Date: 2013-08-29 19:19 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/23f0f3c9c44a 8023833: Replace direct use of AnnotatedType in javadoc code Reviewed-by: darcy ! src/share/classes/com/sun/tools/javadoc/AnnotatedTypeImpl.java ! src/

hg: jdk8/tl: 8023892: test/Makefile shouldn't try to tell langtools/test/Makefile where to put output.

2013-08-29 Thread mike . duigou
Changeset: 51a61778a99d Author:mduigou Date: 2013-08-29 16:04 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/rev/51a61778a99d 8023892: test/Makefile shouldn't try to tell langtools/test/Makefile where to put output. Reviewed-by: erikj, vromero, henryjen ! test/Makefile

hg: jdk8/tl/langtools: 8022744: javac -Xpkginfo command's documentation is sparse

2013-08-29 Thread jonathan . gibbons
Changeset: 96b6865eda94 Author:jjg Date: 2013-08-29 12:11 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/96b6865eda94 8022744: javac -Xpkginfo command's documentation is sparse Reviewed-by: darcy ! src/share/classes/com/sun/tools/javac/main/Option.java

hg: jdk8/tl/langtools: 8013384: Potential infinite loop in javadoc

2013-08-29 Thread jonathan . gibbons
Changeset: 9c0e192c0926 Author:jjg Date: 2013-08-29 12:03 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/9c0e192c0926 8013384: Potential infinite loop in javadoc Reviewed-by: darcy ! src/share/classes/com/sun/tools/javadoc/ClassDocImpl.java

hg: jdk8/tl/langtools: 8023522: tools/javac/tree/TypeAnnotationsPretty.java test cases with @TA newline fail on windows only

2013-08-29 Thread jonathan . gibbons
Changeset: b0b25c1f6cbd Author:jjg Date: 2013-08-29 11:57 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/b0b25c1f6cbd 8023522: tools/javac/tree/TypeAnnotationsPretty.java test cases with @TA newline fail on windows only Reviewed-by: darcy ! test/tools/javac/tree/TypeA

hg: jdk8/tl/langtools: 8001669: javadoc internal DocletAbortException should set cause when appropriate

2013-08-29 Thread jonathan . gibbons
Changeset: 0e6577980181 Author:jjg Date: 2013-08-29 11:41 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/0e6577980181 8001669: javadoc internal DocletAbortException should set cause when appropriate Reviewed-by: darcy ! src/share/classes/com/sun/tools/doclets/formats/

hg: jdk8/tl/jdk: 4792059: test/java/io/pathNames/GeneralSolaris.java fails on symbolic links

2013-08-29 Thread dan . xu
Changeset: 5bf4f285 Author:dxu Date: 2013-08-29 10:43 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/5bf4f285 4792059: test/java/io/pathNames/GeneralSolaris.java fails on symbolic links Summary: Exclude the possible usage of linked files or directories in the test Rev

Re: [JDK 8] Code review request JDK-8023881, IDN.USE_STD3_ASCII_RULES option is too strict to use Unicode in IDN.toASCII

2013-08-29 Thread Xuelei Fan
On 8/29/2013 10:57 PM, Michael McMahon wrote: > Xuelei, > > This looks fine. > > I would add a comment to line 408-409 that says something like: > > Non LDH refers to characters in the ASCII range, but which > are not letters, digits or the hypen. > I will add the comment. Thanks for the quick

Re: [JDK 8] Code review request JDK-8023881, IDN.USE_STD3_ASCII_RULES option is too strict to use Unicode in IDN.toASCII

2013-08-29 Thread Michael McMahon
Xuelei, This looks fine. I would add a comment to line 408-409 that says something like: Non LDH refers to characters in the ASCII range, but which are not letters, digits or the hypen. That explains what exactly was fixed here. Michael On 29/08/13 13:46, Xuelei Fan wrote: Hi, Please revie

[JDK 8] Code review request JDK-8023881, IDN.USE_STD3_ASCII_RULES option is too strict to use Unicode in IDN.toASCII

2013-08-29 Thread Xuelei Fan
Hi, Please review the fix of JDK-8023881. webrev: http://cr.openjdk.java.net/~xuelei/8023881/webrev.00/ This bug has not been ported to bugs.sun.com. The following is the descirption of the issue. IDN.toASCII("示例.com", IDN.USE_STD3_ASCII

hg: jdk8/tl/jdk: 8023786: (jdk) setjmp/longjmp changes the process signal mask on OS X

2013-08-29 Thread staffan . larsen
Changeset: 779ff9f3b2e3 Author:sla Date: 2013-08-29 11:22 +0200 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/779ff9f3b2e3 8023786: (jdk) setjmp/longjmp changes the process signal mask on OS X Reviewed-by: dholmes ! src/share/back/SDE.c ! src/share/native/common/check_code.c