Changeset: 0beaa65c90c8
Author:okutsu
Date: 2013-08-08 13:51 +0900
URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/0beaa65c90c8
8015986: Incorrect Localization of HijrahChronology
Reviewed-by: naoto
Contributed-by: scolebou...@joda.org, roger.ri...@oracle.com
! make/tools/src/build
Ivan,
On 8/08/2013 2:05 PM, Ivan Gerasimov wrote:
David, Alan,
I added checking for NULL results and throwing OOMException if necessary.
You don't need to throw it yourself:
JNU_ThrowOutOfMemoryError(env, NULL);
Assuming a correct VM implementation if NULL is returned then an OOME
shoul
David, Alan,
I added checking for NULL results and throwing OOMException if necessary.
I've also added some spaces along the code to improve indentation.
Would you please review the updated webrev?
http://washi.ru.oracle.com/~igerasim/webrevs/8022584/1/webrev/
Sincerely yours,
Ivan
On 08.08.
On 07/08/2013 18:20, Ivan Gerasimov wrote:
Thanks Alan!
I've checked that and it turns out that GetStringUTFChars cannot
return NULL.
For allocation of the result string it calls AllocateHeap() with the
default EXIT_OOM fail strategy.
Thus, in case of being unable to allocate memory it simply
On 8/08/2013 11:20 AM, Ivan Gerasimov wrote:
Thanks Alan!
I've checked that and it turns out that GetStringUTFChars cannot return
NULL.
For allocation of the result string it calls AllocateHeap() with the
default EXIT_OOM fail strategy.
Thus, in case of being unable to allocate memory it simply
Changeset: 8c50c27418d3
Author:smarks
Date: 2013-08-07 16:29 -0700
URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/8c50c27418d3
8022479: clean up warnings from sun.tools.asm
Reviewed-by: lancea, darcy
! src/share/classes/sun/tools/asm/Assembler.java
! src/share/classes/sun/tools/as
Thanks Alan!
I've checked that and it turns out that GetStringUTFChars cannot return
NULL.
For allocation of the result string it calls AllocateHeap() with the
default EXIT_OOM fail strategy.
Thus, in case of being unable to allocate memory it simply stops VM.
Sincerely yours,
Ivan
On 08.08.
(cc'ing net-dev).
The change looks okay to me. One suggestion (while you are there) is to
check the return from GetStringUTFChars so that the name returns when
it fails with NULL.
-Alan.
On 07/08/2013 17:46, Ivan Gerasimov wrote:
Hello everybody!
Some methods of NetworkInterface class wer
Changeset: d1c82d5bee3f
Author:dxu
Date: 2013-08-07 12:13 -0700
URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/d1c82d5bee3f
8022554: Fix Warnings in sun.invoke.anon Package
Reviewed-by: darcy, mduigou, lancea
! src/share/classes/sun/invoke/anon/ConstantPoolPatch.java
Changeset: c1f129f62f36
Author:lagergren
Date: 2013-08-07 08:08 -0700
URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/c1f129f62f36
8022454: Fixed various serializations and deprecation warnings in java.util,
java.net and sun.tools
Reviewed-by: darcy
Contributed-by: marcus.lagerg...
In that case, my vote would be to just put it in release notes. If there
are others in JDK 8, then maybe
they could be listed together.
Michael
On 07/08/13 17:03, Joe Darcy wrote:
Hello,
Source incompatible changes of this magnitude (if not exact
character), have been made in major release b
Hello,
Source incompatible changes of this magnitude (if not exact character),
have been made in major release before.
IMO, release notes are the proper mechanism to inform users of such a
change rather than the constructor javadoc. (Putting such time-sensitive
notes in javadoc tends to age
As a matter of interest, what (if any) precedent is there for such
source incompatible changes? Maybe it's more common that I thought.
Michael.
On 07/08/13 16:45, Chris Hegarty wrote:
I'm not sure if there is precedent for adding such release notes
inline in the javadoc (and subsequently remove
I'm not sure if there is precedent for adding such release notes inline
in the javadoc (and subsequently removed in the next major release), but
I am not opposed to it in principle. I guess it may look something like:
* Note: In this release, this constructor no longer declares
* that
Please review the new update:
http://cr.openjdk.java.net./~xuelei/8020842/webrev.01/
With this update, "com." is valid (return "com."); "." and
"example..com" are invalid. And IAE will be thrown for invalid IDN.
Thanks,
Xuelei
On 8/7/2013 10:18 PM, Michael McMahon wrote:
> On 07/08/13 15:13, X
On 07/08/13 15:13, Xuelei Fan wrote:
On 8/7/2013 10:05 PM, Michael McMahon wrote:
Resolvers seem to accept queries using trailing dots.
eg nslookup www.oracle.com.
or InetAddress.getByName("www.oracle.com.");
The part of RFC3490 quoted below seems to me to be saying
that the empty label impli
On 8/7/2013 10:05 PM, Michael McMahon wrote:
> Resolvers seem to accept queries using trailing dots.
>
> eg nslookup www.oracle.com.
>
> or InetAddress.getByName("www.oracle.com.");
>
> The part of RFC3490 quoted below seems to me to be saying
> that the empty label implied by the trailing dot i
Resolvers seem to accept queries using trailing dots.
eg nslookup www.oracle.com.
or InetAddress.getByName("www.oracle.com.");
The part of RFC3490 quoted below seems to me to be saying
that the empty label implied by the trailing dot is not regarded
as a label so that you don't end up calling t
Changeset: 8c7cf4926157
Author:xuelei
Date: 2013-08-07 06:42 -0700
URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/8c7cf4926157
8013809: deadlock in SSLSocketImpl between between write and close
Reviewed-by: wetmore
! src/share/classes/sun/security/ssl/SSLSocketImpl.java
Xuelei,
root label is an empty label[1], dot is a label separator, so in printed
form domain names is dot-terminated.
Please see also below inline.
[1]
RFC rfc1034.txt:
Internally, programs that manipulate domain names should represent them
as sequences of labels, where each label is a length o
On 8/7/2013 12:06 AM, Matthew Hall wrote:
> Trailing dots are allowed in plain DNS (thus almost surely in IDN),
> and the single dot represents the root zone. So you have to be
> careful making this sort of change to check the DNS RFCs first.
That's the first question we need to answer, whether ID
Changeset: 906dd23334c1
Author:weijun
Date: 2013-08-07 19:06 +0800
URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/906dd23334c1
7151062: [macosx] SCDynamicStore prints error messages to stderr
Reviewed-by: xuelei
! src/macosx/native/java/util/SCDynamicStoreConfig.m
Changeset: c7dcf899
Author:vromero
Date: 2013-08-07 11:04 +0100
URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/c7dcf899
8008274: javac should not reference/use sample code
Reviewed-by: jjg
! src/share/classes/com/sun/tools/javac/Main.java
Changeset: f3deeccbf4cf
Author:vromero
Date: 2013-08-07 10:41 +0100
URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/f3deeccbf4cf
8020997: TreeMaker.AnnotationBuilder creates broken element literals with
repeating annotations
Reviewed-by: jjg, jfranck
! src/share/classes/com/
24 matches
Mail list logo
