Re: [8] Request for Review: 8021833: javadoc cleanup in java.net

2013-07-29 Thread Joseph Darcy
Hi Jason, Looks good; thanks, -Joe On 7/29/2013 4:03 PM, Jason Uh wrote: Hi Joe, Can I get a review of this changeset? This change converts and tags to {@code ...} and also converts the package.html file to package-info.java. webrev: http://cr.openjdk.java.net/~juh/8021833/webrev.00/ C

hg: jdk8/tl/jdk: 8021841: Remove SSLEngineDeadlock.java from problem list

2013-07-29 Thread xuelei . fan
Changeset: 613cc7beba64 Author:xuelei Date: 2013-07-29 19:36 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/613cc7beba64 8021841: Remove SSLEngineDeadlock.java from problem list Reviewed-by: wetmore ! test/ProblemList.txt

hg: jdk8/tl/jdk: 8020156: TreeMap.values().spliterator() does not report ORDERED; ...

2013-07-29 Thread paul . sandoz
Changeset: e83fc6d9cf03 Author:psandoz Date: 2013-07-29 19:41 +0100 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/e83fc6d9cf03 8020156: TreeMap.values().spliterator() does not report ORDERED 8020009: TreeMap.entrySet().spliterator() reports SORTED + null comparator but the elemen

hg: jdk8/tl/langtools: 8020689: Missing LineNumberTable entries in compiled class files

2013-07-29 Thread maurizio . cimadamore
Changeset: 8c4b2987edac Author:jlahoda Date: 2013-07-28 10:17 +0200 URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/8c4b2987edac 8020689: Missing LineNumberTable entries in compiled class files Reviewed-by: ksrini, mcimadamore ! src/share/classes/com/sun/tools/javac/jvm/Gen.j

hg: jdk8/tl/langtools: 8021338: Diamond finder may mark a required type argument as unnecessary

2013-07-29 Thread maurizio . cimadamore
Changeset: cd9e8cea1b3c Author:jlahoda Date: 2013-07-28 10:17 +0200 URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/cd9e8cea1b3c 8021338: Diamond finder may mark a required type argument as unnecessary Reviewed-by: mcimadamore ! src/share/classes/com/sun/tools/javac/comp/Attr

Remaining doclint issues in java.net

2013-07-29 Thread Chris Hegarty
There are two remaining doclint warnings in the java.net package. >:javac -Xdoclint:all/protected src/share/classes/java/net/DatagramPacket.java src/share/classes/java/net/DatagramPacket.java:142: warning: no @throws for java.net.SocketException public DatagramPacket(byte buf[], int offse