hg: jdk8/tl/jdk: 8020810: Typo in javadoc for Class.toGenericString()

2013-07-18 Thread joe . darcy
Changeset: 2323b973adaa Author:darcy Date: 2013-07-18 23:16 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/2323b973adaa 8020810: Typo in javadoc for Class.toGenericString() Reviewed-by: dholmes ! src/share/classes/java/lang/Class.java ! src/share/classes/java/lang/reflect/Pa

Re: Code Review Request: 8017779: java/net/Authenticator/B4769350.java fails

2013-07-18 Thread Kurchi Hazra
Hi Michael, I added some comments as to what is the purpose of the latches and barriers. Those comments alongwith the comments describing the purpose of the handlers should make the synchronization logic more clear. Let me know what you think: http://cr.openjdk.java.net/~khazra/8017779/webr

Re: Code Review Request: 8020498: Crash when both libnet.so and libmawt.so are loaded

2013-07-18 Thread Chris Hegarty
On 18 Jul 2013, at 19:14, Kurchi Hazra wrote: > Alright, I'll add it before asking for approval from 7u-dev. > > - Kurchi > > On 7/18/2013 11:11 AM, Dmitry Samersoff wrote: >> Kurchi, >> >> As you don't plan to use this function outside of net_util.c it's better >> to add static keyword as we

Re: Code Review Request: 8020498: Crash when both libnet.so and libmawt.so are loaded

2013-07-18 Thread Kurchi Hazra
Alright, I'll add it before asking for approval from 7u-dev. - Kurchi On 7/18/2013 11:11 AM, Dmitry Samersoff wrote: Kurchi, As you don't plan to use this function outside of net_util.c it's better to add static keyword as well. -Dmitry On 2013-07-18 21:55, Kurchi Hazra wrote: Hi Chris, Th

Re: Code Review Request: 8020498: Crash when both libnet.so and libmawt.so are loaded

2013-07-18 Thread Dmitry Samersoff
Kurchi, As you don't plan to use this function outside of net_util.c it's better to add static keyword as well. -Dmitry On 2013-07-18 21:55, Kurchi Hazra wrote: > Hi Chris, > > Thanks for the additional information. How about this fix: > http://cr.openjdk.java.net/~khazra/8020498/webrev.01/ >

hg: jdk8/tl/jdk: 8016025: JSR 310 DateTime API Updates IV; ...

2013-07-18 Thread xueming . shen
Changeset: b39797bb86c0 Author:sherman Date: 2013-07-18 11:02 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/b39797bb86c0 8016025: JSR 310 DateTime API Updates IV 8020418: Cleanup of -Xlint warnings in java.time 8016623: test/java/time/format/TestDateTimeTextProvider.java fai

Re: Code Review Request: 8020498: Crash when both libnet.so and libmawt.so are loaded

2013-07-18 Thread Kurchi Hazra
Hi Chris, Thanks for the additional information. How about this fix: http://cr.openjdk.java.net/~khazra/8020498/webrev.01/ - Kurchi On 7/18/2013 2:44 AM, Chris Hegarty wrote: On 18/07/2013 01:19, Kurchi Hazra wrote: Hi, We are seeing a crash when both libmawt.so and libnet.so are loaded,

Re: Code Review Request: 8020498: Crash when both libnet.so and libmawt.so are loaded

2013-07-18 Thread Chris Hegarty
On 18/07/2013 01:19, Kurchi Hazra wrote: Hi, We are seeing a crash when both libmawt.so and libnet.so are loaded, and the init() method in src/share/native/java/net/net_util.c is called, but an init() method in libmawt.so gets invoked instead. Although it is difficult to reproduce the problem,