hg: jdk8/tl/jdk: 2 new changesets

2013-05-31 Thread mike . duigou
Changeset: fc0b3e86fdcf Author:mduigou Date: 2013-05-31 11:06 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/fc0b3e86fdcf 8015686: {Int|Long}SummaryStatistics toString() throws IllegalFormatConversionException Reviewed-by: dholmes, alanb, psandoz ! src/share/classes/java/ut

hg: jdk8/tl/jdk: 2 new changesets

2013-05-31 Thread kurchi . subhra . hazra
Changeset: 11cdcf87ad5d Author:jzavgren Date: 2013-05-31 15:23 -0400 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/11cdcf87ad5d 8008972: Memory leak: Java_java_net_TwoStacksPlainDatagramSocketImpl_receive0 [parfait] Summary: Modified the code so that "jumbo frames" are truncated

hg: jdk8/tl/jdk: 8015628: Test Failure in closed/java/io/pathNames/GeneralSolaris.java

2013-05-31 Thread dan . xu
Changeset: f522bbdf2859 Author:dxu Date: 2013-05-31 13:34 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/f522bbdf2859 8015628: Test Failure in closed/java/io/pathNames/GeneralSolaris.java Reviewed-by: alanb ! test/java/io/pathNames/General.java ! test/java/io/pathNames/Gener

Re: RFR JDK-8008972

2013-05-31 Thread Dmitry Samersoff
John, Looks good for me. -Dmitry On 2013-05-31 21:06, John Zavgren wrote: > All: > I have a revised webrev image that's ready for review: > http://cr.openjdk.java.net/~jzavgren/8008972/webrev.04/ > > Thanks > John > > On 05/13/2013 04:14 PM, John Zavgren wrote: >> Greetings: >> I posted a new

Re: RFR JDK-8008972

2013-05-31 Thread Alan Bateman
On 31/05/2013 19:54, John Zavgren wrote: Alan: There are two parameters involved here that have similar names: MAX_PACKET_LEN and MAX_BUFFER_LEN. If the code receives a "jumbo" packet (larger than MAX_PACKET_LEN) then the length is truncated to MAX_PACKET_LEN before the next step. In that "

Re: RFR JDK-8008972

2013-05-31 Thread Alan Bateman
On 31/05/2013 18:06, John Zavgren wrote: All: I have a revised webrev image that's ready for review: http://cr.openjdk.java.net/~jzavgren/8008972/webrev.04/ There's something not quite right here, it looks to me that packetBufferLen will always be truncated to MAX_PACKET_LEN to therefore the m

Re: RFR JDK7188517

2013-05-31 Thread Kurchi Hazra
Looks good to me too! - Kurchi On 5/31/2013 7:42 AM, Chris Hegarty wrote: Looks fine to me John. -Chris. On 05/31/2013 01:11 PM, John Zavgren wrote: All: I'd like to give everyone another chance to weigh in on this change: http://cr.openjdk.java.net/~jzavgren/7188517/webrev.04/ so that I ca

Re: RFR JDK-8008972

2013-05-31 Thread Chris Hegarty
This looks fine to me John. Thanks for persisting with me to get thus done. -Chris On 31 May 2013, at 18:06, John Zavgren wrote: > All: > I have a revised webrev image that's ready for review: > http://cr.openjdk.java.net/~jzavgren/8008972/webrev.04/ > > Thanks > John > > On 05/13/2013 04:14

Re: RFR JDK-8008972

2013-05-31 Thread John Zavgren
All: I have a revised webrev image that's ready for review: http://cr.openjdk.java.net/~jzavgren/8008972/webrev.04/ Thanks John On 05/13/2013 04:14 PM, John Zavgren wrote: Greetings: I posted a new webrev image: http://cr.openjdk.java.net/~jzavgren/8008972/webrev.03/ that fixes a memory leak.

Re: RFR JDK7188517

2013-05-31 Thread Chris Hegarty
Looks fine to me John. -Chris. On 05/31/2013 01:11 PM, John Zavgren wrote: All: I'd like to give everyone another chance to weigh in on this change: http://cr.openjdk.java.net/~jzavgren/7188517/webrev.04/ so that I can wrap up this fix ASAP. (It makes HTTP cookies that begin with a dollar sig

RFR 8011719: Properties.loadFromXML fails with a chunked HTTP connection

2013-05-31 Thread Chris Hegarty
HttpURLConnection returns various input streams, depending on the response from the server. fixed content-length, chunked, error. Most, if not all, are wrapped in an implementation specific HttpInputStream, to correctly handle caching of responses. The issue reported by 8011719 is that the clos

Re: RFR JDK7188517

2013-05-31 Thread John Zavgren
All: I'd like to give everyone another chance to weigh in on this change: http://cr.openjdk.java.net/~jzavgren/7188517/webrev.04/ so that I can wrap up this fix ASAP. (It makes HTTP cookies that begin with a dollar sign "illegal".) Thanks! John On 05/15/2013 07:54 AM, John Zavgren wrote: Gree

Re: RFR: 8014723: sun/misc/URLClassPath/ClassnameCharTest.java failing

2013-05-31 Thread Alan Bateman
On 30/05/2013 17:49, Michael McMahon wrote: http://cr.openjdk.java.net/~michaelm/8014723/webrev.1/ regression caused by the HttpURLPermission implemenation not using the raw URI accessor methods. Some other changes are coming to this class, but I just want to fix this problem separately. Thank

hg: jdk8/tl/jdk: 8014854: (bf) CharBuffer.chars too slow with default implementation

2013-05-31 Thread alan . bateman
Changeset: 243cd682c47b Author:alanb Date: 2013-05-31 12:17 +0100 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/243cd682c47b 8014854: (bf) CharBuffer.chars too slow with default implementation Reviewed-by: erikj, briangoetz, henryjen, psandoz, mduigou ! makefiles/CompileJavaClass

hg: jdk8/tl/langtools: 7179353: try-with-resources fails to compile with generic exception parameters

2013-05-31 Thread vicente . romero
Changeset: 9f11c7676cd5 Author:vromero Date: 2013-05-31 10:04 +0100 URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/9f11c7676cd5 7179353: try-with-resources fails to compile with generic exception parameters Reviewed-by: mcimadamore ! src/share/classes/com/sun/tools/javac/com

hg: jdk8/tl/jdk: 7107883: getNetworkPrefixLength() does not return correct prefix length

2013-05-31 Thread chris . hegarty
Changeset: dcf42861b5b1 Author:chegar Date: 2013-05-31 09:30 +0100 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/dcf42861b5b1 7107883: getNetworkPrefixLength() does not return correct prefix length Reviewed-by: alanb, michaelm ! src/solaris/native/java/net/NetworkInterface.c ! te

hg: jdk8/tl/jdk: 8014732: Minor spec issue: java.util.Spliterator.getExactSizeIfKnown

2013-05-31 Thread paul . sandoz
Changeset: b47044426bcd Author:psandoz Date: 2013-05-31 09:58 +0200 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/b47044426bcd 8014732: Minor spec issue: java.util.Spliterator.getExactSizeIfKnown Summary: A minor documentation issue (not a spec issue). Reviewed-by: chegar, dl ! s

Re: RFR: 8014723: sun/misc/URLClassPath/ClassnameCharTest.java failing

2013-05-31 Thread Chris Hegarty
Thanks for the additional update to the ProblemList Michael. The source change looks fine to me. I assume that all encoding, as with URL, needs to be done at the application level. Since you are effectively using the single arg URI constructor, then all accessors should use the raw form. -Ch