On Apr 20, 2013, at 4:40 AM, Dmitry Samersoff
wrote:
> Kurchi,
>
> if *netaddrPP == NULL at 367 and calloc fails at 391 we would jump
> to freeAllocatedMemory with start == NULL
>
True, but then we skip to line 444 since *netaddrPP == NULL, so we don't get to
line 438.
I am just saying
Kurchi,
if *netaddrPP == NULL at 367 and calloc fails at 391 we would jump
to freeAllocatedMemory with start == NULL
I have no ideas whether this code path is possible in reality or not,
but it stops my eyes.
-Dmitry
On 2013-04-20 14:55, Kurchi Subhra Hazra wrote:
>
>
> On Apr 20, 2013, at
On Apr 20, 2013, at 3:16 AM, Dmitry Samersoff
wrote:
> John,
>
> 102, 145 else is redundant.
>
> 438 - we will crash here if start is null
Maybe it is good to have an additional check for start != null, but from what I
see, start will not be null if *netaddrPP is not null.
>
> -Dmi
John,
102, 145 else is redundant.
438 - we will crash here if start is null
-Dmitry
On 2013-04-20 01:33, John Zavgren wrote:
> Greetings:
>
> I fixed the bad realloc pattern. Please let me know what you think.
> http://cr.openjdk.java.net/~jzavgren/8012108/webrev.02/
>
> Thanks!
> John Z
>
On 04/20/2013 02:06 AM, Kurchi Subhra Hazra wrote:
Hi John,
Minor nit, the formatting around line 101 looks off,
How about something like this:
if {
// remains same
} else {
adapterInfo = adapterInfoTemp;
}
Or simply, just leave the else out.
adapterInfoTemp = (IP_ADAPTER_ADDR
