hg: jdk8/tl/jdk: 8006895: Clarify that FunctionalInferface is only informative

2013-01-24 Thread joe . darcy
Changeset: 4d3c05cc21d5 Author:darcy Date: 2013-01-24 16:54 -0800 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/4d3c05cc21d5 8006895: Clarify that FunctionalInferface is only informative Reviewed-by: briangoetz ! src/share/classes/java/lang/FunctionalInterface.java

hg: jdk8/tl/jdk: 8006863: javadoc cleanup for 8005408

2013-01-24 Thread vincent . x . ryan
Changeset: b3f0e0c79bcc Author:vinnie Date: 2013-01-24 18:21 + URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/b3f0e0c79bcc 8006863: javadoc cleanup for 8005408 Reviewed-by: alanb ! src/share/classes/java/security/PKCS12Attribute.java

Re: Code Review Request: 7017962: Obsolete link is used in URL class level spec

2013-01-24 Thread Kurchi Hazra
Thanks Mike, makes sense - I'll change the port number on line 68 to 1080 before pushing. - Kurchi On 24.01.2013 09:38, Mike Duigou wrote: Looks good to me. The alternative port example at line 68 uses port 80 which is the default. 1080 or 8080 perhaps? Mike On Jan 24 2013, at 09:27 , Kurch

hg: jdk8/tl/jdk: 8006850: [pack200] disable pack200 tests until JSR-308 is implemented

2013-01-24 Thread kumar . x . srinivasan
Changeset: 1fd613016ad9 Author:ksrini Date: 2013-01-24 09:34 -0800 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/1fd613016ad9 8006850: [pack200] disable pack200 tests until JSR-308 is implemented Reviewed-by: alanb ! test/ProblemList.txt

Re: Code Review Request: 7017962: Obsolete link is used in URL class level spec

2013-01-24 Thread Mike Duigou
Looks good to me. The alternative port example at line 68 uses port 80 which is the default. 1080 or 8080 perhaps? Mike On Jan 24 2013, at 09:27 , Kurchi Hazra wrote: > Apologies, but I have a new suggestion. It is safer to redirect to an archived > version of the document that we want to link

Re: Code Review Request: 7017962: Obsolete link is used in URL class level spec

2013-01-24 Thread Kurchi Hazra
Apologies, but I have a new suggestion. It is safer to redirect to an archived version of the document that we want to link to. http://cr.openjdk.java.net/~khazra/7017962/webrev.01/src/share/classes/java/net/URL.java.sdiff.html Thanks to Mike for pointing this out. - Kurchi On 23.01.2013 05:5

hg: jdk8/tl/jdk: 8006524: JSR-3: Allows java.beans to be optional

2013-01-24 Thread alan . bateman
Changeset: b68ac92d0b2a Author:alanb Date: 2013-01-24 09:47 + URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/b68ac92d0b2a 8006524: JSR-3: Allows java.beans to be optional Reviewed-by: dfuchs, mchung ! src/share/classes/javax/management/MXBean.java ! src/share/classes/javax/man

Re: Code review request 7183373: URLClassloader.close() does not close JAR files whose resources have been loaded via getResource()

2013-01-24 Thread Chris Hegarty
On 24 Jan 2013, at 02:54, Frank Ding wrote: > Hi Kurchi, > > Thanks. Is it eligible for committing? Yes, you have sufficient reviews so can commit. -Chris > > Best regards, > Frank > > On 1/23/2013 4:45 PM, Kurchi Subhra Hazra wrote: >> Looks good to me. >> >> Thanks, >> Kurchi >> >>