java.net.URL.getBasePath() --> time to have it?

2013-01-15 Thread Bruno Borges
Hey folks, To be able to get the basePath of a URL, so we can load other stuff somewhere else, defined as a relative path, it is common to see people coding stuff like this: https://gist.github.com/4355670 I don't know if there's something in the Java API that offers this, but it would be

hg: jdk8/tl/langtools: 8006224: Doclint NPE for attribute with no value

2013-01-15 Thread jonathan . gibbons
Changeset: bc1023e0e533 Author:jjg Date: 2013-01-15 13:03 -0800 URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/bc1023e0e533 8006224: Doclint NPE for attribute with no value Reviewed-by: darcy ! src/share/classes/com/sun/tools/doclint/Checker.java ! src/share/classes/com/sun/

hg: jdk8/tl/langtools: 8006344: Broken javadoc link in javax.lang.model.element.Element

2013-01-15 Thread chris . hegarty
Changeset: f805b5e3c9d1 Author:chegar Date: 2013-01-15 20:38 + URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/f805b5e3c9d1 8006344: Broken javadoc link in javax.lang.model.element.Element Reviewed-by: lancea, alanb, jfranck ! src/share/classes/javax/lang/model/element/El

hg: jdk8/tl/jdk: 8005618: TEST_BUG: java/lang/ProcessBuilder/Basic.java failing intermittently

2013-01-15 Thread rob . mckenna
Changeset: 44d6cabc9a3f Author:robm Date: 2013-01-15 19:58 + URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/44d6cabc9a3f 8005618: TEST_BUG: java/lang/ProcessBuilder/Basic.java failing intermittently Reviewed-by: alanb, martin, dholmes ! test/java/lang/ProcessBuilder/Basic.java

Re: Code Review Request: 7171415: java.net.URI.equals/hashCode not consistent for some URIs

2013-01-15 Thread Chris Hegarty
Looks good to me too. Thanks Kurchi. -Chris. On 01/15/2013 01:25 PM, Vitaly Davidovich wrote: Looks good. You can move ch, i, and index declarations into the for loop scope, but it's fine as-is. Thanks Sent from my phone On Jan 14, 2013 3:05 PM, "Kurchi Hazra" mailto:kurchi.subhra.ha...@ora

Re: Code Review Request: 7171415: java.net.URI.equals/hashCode not consistent for some URIs

2013-01-15 Thread Vitaly Davidovich
Looks good. You can move ch, i, and index declarations into the for loop scope, but it's fine as-is. Thanks Sent from my phone On Jan 14, 2013 3:05 PM, "Kurchi Hazra" wrote: > Thank you all for your comments. Here is an updated webrev where > URI.hashCode() calculates the hashCode itself > in

hg: jdk8/tl/jdk: 8005406: HTTP server implementation should use Base64 API

2013-01-15 Thread chris . hegarty
Changeset: 4b012af44f24 Author:chegar Date: 2013-01-15 11:44 + URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/4b012af44f24 8005406: HTTP server implementation should use Base64 API Reviewed-by: khazra, alanb, chegar Contributed-by: Mark Sheppard ! src/share/classes/com/sun/ne

Re: RFR: (JDK-8005406) HTTP server implementation should use Base64 API

2013-01-15 Thread Chris Hegarty
On 01/15/2013 08:29 AM, Alan Bateman wrote: On 14/01/2013 22:24, Mark Sheppard wrote: Hi, Request for review of JDK-8005406, this time! This is the second in a series of refactorings which migrate base64 support in various packages to utilize the base64 support from java.util.Base64. This is

Re: RFR: (JDK-8005406) HTTP server implementation should use Base64 API

2013-01-15 Thread Alan Bateman
On 14/01/2013 22:24, Mark Sheppard wrote: Hi, Request for review of JDK-8005406, this time! This is the second in a series of refactorings which migrate base64 support in various packages to utilize the base64 support from java.util.Base64. This is the modification of com.sun.net.httpserver.B