Real sense of deja-vu here. Didn't we go through this same thing with
the HPI socket routines?
Depending on the OS (and version?) we should be using socklen_t not int
and not uint32_t.
David
On 20/12/2012 2:35 AM, Chris Hegarty wrote:
John,
I grabbed your patch, and with it I now see diffe
John,
On 2012-12-19 23:33, John Zavgren wrote:
> Dmitry:
> Are you suggesting that in the definition of, for example, dbgsysConnect(),
> we convert the namelen argument to be a socklen_t?
The best approach IMHO, is
dbgsysConnect(int fd, struct sockaddr *name, socklen_t namelen)
and change
sha
Changeset: 1f9c19741285
Author:darcy
Date: 2012-12-19 11:53 -0800
URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/1f9c19741285
8005097: Tie isSynthetic javadoc to the JLS
Reviewed-by: mduigou
! src/share/classes/java/lang/Class.java
! src/share/classes/java/lang/reflect/Constructor
Dmitry:
Are you suggesting that in the definition of, for example, dbgsysConnect(), we
convert the namelen argument to be a socklen_t?
int
dbgsysConnect(int fd, struct sockaddr *name, uint32_t namelen) {
int rv = connect(fd, name, (socklen_t)nameLength);<--- NEW
if (rv < 0 && (errno ==
John,
On 2012-12-19 22:25, John Zavgren wrote:
> Yes... I did consider that, but I didn't see any POSIX data types near the
> code I was changing, so I decided to use a "brute force" data type instead.
connect, recvfrom etc almost always uses socklen_t, but socklen_t could
expands either to int
Yes... I did consider that, but I didn't see any POSIX data types near the code
I was changing, so I decided to use a "brute force" data type instead.
Shall I make that change?
John
- Original Message -
From: dmitry.samers...@oracle.com
To: john.zavg...@oracle.com
Cc: net-dev@openjdk.jav
John,
Did you consider using socklen_t instead of uint32_t and unsigned int
(for namelen etc) ?
-Dmitry
On 2012-12-19 19:36, John Zavgren wrote:
> Greetings:
> Please consider the following change to the two files:
> src/share/transport/socket/sysSocket.h
> src/solaris/transport/socket/socket_m
Changeset: f72c9c5aeaef
Author:jfranck
Date: 2012-12-16 11:09 +0100
URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/f72c9c5aeaef
8005098: Provide isSynthesized() information on Attribute.Compound
Reviewed-by: jjg
! make/build.properties
! src/share/classes/com/sun/tools/javac
John,
I grabbed your patch, and with it I now see different warnings.
../../../../src/share/transport/socket/socketTransport.c: In function
'socketTransport_startListening':
../../../../src/share/transport/socket/socketTransport.c:310:40:
warning: pointer targets in passing argument 3 of 'dbgs
John - this is the debugger socket transport so cc'ing the
serviceability-dev list as that is where this code is maintained.
On 19/12/2012 15:36, John Zavgren wrote:
Greetings:
Please consider the following change to the two files:
src/share/transport/socket/sysSocket.h
src/solaris/transport/
Greetings:
Please consider the following change to the two files:
src/share/transport/socket/sysSocket.h
src/solaris/transport/socket/socket_md.c
that eliminate compiler warnings that stem from the fact that the variables
that the native code passes to various system calls were not declared
corre
Changeset: 67b01d295cd2
Author:jjg
Date: 2012-12-19 11:29 +
URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/67b01d295cd2
8004833: Integrate doclint support into javac
Reviewed-by: mcimadamore
! src/share/classes/com/sun/tools/javac/main/Main.java
! src/share/classes/com/s
12 matches
Mail list logo
