Re: Request for code review 6512101: Incorrect encoding in NetworkInterface.getDisplayName()

2012-11-28 Thread Frank Ding
Hi Dmitry and Chris, Thanks for your comments. With your comments incorporated, I've prepared v2 @ http://cr.openjdk.java.net/~dingxmin/6512101/webrev.02/. Could you please review it again? Best regards, Frank On 11/14/2012 12:12 AM, Chris Hegarty wrote: On 11/11/2012 07:03 PM, Dmitry S

Re: Code review: 7200720: crash in net.dll during NTLM authentication

2012-11-28 Thread Dmitry Samersoff
Michael, NTLMAuthentication.java: 1. Copyright year should be either fixed or not changed 2. I think it's better to remove bug id from comments and replace comment like // MMM 7200720 ?? to something better. NTLMAuthSequence.c 1. Copyright ... Otherwise looks good for me. -Dmitry

hg: jdk8/tl/jdk: 2 new changesets

2012-11-28 Thread mandy . chung
Changeset: 09bef1e118e3 Author:mchung Date: 2012-11-28 10:49 -0800 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/09bef1e118e3 8003851: MethodHandleNatives dependency on java.sql.DriverManager Reviewed-by: alanb, dholmes ! src/share/classes/java/lang/invoke/MethodHandleNatives.jav

hg: jdk8/tl/jdk: 2 new changesets

2012-11-28 Thread daniel . fuchs
Changeset: 3b6a2fe6d75c Author:dfuchs Date: 2012-11-28 15:14 +0100 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/3b6a2fe6d75c 8003476: Cleanup warnings in com.sun.jmx.snmp code Reviewed-by: alanb, smarks ! src/share/classes/com/sun/jmx/snmp/EnumRowStatus.java ! src/share/classes/

hg: jdk8/tl/langtools: 7144981: javac should ignore ignorable characters in input

2012-11-28 Thread jonathan . gibbons
Changeset: 1f41a5758cf7 Author:vromero Date: 2012-11-23 15:13 + URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/1f41a5758cf7 7144981: javac should ignore ignorable characters in input Reviewed-by: jjg, mcimadamore ! src/share/classes/com/sun/tools/javac/parser/JavaTokeniz

hg: jdk8/tl/jdk: 7154390: Add support for repeating annotations in j.l.r.AnnotatedElement

2012-11-28 Thread jonathan . gibbons
Changeset: 735b93462eed Author:jfranck Date: 2012-11-28 09:21 -0800 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/735b93462eed 7154390: Add support for repeating annotations in j.l.r.AnnotatedElement Reviewed-by: darcy ! src/share/classes/java/lang/Class.java ! src/share/classes/

Re: Code review: 7200720: crash in net.dll during NTLM authentication

2012-11-28 Thread Chris Hegarty
I'm ok with this change. -Chris. On 23/11/2012 15:59, Michael McMahon wrote: Could I get the following change reviewed please? There was a crash caused by accessing freed memory when authentication was repeated in the same HttpURLConnection instance/ http://cr.openjdk.java.net/~michaelm/720072

Re: Code review: 7200720: crash in net.dll during NTLM authentication

2012-11-28 Thread Alan Bateman
On 28/11/2012 13:47, Michael McMahon wrote: just checked the new build on Linux and it's fine. There are a couple of other fixes that will follow this one related to this problem. But, I'd like to go ahead and push this one first if possible - Michael Thanks for checking. I don't have cycles

Re: Code review: 7200720: crash in net.dll during NTLM authentication

2012-11-28 Thread Michael McMahon
On 23/11/12 16:16, Alan Bateman wrote: On 23/11/2012 15:59, Michael McMahon wrote: Could I get the following change reviewed please? There was a crash caused by accessing freed memory when authentication was repeated in the same HttpURLConnection instance/ http://cr.openjdk.java.net/~michaelm/7

hg: jdk8/tl/jdk: 8004019: Removes unused method HandshakeHash.setCertificateVerifyAlg()

2012-11-28 Thread xuelei . fan
Changeset: 46c627801490 Author:xuelei Date: 2012-11-28 05:18 -0800 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/46c627801490 8004019: Removes unused method HandshakeHash.setCertificateVerifyAlg() Summary: certification verification in HandshakeHash was abandoned during TLS 1.2 i