hg: jdk8/tl/jdk: 8004088: hg push for bug#4235519 failed to push all files

2012-11-27 Thread xueming . shen
Changeset: c6ed2c238d4f Author:sherman Date: 2012-11-27 22:07 -0800 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/c6ed2c238d4f 8004088: hg push for bug#4235519 failed to push all files Summary: pushed all base64 files Reviewed-by: alanb, mduigou + src/share/classes/java/util/Base

hg: jdk8/tl/jdk: 8003597: TEST_BUG: Eliminate dependency on javaweb from closed net tests

2012-11-27 Thread rob . mckenna
Changeset: 40311b5f478f Author:robm Date: 2012-11-28 00:47 + URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/40311b5f478f 8003597: TEST_BUG: Eliminate dependency on javaweb from closed net tests Reviewed-by: chegar + test/java/net/ResponseCache/Test.java + test/java/net/Socket/

hg: jdk8/tl/langtools: 8004068: Fix build problems caused by on-demand imports

2012-11-27 Thread jonathan . gibbons
Changeset: 4d68e2a05b50 Author:jjg Date: 2012-11-27 13:55 -0800 URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/4d68e2a05b50 8004068: Fix build problems caused by on-demand imports Reviewed-by: jjg Contributed-by: eric.casp...@amd.com ! src/share/classes/com/sun/tools/javac/c

Re: RFR8003991 (take two)

2012-11-27 Thread John Zavgren
Dmitry, et al: There really is no bug here. I was reacting without much consideration, to a static code analysis tool that had generated a "false positive". I'll configure the tool to ignore this section of code and I'll close out the bug. I apologize for the inconvenience. John - Origina

Re: RFR 8003833: Spurious NPE from Socket.getIn/OutputStream

2012-11-27 Thread Dmitry Samersoff
Looks good for me. -Dmitry On 2012-11-27 15:44, Chris Hegarty wrote: > This is a longstanding bug in the Socket code that was only noticed > recently as a result of some test changes that Daniel pushed in the nio > area. > > There is a very small window in > AbstractPlainSocketImpl.getIn/OutputSt

Re: RFR 8003833: Spurious NPE from Socket.getIn/OutputStream

2012-11-27 Thread Alan Bateman
On 27/11/2012 11:44, Chris Hegarty wrote: This is a longstanding bug in the Socket code that was only noticed recently as a result of some test changes that Daniel pushed in the nio area. There is a very small window in AbstractPlainSocketImpl.getIn/OutputStream where isClosedOrPending() gra

RFR 8003833: Spurious NPE from Socket.getIn/OutputStream

2012-11-27 Thread Chris Hegarty
This is a longstanding bug in the Socket code that was only noticed recently as a result of some test changes that Daniel pushed in the nio area. There is a very small window in AbstractPlainSocketImpl.getIn/OutputStream where isClosedOrPending() grabs the fdLock to check if the socket is clo

Re: request for review: 8003597: TEST_BUG: Eliminate dependency on javaweb from closed net tests

2012-11-27 Thread Chris Hegarty
Changes look fine to me Rob. Thanks for updating these. -Chris. On 11/26/2012 08:23 PM, Rob McKenna wrote: Hi folks, Looking to move a pair of tests into the open repo: http://cr.openjdk.java.net/~robm/8003597/webrev.01/ Thanks, -Rob

Re: RFR8003991 (take two)

2012-11-27 Thread Chris Hegarty
On 11/27/2012 09:42 AM, Alan Bateman wrote: On 26/11/2012 23:19, John Zavgren wrote: Greetings: I'm posting the webrev image of a change that I made that eliminates a potential file descriptor leak. (The previous RFR referenced a webrev image with the right file name but the wrong content. 'sor

Re: RFR8003991 (take two)

2012-11-27 Thread Alan Bateman
On 26/11/2012 23:19, John Zavgren wrote: Greetings: I'm posting the webrev image of a change that I made that eliminates a potential file descriptor leak. (The previous RFR referenced a webrev image with the right file name but the wrong content. 'sorry about that.) http://cr.openjdk.java.net