Re: RFR8003991 (take two)

2012-11-26 Thread Dmitry Samersoff
John, I guess free(loRoutes) should be here. -Dmitry On 2012-11-27 03:19, John Zavgren wrote: > Greetings: > > I'm posting the webrev image of a change that I made that eliminates a > potential file descriptor leak. (The previous RFR referenced a webrev image > with the right file name but t

Re: RFR8003991 (take two)

2012-11-26 Thread Kurchi Hazra
Aren't we effectively calling fclose(NULL) here now? - Kurchi On 26.11.2012 15:19, John Zavgren wrote: Greetings: I'm posting the webrev image of a change that I made that eliminates a potential file descriptor leak. (The previous RFR referenced a webrev image with the right file name but th

RFR8003991 (take two)

2012-11-26 Thread John Zavgren
Greetings: I'm posting the webrev image of a change that I made that eliminates a potential file descriptor leak. (The previous RFR referenced a webrev image with the right file name but the wrong content. 'sorry about that.) http://cr.openjdk.java.net/~mullan/webrevs/8003991/webrev.00/ Thanks

hg: jdk8/tl/jdk: 8001634: Initial set of functional interface types

2012-11-26 Thread mike . duigou
Changeset: c2e80176a697 Author:mduigou Date: 2012-11-26 15:08 -0800 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/c2e80176a697 8001634: Initial set of functional interface types Summary: Add the core functional interfaces used by the JSR335 libraries. Reviewed-by: dholmes, briango

request for review: 8003597: TEST_BUG: Eliminate dependency on javaweb from closed net tests

2012-11-26 Thread Rob McKenna
Hi folks, Looking to move a pair of tests into the open repo: http://cr.openjdk.java.net/~robm/8003597/webrev.01/ Thanks, -Rob

Re: RFR JDK-80003991

2012-11-26 Thread John Zavgren
Please accept my apology... I posted the wrong file for review (right name, wrong content) When the new one is available on cr.openjdk.java.net I'll send out a new email. John - Original Message - From: john.zavg...@oracle.com To: net-dev@openjdk.java.net Sent: Monday, November 26, 2012

Re: RFR JDK-80003991

2012-11-26 Thread Alan Bateman
On 26/11/2012 19:40, John Zavgren wrote: Greetings: The procedure initLoopbackRoutes() has a file descriptor leak. http://cr.openjdk.java.net/~mullan/webrevs/8003991/ Thanks! John Zavgren John - this is a change to the launcher, any chance you have the bugs or webrev mixed up? -Alan.

RFR JDK-80003991

2012-11-26 Thread John Zavgren
Greetings: The procedure initLoopbackRoutes() has a file descriptor leak. http://cr.openjdk.java.net/~mullan/webrevs/8003991/ Thanks! John Zavgren