hg: jdk8/tl/jdk: 6931128: (spec) File attribute tests fail when run as root.

2012-08-15 Thread rob . mckenna
Changeset: da14e2c90bcb Author:robm Date: 2012-08-15 22:46 +0100 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/da14e2c90bcb 6931128: (spec) File attribute tests fail when run as root. Reviewed-by: alanb ! src/share/classes/java/io/File.java ! test/java/io/File/Basic.java ! test/j

Re: Http client API

2012-08-15 Thread Michael McMahon
On 15/08/12 16:59, Mike Duigou wrote: On Aug 15 2012, at 09:06 , Michael McMahon wrote: HttpClientProvider:: - HttpClientProvider JavaDoc uses inconsistent capitalization of HTTP. - createAsynchronousHttpClient() Since there's only one create method why bother to mention that it's "Asynchron

Re: Http client API

2012-08-15 Thread Alan Bateman
On 15/08/2012 16:59, Mike Duigou wrote: On Aug 15 2012, at 09:06 , Michael McMahon wrote: : Yes, the provider needs work. I agree with the above. Though I don't know about the necessity to provide multiple alternate providers. If there is only ever going to be one provider then why include a

Re: Http client API

2012-08-15 Thread Mike Duigou
On Aug 15 2012, at 09:06 , Michael McMahon wrote: >> HttpClientProvider:: >> >> - HttpClientProvider JavaDoc uses inconsistent capitalization of HTTP. >> >> - createAsynchronousHttpClient() Since there's only one create method why >> bother to mention that it's "Asynchronous"? >> >> - It's no

Re: Http client API

2012-08-15 Thread Michael McMahon
On 09/08/12 01:49, David M. Lloyd wrote: On 08/07/2012 06:09 PM, Michael McMahon wrote: Hi, A new revision of the Http client API planned for jdk 8 can be viewed at the following link http://cr.openjdk.java.net/~michaelm/httpclient/v0.3/ We would like to review the api on this mailing list. S

Re: Http client API

2012-08-15 Thread Kurchi Subhra Hazra
Just as a reminder, for reading the response, we had originally decided to simply terminate whatever bytebuffer/byte arrays we have with a -1 to indicate EOF. But if returning the number of bytes read results in cleaner code, maybe we should do this. HttpResponse:: - getBodyAsBytes(byte[],

Re: Http client API

2012-08-15 Thread Kurchi Subhra Hazra
- HttpClient createClient() -- is this the same as HttpClientProvider.provider().createAsynchronousHttpClient()? yes, and that needs to be documented. Just on this one, the method name createAsynchronousHttpClient() looks like a remnant of our previous API iterations, and I think this should

Re: Use Builder pattern ( was: Re: Http client API)

2012-08-15 Thread Michael McMahon
On 09/08/12 10:50, Chris Hegarty wrote: On 09/08/12 00:00, Jed Wesley-Smith wrote: Michael McMahon writes: A new revision of the Http client API planned for jdk 8 can be viewed at the following link http://cr.openjdk.java.net/~michaelm/httpclient/v0.3/ We would like to review the api on thi

Re: Http client API

2012-08-15 Thread Michael McMahon
Mike. Thanks for the comments. I have commented on most of your points. There are a few I'm not sure about, and maybe others will chime in. - Michael. On 08/08/2012 23:33, Mike Duigou wrote: General:: - It's probably already been mentioned but having the classes in the httpclient package and

hg: jdk8/tl/jdk: 7110151: Use underlying platform's zlib library for Java zlib support

2012-08-15 Thread ahughes
Changeset: 35e024c6a62c Author:andrew Date: 2012-08-15 14:35 +0100 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/35e024c6a62c 7110151: Use underlying platform's zlib library for Java zlib support Summary: Make SYSTEM_ZLIB more flexible by using ZLIB_{CFLAGS,LIBS} and building on