Re: Http client API

2012-08-09 Thread Chris Hegarty
Michael, Looking good, some comments. 1) Why the use of CookieManager, rather than CookieHandler? I would expect that CookieHandler would be a cleaner API 2) What is the impact on the sendHeader, setBody for HEAD requests? 3) I think HttpClient could be an interface and move the create me

hg: jdk8/tl/jdk: 7189363: Regex Pattern compilation buggy for special sequences

2012-08-09 Thread xueming . shen
Changeset: 717ed00b7787 Author:sherman Date: 2012-08-09 10:15 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/717ed00b7787 7189363: Regex Pattern compilation buggy for special sequences Summary: fixed the incorrect implementation in expr(...) Reviewed-by: psandoz, alanb ! src

Re: Problem with getFlags() method in NetworkInterface.c

2012-08-09 Thread Shirish Kuncolienkar
Chris, Please go ahead and run the sanity builds and tests. Thanks -Shirish On 8/9/2012 7:52 PM, Chris Hegarty wrote: On 09/08/12 14:16, Shirish Kuncolienkar wrote: I agree there is no general documentation available, AIX defines vipa interface flag as "0x8000" In which case I don

Re: Problem with getFlags() method in NetworkInterface.c

2012-08-09 Thread Chris Hegarty
On 09/08/12 14:16, Shirish Kuncolienkar wrote: I agree there is no general documentation available, AIX defines vipa interface flag as "0x8000" In which case I don't see any problems with your proposed source changes. One could argue that maybe they should go through the specific po

Re: Problem with getFlags() method in NetworkInterface.c

2012-08-09 Thread Shirish Kuncolienkar
On 8/9/2012 4:55 PM, Chris Hegarty wrote: Shirish, I am not familiar with VIPA interfaces, but I don't see any documentation that describes allowable values for flags that could cause the integer representing it to contain a negative value. I'm not opposed to the source changes, I just don't

Re: Problem with getFlags() method in NetworkInterface.c

2012-08-09 Thread Chris Hegarty
Shirish, I am not familiar with VIPA interfaces, but I don't see any documentation that describes allowable values for flags that could cause the integer representing it to contain a negative value. I'm not opposed to the source changes, I just don't see that they are required. Can you pleas

Problem with getFlags() method in NetworkInterface.c

2012-08-09 Thread Shirish Kuncolienkar
Hi, The return value from the getFlags() method in NetworkInterface.c is interpreted in 2 ways. - If the value is negative an Exception is thrown - Else the return value is considered as the flag mask obtained via the ioctl call. In rare cases is it possible the value in the ifr_flags could

Re: Http client API

2012-08-09 Thread Chris Hegarty
Wow, Mike. Great feedback. I just scanned your comments, and agree/understand most of them. I'll help Michael to feed them back into the API. Though, there'll probably be a few follow up mails to answers your direct questions and seek further clarification before the new rev of the API. Than

Re: Http client API

2012-08-09 Thread Chris Hegarty
On 09/08/12 06:10, Sean Chou wrote: Hi Chris, That's exactly my concern. I agree this provides best flexibility and content convenient methods are not proper in this API. So, is there going to have content specific convenient APIs like java.nio.file.Files ? Although it is a wrapper, it may

Use Builder pattern ( was: Re: Http client API)

2012-08-09 Thread Chris Hegarty
On 09/08/12 00:00, Jed Wesley-Smith wrote: Michael McMahon writes: A new revision of the Http client API planned for jdk 8 can be viewed at the following link http://cr.openjdk.java.net/~michaelm/httpclient/v0.3/ We would like to review the api on this mailing list. So, all comments are welc

Re: Http client API

2012-08-09 Thread Alan Bateman
On 09/08/2012 01:49, David M. Lloyd wrote: On 08/07/2012 06:09 PM, Michael McMahon wrote: Hi, A new revision of the Http client API planned for jdk 8 can be viewed at the following link http://cr.openjdk.java.net/~michaelm/httpclient/v0.3/ We would like to review the api on this mailing list.

Parsing of URL's which contain Windows Path separator

2012-08-09 Thread Shirish Kuncolienkar
Hi, I have the following piece of code URL url = new URL("file", "/", "C:\\temp\\Java6"); System.out.println(url); URL url1 = new URL(url, "hello.html"); System.out.println(url1); first System out prints as "file:///C:\temp\Java6\Lotus" Second one prints the valu