Re: Code Review Request: 7154502: IAE: Illegal character(s) in message header field from HttpURLConnection.checkMessageHeader

2012-06-21 Thread Chris Hegarty
This change looks fine to me. -Chris On 21 Jun 2012, at 18:53, Kurchi Subhra Hazra wrote: > Hi, > > Currently HttpURLConnection.setRequestProperty() does not > document that it can throw an IllegalArgumentException. However, this method > does > throw an IAE if the key or value contains il

hg: jdk8/tl/langtools: 7178297: provide mapping from doc comment position to source file position

2012-06-21 Thread jonathan . gibbons
Changeset: 067f51db3402 Author:jjg Date: 2012-06-21 13:22 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/067f51db3402 7178297: provide mapping from doc comment position to source file position Reviewed-by: mcimadamore, ksrini ! src/share/classes/com/sun/tools/javac/par

Code Review Request: 7154502: IAE: Illegal character(s) in message header field from HttpURLConnection.checkMessageHeader

2012-06-21 Thread Kurchi Subhra Hazra
Hi, Currently HttpURLConnection.setRequestProperty() does not document that it can throw an IllegalArgumentException. However, this method does throw an IAE if the key or value contains illegal characters. The same applies for HttpURLConnection.addRequestProperty(), and this webrev tries to a

Re: A little modification to error message

2012-06-21 Thread Chris Hegarty
Sean, The updated error messages look fine to me. Are these all the possibly native OOM throw sites in the networking area, or just some you came across? -Chris. On 21/06/2012 06:41, Sean Chou wrote: Hi all, We did some modification in these error messages because of some user feedbac