Looks ok to me.
-Chris.
On 30/01/2012 09:48, Michael McMahon wrote:
Can I get the following webrev reviewed please?
http://cr.openjdk.java.net/~michaelm/7139770/webrev.1/
There are two issues. In DatagramSocket the change uses the peekData()
api when available, instead of peek(), which in fac
Changeset: f9fb8c4b4550
Author:dl
Date: 2012-01-30 11:44 +
URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/f9fb8c4b4550
7132378: Race in FutureTask if used with explicit set ( not Runnable )
Reviewed-by: chegar, dholmes
! src/share/classes/java/util/concurrent/FutureTask.java
+
Looks good, Thanks Michael.
-Chris.
On 30/01/2012 11:52, Michael McMahon wrote:
Chris,
Yes, that is more readable. I've updated the webrev here:
http://cr.openjdk.java.net/~michaelm/7122794/webrev.4/
Thanks
Michael.
On 30/01/12 10:27, Chris Hegarty wrote:
Michael,
Is it possible to initial
Chris,
Yes, that is more readable. I've updated the webrev here:
http://cr.openjdk.java.net/~michaelm/7122794/webrev.4/
Thanks
Michael.
On 30/01/12 10:27, Chris Hegarty wrote:
Michael,
Is it possible to initialize connectDisabled at the Java level using
the os.name system property, rather t
On 30/01/2012 10:00, Michael McMahon wrote:
Can I get the following webrev reviewed please?
http://cr.openjdk.java.net/~michaelm/7132699/webrev.1/
On Mac, we read the system proxy settings and
by default the system sets a proxy bypass list. Unfortunately, this
default list doesn't contain some
Michael,
Is it possible to initialize connectDisabled at the Java level using the
os.name system property, rather than in native. We do this in other
places in the impls ( albeit not for Mac yet ).
-Chris.
On 30/01/2012 09:49, Alan Bateman wrote:
.
I have updated this webrev because th
Can I get the following webrev reviewed please?
http://cr.openjdk.java.net/~michaelm/7132699/webrev.1/
On Mac, we read the system proxy settings and
by default the system sets a proxy bypass list. Unfortunately, this
default list doesn't contain some entries (like localhost) which we depend
on t
Can I get the following webrev reviewed please?
http://cr.openjdk.java.net/~michaelm/7139770/webrev.1/
There are two issues. In DatagramSocket the change uses the peekData()
api when available, instead of peek(), which in fact doesn't work at all
with our own PlainDatagramSocketImpl (it tries t
