Re: Question about getaddrinfo in Inet4AddressImpl.c

On 11/14/2011 10:15 PM, Chris Hegarty wrote: I agree with Mikes comments, and here are a few of trivial ones of my own. - 'struct sockaddr_in6 him6' here is unused in getHostByAddr - caddr[16] - > caddr[4] in getHostByAddr Thanks for making this change. It really cleans up this old code. It

Re: Question about getaddrinfo in Inet4AddressImpl.c

On 11/14/2011 10:15 PM, Chris Hegarty wrote: I agree with Mikes comments, and here are a few of trivial ones of my own. - 'struct sockaddr_in6 him6' here is unused in getHostByAddr - caddr[16] - > caddr[4] in getHostByAddr Thanks for making this change. It really cleans up this old code. It

hg: jdk8/tl/langtools: 7106166: (javac) re-factor EndPos parser

Changeset: 7375d4979bd3 Author:ksrini Date: 2011-11-14 15:11 -0800 URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/7375d4979bd3 7106166: (javac) re-factor EndPos parser Reviewed-by: jjg ! src/share/classes/com/sun/tools/javac/api/JavacTrees.java ! src/share/classes/com/sun/to

hg: jdk8/tl/langtools: 7110974: (javac) add coding conventions and style checkers for langtools

Changeset: c1238fcc9515 Author:ksrini Date: 2011-11-14 08:09 -0800 URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/c1238fcc9515 7110974: (javac) add coding conventions and style checkers for langtools Reviewed-by: jjg ! make/build.properties ! make/build.xml + make/conf/check

Re: Question about getaddrinfo in Inet4AddressImpl.c

I agree with Mikes comments, and here are a few of trivial ones of my own. - 'struct sockaddr_in6 him6' here is unused in getHostByAddr - caddr[16] - > caddr[4] in getHostByAddr Thanks for making this change. It really cleans up this old code. It is not your fault as the same is in Inet6Addre

hg: jdk8/tl/jdk: 7107020: java.net.PlainSocketImpl.socketSetOption() calls itself

Changeset: 68fc55d12ae6 Author:chegar Date: 2011-11-14 10:06 + URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/68fc55d12ae6 7107020: java.net.PlainSocketImpl.socketSetOption() calls itself Reviewed-by: alanb, chegar Contributed-by: kurchi.subhra.ha...@oracle.com ! src/windows/c

Re: Code Review Request: 7107020: java.net.PlainSocketImpl.socketSetOption() calls itself

On 11/11/2011 18:57, Kurchi Hazra wrote: Hi, As specified in the CR description, this is a bug in src/windows/java/net/PlainSocketImpl.java and impl.socketSetOption() should be called instead of socketSetOption(). This bug did not create a problem yet since setOption() is usually called for set

hg: jdk8/tl/jdk: 7111548: unexpected debug log message

Changeset: 5c7c83a6ee24 Author:xuelei Date: 2011-11-14 01:21 -0800 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/5c7c83a6ee24 7111548: unexpected debug log message Reviewed-by: wetmore ! src/share/classes/sun/security/ssl/SSLSocketImpl.java