Re: Code Review 7098719: -Dsun.net.maxDatagramSockets and Socket constructor does not work correctly with System.gc()

2011-10-07 Thread Chris Hegarty
On 10/ 7/11 05:58 PM, Michael McMahon wrote: Looks fine. Possibly the comment line at 102:AbstractPlainSocketImpl.java is not really needed/appropriate though. True. I'll remove it. Thanks, -Chris. - Michael. On 07/10/11 06:40, Chris Hegarty wrote: Michael, Alan, This is a follow up to C

Re: Code Review 7098719: -Dsun.net.maxDatagramSockets and Socket constructor does not work correctly with System.gc()

2011-10-07 Thread Michael McMahon
Looks fine. Possibly the comment line at 102:AbstractPlainSocketImpl.java is not really needed/appropriate though. - Michael. On 07/10/11 06:40, Chris Hegarty wrote: Michael, Alan, This is a follow up to CR 7073491 where the same issue was addressed in DatagramSocket. This CR proposes to ad

Code Review 7098719: -Dsun.net.maxDatagramSockets and Socket constructor does not work correctly with System.gc()

2011-10-07 Thread Chris Hegarty
Michael, Alan, This is a follow up to CR 7073491 where the same issue was addressed in DatagramSocket. This CR proposes to address the same problem exposed through deprecated java.net.Socket(InetAddress host, int port, boolean stream). The problem is in AbstractPlainSocketImpl.create(). If

hg: jdk8/tl/jdk: 7094377: Com.sun.jndi.ldap.read.timeout doesn't work with ldaps.

2011-10-07 Thread vincent . x . ryan
Changeset: 2edaef22de23 Author:vinnie Date: 2011-10-07 14:09 +0100 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/2edaef22de23 7094377: Com.sun.jndi.ldap.read.timeout doesn't work with ldaps. Reviewed-by: chegar ! src/share/classes/com/sun/jndi/ldap/Connection.java + test/com/sun/