hg: jdk8/tl/jdk: 7090843: (tz) Support tzdata2011j

2011-09-14 Thread yuka . kamiya
Changeset: 5e403e9fa34a Author:peytoia Date: 2011-09-15 15:02 +0900 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/5e403e9fa34a 7090843: (tz) Support tzdata2011j Reviewed-by: okutsu ! make/sun/javazic/tzdata/VERSION ! make/sun/javazic/tzdata/africa ! make/sun/javazic/tzdata/antarc

hg: jdk8/tl/jdk: 7090844: Support a timezone whose offset is changed more than once in the future

2011-09-14 Thread yuka . kamiya
Changeset: f114bddac6d6 Author:peytoia Date: 2011-09-15 14:45 +0900 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/f114bddac6d6 7090844: Support a timezone whose offset is changed more than once in the future Reviewed-by: okutsu ! make/tools/src/build/tools/javazic/Mappings.java

Re: Code Review Request: 7090158 Networking Libraries don't build with javac -Werror

2011-09-14 Thread Weijun Wang
234 l = new ArrayList<>(); Do we have a consensus on whether diamond can be used here? i.e. assignment not on declaration. Waiting for someone's input on this. In retrospect, I feel this is not exactly how the diamond operator is meant to be used when I refer to http://download.oracle.com/java

hg: jdk8/tl/langtools: 7068437: Regression: Filer.getResource(SOURCE_OUTPUT, ...) no longer works in JDK 7 w/o -s

2011-09-14 Thread jonathan . gibbons
Changeset: 826ae6a2f27d Author:jjg Date: 2011-09-14 18:26 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/826ae6a2f27d 7068437: Regression: Filer.getResource(SOURCE_OUTPUT, ...) no longer works in JDK 7 w/o -s Reviewed-by: darcy ! src/share/classes/com/sun/tools/javac/

hg: jdk8/tl/langtools: 7090700: fix for 7080267 breaks two tests

2011-09-14 Thread jonathan . gibbons
Changeset: a6e2c1840ea1 Author:jjg Date: 2011-09-14 15:49 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/a6e2c1840ea1 7090700: fix for 7080267 breaks two tests Reviewed-by: ksrini ! src/share/classes/com/sun/tools/javac/tree/JCTree.java

hg: jdk8/tl/jdk: 7088500: there is no @since tag on SafeVarargs

2011-09-14 Thread joe . darcy
Changeset: 84da01e00e6c Author:darcy Date: 2011-09-14 13:09 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/84da01e00e6c 7088500: there is no @since tag on SafeVarargs Reviewed-by: mduigou ! src/share/classes/java/lang/SafeVarargs.java

Re: Code Review Request: 7090158 Networking Libraries don't build with javac -Werror

2011-09-14 Thread chris hegarty
Kurchi, The problem here is that due to a bug in the compiler, CR 7090499, we are not seeing raw type warnings for anonymous inner classes. When Maurizio fixes this bug it is very likely that other areas of the jdk where Sasha enabled -Werror will break the build. If you like you can comple

hg: jdk8/tl/langtools: 7090249: IllegalStateException from Trees.getScope when called from JSR 199

2011-09-14 Thread jonathan . gibbons
Changeset: 1807fc3fd33c Author:jjg Date: 2011-09-14 12:14 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/1807fc3fd33c 7090249: IllegalStateException from Trees.getScope when called from JSR 199 Reviewed-by: mcimadamore ! src/share/classes/com/sun/tools/javac/api/JavacT

hg: jdk8/tl/langtools: 7080267: Call to toString() from an ExpressionStatementTree doesn't take in consideration the "; " at the end

2011-09-14 Thread jonathan . gibbons
Changeset: 0f3da6af9799 Author:jjg Date: 2011-09-14 12:07 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/0f3da6af9799 7080267: Call to toString() from an ExpressionStatementTree doesn't take in consideration the ";" at the end Reviewed-by: mcimadamore ! src/share/clas

hg: jdk8/tl/jdk: 6879143: java.math.BigInteger misses the xxxValueExact methods

2011-09-14 Thread joe . darcy
Changeset: 2a8072c7cf99 Author:darcy Date: 2011-09-14 11:32 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/2a8072c7cf99 6879143: java.math.BigInteger misses the xxxValueExact methods Reviewed-by: alanb ! src/share/classes/java/math/BigInteger.java + test/java/math/BigInteger

Re: Code Review Request: 7090158 Networking Libraries don't build with javac -Werror

2011-09-14 Thread Kurchi Hazra
3. java/net/DatagramSocket.java and java/net/MulticastSocket.java have some real code changes around bind(). Maybe they should go to another fix? I think there is some merging problem in my workspace. I will probably start with an updated copy of these files and insert my changes in them. S

Re: Code Review Request: 7090158 Networking Libraries don't build with javac -Werror

2011-09-14 Thread Tom Hawtin
On 14/09/2011 16:46, Kurchi Hazra wrote: + Class[] cl = new Class[2]; + cl[0] = SocketAddress.class; + cl[1] = Integer.TYPE; + Class clazz = impl.getClass(); I have to say, I think that would read better as: Class[] cl = { SocketAddress.class, int.class }; Class clazz = impl

Re: Code Review Request: 7090158 Networking Libraries don't build with javac -Werror

2011-09-14 Thread Kurchi Hazra
I remember having made this change as follows: -bash-3.00$ hg diff src/share/classes/java/net/Socket.java diff --git a/src/share/classes/java/net/Socket.java b/src/share/classes/java/net/Socket.java --- a/src/share/classes/java/net/Socket.java +++ b/src/share/classes/java/net/Socket.java @@ -459

hg: jdk8/tl/jdk: 6915797: Remove sun.tools.jar.JarImageSource that is not used; ...

2011-09-14 Thread mandy . chung
Changeset: 04672e957da0 Author:mchung Date: 2011-09-14 08:33 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/04672e957da0 6915797: Remove sun.tools.jar.JarImageSource that is not used 7090178: Move java.util.XMLUtils to another package to avoid split package Reviewed-by: alanb

Re: Code Review Request: 7090158 Networking Libraries don't build with javac -Werror

2011-09-14 Thread Chris Hegarty
Maurizio and I noticed another issue in java.net.Socket > Class[] cl = new Class[2]; should generate a warning, but does not. Maurizio filed CR 7090499 against this. It is a compiler bug. It should be: Class[] cl = new Class[2]; It is best that we fix this before pushing as it will break the

Re: Code Review Request: 7090158 Networking Libraries don't build with javac -Werror

2011-09-14 Thread Sean Mullan
On 9/13/11 10:55 PM, Weijun Wang wrote: > I apply the patch to my local repository and do a clean rebuild of > jdk-only. It shows 1 error and 92 warnings in javax and stopped. Most in > src/share/classes/javax/xml/crypto/dsig and I remember Sean said it's > not easy to remove all warnings there

Re: Code Review Request: 7090158 Networking Libraries don't build with javac -Werror

2011-09-14 Thread Chris Hegarty
Thanks for reviewing this Max, I also went through the changes. MessageHeader.filterAndAddHeaders() and HttpURLConnection.getRequestproperties() also confused me. Essentially this never work quite right. I had Maurizio ( javac guy ) look at the old code with me and we figured out that the gene

Re: Code Review Request: 7090158 Networking Libraries don't build with javac -Werror

2011-09-14 Thread Alan Bateman
Weijun Wang wrote: : 3. java/net/DatagramSocket.java and java/net/MulticastSocket.java have some real code changes around bind(). Maybe they should go to another fix? I suspect there may be a merge issue here as it looks like it is undoing recent changes that Michael pushed. -Alan.