Re: Code Review Request: 7090158 Networking Libraries don't build with javac -Werror

2011-09-13 Thread Weijun Wang
On 09/14/2011 12:14 PM, Kurchi Hazra wrote: Updated webrev : http://cr.openjdk.java.net/~weijun/7090158/webrev.00/. This should build correctly. Yes, it does! Some comments: 1. make/java/Makefile has no real change 2. make/javax/others/Makefile has only a new commented line 3. java/net/Da

Re: Code Review Request: 7090158 Networking Libraries don't build with javac -Werror

2011-09-13 Thread Kurchi Hazra
Updated webrev : http://cr.openjdk.java.net/~weijun/7090158/webrev.00/. This should build correctly. Thanks, Kurchi On 9/13/2011 7:55 PM, Weijun Wang wrote: I apply the patch to my local repository and do a clean rebuild of jdk-only. It shows 1 error and 92 warnings in javax and stopped. Most

Re: Code Review Request: 7090158 Networking Libraries don't build with javac -Werror

2011-09-13 Thread Weijun Wang
I apply the patch to my local repository and do a clean rebuild of jdk-only. It shows 1 error and 92 warnings in javax and stopped. Most in src/share/classes/javax/xml/crypto/dsig and I remember Sean said it's not easy to remove all warnings there because the codes are shared between JDK and so

hg: jdk8/tl/langtools: 7090297: Remove com.sun.tools.javac.Launcher from tools.jar

2011-09-13 Thread mandy . chung
Changeset: ca2e2b85f437 Author:mchung Date: 2011-09-13 16:37 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/ca2e2b85f437 7090297: Remove com.sun.tools.javac.Launcher from tools.jar Reviewed-by: jjg - src/share/classes/com/sun/tools/javac/Launcher.java

Re: Code Review Request: 7090158 Networking Libraries don't build with javac -Werror

2011-09-13 Thread Alan Bateman
Kurchi Hazra wrote: Something went wrong in the pasting. Can you check if this works fine: http://cr.openjdk.java.net/~chegar/7090158/webrev/ Yes, this webrev has what I expected to see. -Alan

Re: Code Review Request: 7090158 Networking Libraries don't build with javac -Werror

2011-09-13 Thread Kurchi Hazra
Something went wrong in the pasting. Can you check if this works fine: http://cr.openjdk.java.net/~chegar/7090158/webrev/ On 9/13/2011 12:07 PM, Alan Bateman wrote: Kurchi Hazra wrote: Hi, This is an attempt to remove all build warnings that are related to networking in jdk. This work conta

Re: Code Review Request: 7090158 Networking Libraries don't build with javac -Werror

2011-09-13 Thread Alan Bateman
Kurchi Hazra wrote: Hi, This is an attempt to remove all build warnings that are related to networking in jdk. This work contains (a) Small changes in java files to remove already existing warnings (b) Small changes in Makefiles to prevent re-introduction of such warnings. Webrev: http:/

Code Review Request: 7090158 Networking Libraries don't build with javac -Werror

2011-09-13 Thread Kurchi Hazra
Hi, This is an attempt to remove all build warnings that are related to networking in jdk. This work contains (a) Small changes in java files to remove already existing warnings (b) Small changes in Makefiles to prevent re-introduction of such warnings. Webrev: http://cr.openjdk.java.net/~c

hg: jdk8/tl: 7 new changesets

2011-09-13 Thread lana . steuck
Changeset: 3bec5415a227 Author:cl Date: 2011-08-18 18:55 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/rev/3bec5415a227 Added tag jdk8-b01 for changeset f42e3d9394b4 ! .hgtags Changeset: e01201e727da Author:neugens Date: 2011-07-26 21:54 +0200 URL: http://hg.openjdk

hg: jdk8/tl/langtools: 3 new changesets

2011-09-13 Thread maurizio . cimadamore
Changeset: ed338593b0b6 Author:mcimadamore Date: 2011-09-13 14:14 +0100 URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/ed338593b0b6 7086595: Error message bug: name of initializer is 'null' Summary: Implementation of MethodSymbol.location() should take into account static/in

hg: jdk8/tl/jdk: 7082769: FileInputStream/FileOutputStream/RandomAccessFile allow file descriptor be closed when still in use

2011-09-13 Thread sean . coffey
Changeset: e0c1282a0ead Author:coffeys Date: 2011-09-13 11:21 +0100 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/e0c1282a0ead 7082769: FileInputStream/FileOutputStream/RandomAccessFile allow file descriptor be closed when still in use Reviewed-by: alanb ! src/share/classes/java