hg: jdk8/tl/jdk: 7047200: keytool safe store

2011-09-08 Thread weijun . wang
Changeset: 0e6076fed003 Author:weijun Date: 2011-09-09 11:18 +0800 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/0e6076fed003 7047200: keytool safe store Reviewed-by: xuelei ! src/share/classes/sun/security/tools/KeyTool.java + test/sun/security/tools/keytool/trystore.sh

Re: Datagram socket leak

2011-09-08 Thread Alan Bateman
Michael McMahon wrote: Sigh. Hopefully this is the last webrev. http://cr.openjdk.java.net/~michaelm/7085981/webrev.4/ Socket.java changed from last one. If there's no objection I'll push this version. - Michael. DatagramSocket(SocketAddress) creates an unbound socket if the parameter is null

Re: Datagram socket leak

2011-09-08 Thread Chris Hegarty
I think you've covered all the bases here, at least that I can see. -Chris. On 09/ 8/11 05:14 PM, Michael McMahon wrote: Sigh. Hopefully this is the last webrev. http://cr.openjdk.java.net/~michaelm/7085981/webrev.4/ Socket.java changed from last one. If there's no objection I'll push this ve

Re: Datagram socket leak

2011-09-08 Thread Michael McMahon
Sigh. Hopefully this is the last webrev. http://cr.openjdk.java.net/~michaelm/7085981/webrev.4/ Socket.java changed from last one. If there's no objection I'll push this version. - Michael. On 08/09/11 15:20, Salter, Thomas A wrote: Doesn't the socket get created by the createImpl before the

RE: Datagram socket leak

2011-09-08 Thread Salter, Thomas A
Doesn't the socket get created by the createImpl before the bind in the Socket constructor? Then bind or connect might throw an IllegalArgumentException. private Socket(SocketAddress address, SocketAddress localAddr, boolean stream) throws IOException { setImpl();

Re: Datagram socket leak

2011-09-08 Thread Chris Hegarty
On 09/ 8/11 12:12 PM, Michael McMahon wrote: . http://cr.openjdk.java.net/~michaelm/7085981/webrev.3/ The changes look good to me. -Chris. Thanks, Michael.

Re: Datagram socket leak

2011-09-08 Thread Michael McMahon
On 07/09/11 21:54, chris hegarty wrote: On 07/09/2011 17:24, Michael McMahon wrote: Hi all, I've posted a webrev for this at: http://cr.openjdk.java.net/~michaelm/7085981/webrev.1/ After checking Socket and ServerSocket, I believe they are not actually affected by this issue. The IllegalArgum

Re: Datagram socket leak

2011-09-08 Thread Michael McMahon
On 07/09/11 21:54, chris hegarty wrote: On 07/09/2011 17:24, Michael McMahon wrote: Hi all, I've posted a webrev for this at: http://cr.openjdk.java.net/~michaelm/7085981/webrev.1/ After checking Socket and ServerSocket, I believe they are not actually affected by this issue. The IllegalArgum