hg: jdk8/tl/jdk: 7072353: JNDI libraries do not build with javac -Xlint:all -Werror

2011-08-10 Thread jonathan . gibbons
Changeset: 18329abcdb7c Author:jjg Date: 2011-08-10 13:44 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/18329abcdb7c 7072353: JNDI libraries do not build with javac -Xlint:all -Werror Reviewed-by: xuelei Contributed-by: alexandre.boulga...@oracle.com ! make/com/sun/jndi/Mak

hg: jdk8/tl/jdk: 7077451: SerialLob, SerialClob have the wrong checks for setStream methods

2011-08-10 Thread lance . andersen
Changeset: 7676670d1e97 Author:lancea Date: 2011-08-10 16:23 -0400 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/7676670d1e97 7077451: SerialLob, SerialClob have the wrong checks for setStream methods Reviewed-by: alanb Contributed-by: Patrick Reinhart ! src/share/classes/javax/

hg: jdk8/tl/jdk: 7076523: TEST_BUG: test/java/net/NetworkInterface/NetParamsTest.java can fail with NPE

2011-08-10 Thread chris . hegarty
Changeset: af15e902cf08 Author:chegar Date: 2011-08-10 12:30 +0100 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/af15e902cf08 7076523: TEST_BUG: test/java/net/NetworkInterface/NetParamsTest.java can fail with NPE Reviewed-by: alanb ! test/java/net/NetworkInterface/NetParamsTest.

Re: Code Review 7076523: TEST_BUG: test/java/net/NetworkInterface/NetParamsTest.java can fail with NPE

2011-08-10 Thread Alan Bateman
Chris Hegarty wrote: Do'h, thanks. Updated patch below... hg diff NetParamsTest.java diff -r cf203f293b4e test/java/net/NetworkInterface/NetParamsTest.java --- a/test/java/net/NetworkInterface/NetParamsTest.java Tue Aug 09 16:59:44 2011 +0100 +++ b/test/java/net/NetworkInterface/NetParamsTest

Re: Code Review 7076523: TEST_BUG: test/java/net/NetworkInterface/NetParamsTest.java can fail with NPE

2011-08-10 Thread Chris Hegarty
On 8/10/2011 11:47 AM, Alan Bateman wrote: Chris Hegarty wrote: .. Should this be parentName as I assume parent.getName will NPE here. Do'h, thanks. Updated patch below... hg diff NetParamsTest.java diff -r cf203f293b4e test/java/net/NetworkInterface/NetParamsTest.java --- a/test/java/n

Re: Code Review 7076523: TEST_BUG: test/java/net/NetworkInterface/NetParamsTest.java can fail with NPE

2011-08-10 Thread Alan Bateman
Chris Hegarty wrote: An minor test issue seen when running on a virtual instance. Parent can legitimately be null, so the test should be robust enough to handle this. > : hg diff NetParamsTest.java diff -r cf203f293b4e test/java/net/NetworkInterface/NetParamsTest.java --- a/test/java/net/Netwo

Code Review 7076523: TEST_BUG: test/java/net/NetworkInterface/NetParamsTest.java can fail with NPE

2011-08-10 Thread Chris Hegarty
An minor test issue seen when running on a virtual instance. Parent can legitimately be null, so the test should be robust enough to handle this. > : hg diff NetParamsTest.java diff -r cf203f293b4e test/java/net/NetworkInterface/NetParamsTest.java --- a/test/java/net/NetworkInterface/NetParamsTe