Re: Code Review Request: 7035556 DatagramSocket.java:183: warning: unreachable catch clause

2011-07-21 Thread Alan Bateman
Kurchi Hazra wrote: Hi, Due to a recent update in javac to issue a warning on detecting unreachable code, the following warning started showing up in the jdk networking code: ../../../src/share/classes/java/net/DatagramSocket.java:183: warning: unreachable catch clause. This fix aims at rem

hg: jdk8/tl/jdk: 6330275: Rework the PaddingTest regression test.

2011-07-21 Thread weijun . wang
Changeset: c8dbb9e19355 Author:weijun Date: 2011-07-22 10:25 +0800 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/c8dbb9e19355 6330275: Rework the PaddingTest regression test. Reviewed-by: wetmore, smarks ! test/ProblemList.txt ! test/com/sun/crypto/provider/Cipher/DES/PaddingTest

Re: Code Review Request: 7035556 DatagramSocket.java:183: warning: unreachable catch clause

2011-07-21 Thread Brad Wetmore
Kurchi, Please have an additional reviewer for the networking portion of this, but in doing a quick look, I believe the point of the two catches is to make sure that any IOException that isn't already a SocketException (SocketException is a subclass of IOException) is rebranded to SocketExcep

Code Review Request: 7035556 DatagramSocket.java:183: warning: unreachable catch clause

2011-07-21 Thread Kurchi Hazra
Hi, Due to a recent update in javac to issue a warning on detecting unreachable code, the following warning started showing up in the jdk networking code: ../../../src/share/classes/java/net/DatagramSocket.java:183: warning: unreachable catch clause. This fix aims at removing this warning by

hg: jdk8/tl/jdk: 7068416: Lightweight HTTP Server should support TCP_NODELAY

2011-07-21 Thread chris . hegarty
Changeset: 70ec3aa8e99a Author:chegar Date: 2011-07-21 17:28 +0100 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/70ec3aa8e99a 7068416: Lightweight HTTP Server should support TCP_NODELAY Reviewed-by: alanb, michaelm ! src/share/classes/sun/net/httpserver/ServerConfig.java ! src/sh

Re: Socket InputStream.available may return a positive value after shutdown

2011-07-21 Thread Jing LV
Hi, Thank you Chris! Would you please send the link when you have some progress? 于 2011-7-18 18:00, Chris Hegarty 写道: On 07/18/11 09:09 AM, Jing LV wrote: Hi Chris, Alan, Thanks for reply. I am looking for a conclusion and solution for this issue. If I understand correctly, it'd fix the

Code review request: 7059542 JNDI name operations should be locale independent

2011-07-21 Thread Xuelei Fan
Hi, In JNDI implementation, String.toUpperCase() and String.toLowerCase() is used to compare or hashcode case-insensitive strings. These operations are locale dependent, and may result in unexpected behaviors in some locale.[1] This fix is try to interpret case-insensitive string locale independe