hg: jdk7/tl/langtools: 6938326: Use of "ant -diagnostics" a problem with ant 1.8.0, exit code 1 now

2010-03-26 Thread kelly . ohair
Changeset: de6375751eb7 Author:ohair Date: 2010-03-26 22:37 -0700 URL: http://hg.openjdk.java.net/jdk7/tl/langtools/rev/de6375751eb7 6938326: Use of "ant -diagnostics" a problem with ant 1.8.0, exit code 1 now Reviewed-by: jjg ! make/Makefile

Re: Code Review 6921111: NullPointerException in PlainDatagramSocketImpl.socketSetOption

2010-03-26 Thread Christopher Hegarty - Sun Microsystems Ireland
On 03/26/10 13:45, Alan Bateman wrote: Christopher Hegarty - Sun Microsystems Ireland wrote: Hi Michael, Alan, This is a very small change to fix a problem in native code where, if multiple threads are executing the native method, an unset value of a static variable may be used. When setting

Re: Code Review 6921111: NullPointerException in PlainDatagramSocketImpl.socketSetOption

2010-03-26 Thread Alan Bateman
Christopher Hegarty - Sun Microsystems Ireland wrote: Hi Michael, Alan, This is a very small change to fix a problem in native code where, if multiple threads are executing the native method, an unset value of a static variable may be used. When setting static variables in a block we can only

Code Review 6921111: NullPointerException in PlainDatagramSocketImpl.socketSetOption

2010-03-26 Thread Christopher Hegarty - Sun Microsystems Ireland
Hi Michael, Alan, This is a very small change to fix a problem in native code where, if multiple threads are executing the native method, an unset value of a static variable may be used. When setting static variables in a block we can only be sure they are all set when the last one is. This is