Re: Request Review: 6912868

2010-02-19 Thread Christopher Hegarty -Sun Microsystems Ireland
Alan Bateman wrote: [snip] > Looks okay to me. Sometime it might be good to re-write this in java and just have a couple of simple native method to call the gconf_ functions. Thanks Alan. I agree, this would be more elegant if rewritten in Java. I'll proceed with this change and file a

Re: Request Review: 6912868

2010-02-19 Thread Alan Bateman
Christopher Hegarty - Sun Microsystems Ireland wrote: Hi All, This patch corrects Java's usage of Gnome's proxy setting, in particular the previously ignored "use_same_proxy" setting as described on http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=6912868 and https://bugzilla.redhat.com/sh

Request Review: 6912868

2010-02-19 Thread Christopher Hegarty - Sun Microsystems Ireland
Hi All, This patch corrects Java's usage of Gnome's proxy setting, in particular the previously ignored "use_same_proxy" setting as described on http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=6912868 and https://bugzilla.redhat.com/show_bug.cgi?id=536704. I've added a manual test where th