hg: jdk7/tl/langtools: 6918625: handle annotations on array class literals

2010-02-02 Thread jonathan . gibbons
Changeset: b0a68258360a Author:jjg Date: 2010-02-02 10:56 -0800 URL: http://hg.openjdk.java.net/jdk7/tl/langtools/rev/b0a68258360a 6918625: handle annotations on array class literals Reviewed-by: jjg, darcy Contributed-by: m...@csail.mit.edu, mer...@cs.washington.edu ! src/share/cl

Request for Review 6922151

2010-02-02 Thread Christopher Hegarty -Sun Microsystems Ireland
Hi Alan, Michael, While investigating another issue I noticed that there is quite a bit of redundant static caching of methodIDs, fieldIDs, and global references to class objects. Most of these are for InetAddress, Inet4Address, Inet6Address and NetworkInterface. These classes already provid

Re: hg: jdk7/tl/jdk: 6921740: Eliminate warnings from sun.io converters and allow compiling with JAVAC_MAX_WARNINGS=true

2010-02-02 Thread Ulf Zibis
Hi, in most cases you use the empty diamond operator '<>' on instantiation, but not for SoftReference: "new SoftReference(cs)" in AbstractCharsetProvider.java Why? I don't see a big advantage for casting to (Class) against (Class) for the cache of Converters.java. Wouldn't you better use a s

hg: jdk7/tl/jdk: 6921740: Eliminate warnings from sun.io converters and allow compiling with JAVAC_MAX_WARNINGS=true

2010-02-02 Thread ahughes
Changeset: 7dadd2951a8b Author:andrew Date: 2010-02-02 10:55 + URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/7dadd2951a8b 6921740: Eliminate warnings from sun.io converters and allow compiling with JAVAC_MAX_WARNINGS=true Summary: Fix sun.io converters unchecked and cast warn