Re: Code review 6870935

2009-10-01 Thread Michael McMahon
Chris, Thanks. Agreed, except 5) is like that because a response body follows the response headers - Michael. Christopher Hegarty -Sun Microsystems Ireland wrote: The actual changes look fine. I have just a few comments/questions about the test: 1) copyright year should be updated to 2009 2)

Request for Review 6887364 [SetOutgoingIf]

2009-10-01 Thread Christopher Hegarty -Sun Microsystems Ireland
Hi Pavel, Michael, 6887364: SetOutgoingIf.java fails if run on multihomed machine without PIv6 on all interfaces [more details below] Webrev: http://cr.openjdk.java.net/~chegar/6887364/webrev/ I just realized why this test was failing on one of our lab machines. The reason is that the test

Re: Code review 6870935

2009-10-01 Thread Christopher Hegarty -Sun Microsystems Ireland
The actual changes look fine. I have just a few comments/questions about the test: 1) copyright year should be updated to 2009 2) I don't think s1 needs to be a field. I think it should be a local in run. 3) Indentation of run looks a little too far. 4) error should be volatile. 5) I would hav

Code review 6870935

2009-10-01 Thread Michael McMahon
Hello, Can I get the following code change reviewed please. http://cr.openjdk.java.net/~michaelm/6870935/webrev.01/ - Michael.

hg: jdk7/tl/jdk: 2 new changesets

2009-10-01 Thread michael . mcmahon
Changeset: dd724911c90a Author:michaelm Date: 2009-09-29 10:00 +0100 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/dd724911c90a 6886108: Test case B4933582 binding to fixed port number Reviewed-by: chegar ! test/java/net/Authenticator/B4933582.java ! test/sun/net/www/httptest/Htt