Re: Resurrect UrlEncodedQueryString (RFE 6306820)?

2009-03-26 Thread kennardconsulting
Max, Sure, I will make that change. Alan and Michael decided against Serializable, on balance. Regards, Richard. -- View this message in context: http://www.nabble.com/Resurrect-UrlEncodedQueryString-%28RFE-6306820%29--tp22735890p22736814.html Sent from the OpenJDK Networking Development ma

Re: Resurrect UrlEncodedQueryString (RFE 6306820)?

2009-03-26 Thread Weijun Wang
Hi Richard Sorry, I haven't noticed the words. However, it might be clearer if the first sentence in the doc says "Represents a www-form-urlencoded query string containing an ordered list of parameters". Something else: Is it worthwhile to make the class Serializable? Thanks Max kennardconsul

Re: Resurrect UrlEncodedQueryString (RFE 6306820)?

2009-03-26 Thread kennardconsulting
Max, Sure. The JavaDoc already spends a bit of time clarifying this. For example: "When modifying parameters, the ordering of existing parameters is maintained. Parameters are set and removed in-place, while appended parameters are added to the end of the query string." "The order the parameter

Re: Resurrect UrlEncodedQueryString (RFE 6306820)?

2009-03-26 Thread kennardconsulting
Max, Sure. The JavaDoc already spends a bit of time clarifying this. For example: "When modifying parameters, the ordering of existing parameters is maintained. Parameters are set and removed in-place, while appended parameters are added to the end of the query string." "The order the parameter

Re: Resurrect UrlEncodedQueryString (RFE 6306820)?

2009-03-26 Thread kennardconsulting
Max, Sure. The JavaDoc already spends a bit of time clarifying this. For example: "When modifying parameters, the ordering of existing parameters is maintained. Parameters are set and removed in-place, while appended parameters are added to the end of the query string." "The order the parameter

Re: Resurrect UrlEncodedQueryString (RFE 6306820)?

2009-03-26 Thread kennardconsulting
Max, Sure. The JavaDoc already spends a bit of time clarifying this. For example: "When modifying parameters, the ordering of existing parameters is maintained. Parameters are set and removed in-place, while appended parameters are added to the end of the query string." "The order the parameter

Re: Resurrect UrlEncodedQueryString (RFE 6306820)?

2009-03-26 Thread Weijun Wang
Is "?a=b&c=d" different from "?c=d&a=d" ? kennardconsulting wrote: > Guys, > > I have been prodded to try and resurrect the work we did on > UrlEncodedQueryString. The story so far is... > > 1. Michael, Alan and I spent 18 months working on it until we were all > pretty happy with it > 2. Everyo

Re: Resurrect UrlEncodedQueryString (RFE 6306820)?

2009-03-26 Thread Weijun Wang
Is it worthwhile to add some clarification on this order? Say, create(), apply(), toString() always preserve the order, append() adds at end, and set() updates in-place. Thanks Max kennardconsulting wrote: > Yes. From the JavaDoc for .equals(): > > --- > > Compares the specified object with th

Re: Resurrect UrlEncodedQueryString (RFE 6306820)?

2009-03-26 Thread kennardconsulting
Yes. From the JavaDoc for .equals(): --- Compares the specified object with this UrlEncodedQueryString for equality. Returns true if the given object is also a UrlEncodedQueryString and the two UrlEncodedQueryStrings have the same parameters. More formally, two UrlEncodedQueryStrings t1 and t2

Resurrect UrlEncodedQueryString (RFE 6306820)?

2009-03-26 Thread kennardconsulting
Guys, I have been prodded to try and resurrect the work we did on UrlEncodedQueryString. The story so far is... 1. Michael, Alan and I spent 18 months working on it until we were all pretty happy with it 2. Everyone on the CCC except Mark Reinhold signed off on it 3. Mark had reservations on ove

hg: jdk7/tl/jdk: 6802846: jarsigner needs enhanced cert validation(options)

2009-03-26 Thread weijun . wang
Changeset: b752110df530 Author:weijun Date: 2009-03-27 11:05 +0800 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/b752110df530 6802846: jarsigner needs enhanced cert validation(options) Reviewed-by: xuelei ! src/share/classes/sun/security/tools/JarSigner.java ! src/share/classes/s

hg: jdk7/tl/jdk: 6822903: Reliability and documentation improvements for ReentrantReadWriteLock

2009-03-26 Thread martinrb
Changeset: 4a685f3f3ba8 Author:dl Date: 2009-03-26 17:39 -0700 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/4a685f3f3ba8 6822903: Reliability and documentation improvements for ReentrantReadWriteLock Summary: Make firstReader a Thread, not a long Reviewed-by: martin ! src/share/

hg: jdk7/tl/jdk: 6801020: Concurrent Semaphore release may cause some require thread not signaled

2009-03-26 Thread martinrb
Changeset: 5303aece2068 Author:dl Date: 2009-03-26 11:59 -0700 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/5303aece2068 6801020: Concurrent Semaphore release may cause some require thread not signaled Summary: Introduce PROPAGATE waitStatus Reviewed-by: martin ! src/share/clas