Re: 100% CPU on SocketChannelImpl.connect()

2008-04-15 Thread Guy Korland
I'm pretty sure that it's looping since the profiler shows that the CPU is wasted in the method buddy. Guy On Tue, Apr 15, 2008 at 11:29 PM, Alan Bateman <[EMAIL PROTECTED]> wrote: > Guy Korland wrote: > > > We saw it happens on JDK5.0_u14 and JDK6.0_u5 also it happens on Linux > > and Windows. >

Re: 100% CPU on SocketChannelImpl.connect()

2008-04-15 Thread Alan Bateman
Guy Korland wrote: We saw it happens on JDK5.0_u14 and JDK6.0_u5 also it happens on Linux and Windows. As you can see form the attached jpg the application only call connect() 20 times but it takes around 6 minutes. Guy This may not be an OpenJDK issue in which case it may be better to seek

Re: 100% CPU on SocketChannelImpl.connect()

2008-04-15 Thread Guy Korland
We saw it happens on JDK5.0_u14 and JDK6.0_u5 also it happens on Linux and Windows. As you can see form the attached jpg the application only call connect() 20 times but it takes around 6 minutes. Guy On Tue, Apr 15, 2008 at 9:04 PM, Alan Bateman <[EMAIL PROTECTED]> wrote: > Guy Korland wrote: >

Re: 100% CPU on SocketChannelImpl.connect()

2008-04-15 Thread Alan Bateman
Guy Korland wrote: I haven't seen this code cause problems before. Do you have an example that demonstrates this? I don't have a specific example, we saw it when using we Jini with an Exporter that we developed based on NIO. If so, which operating system? We saw it on windows XP

Re: 100% CPU on SocketChannelImpl.connect()

2008-04-15 Thread Guy Korland
>I haven't seen this code cause problems before. Do you have an example that >demonstrates this? I don't have a specific example, we saw it when using we Jini with an Exporter that we developed based on NIO. >If so, which operating system? We saw it on windows XP >I assume for this to loop the ch

hg: jdk7/jsn/jdk: 6659779: HttpURLConnections logger should log tunnel requests

2008-04-15 Thread christopher . hegarty
Changeset: 459d23a95dfb Author:chegar Date: 2008-04-15 14:22 +0100 URL: http://hg.openjdk.java.net/jdk7/jsn/jdk/rev/459d23a95dfb 6659779: HttpURLConnections logger should log tunnel requests Summary: Invoke Logger for CONNECT request/responses. Reviewed-by: jccollet ! src/share/cla

Re: 100% CPU on SocketChannelImpl.connect()

2008-04-15 Thread Alan Bateman
Guy Korland wrote: Hi, It seems like the following code causes an endless loop in some cases. for (;;) { InetAddress ia = isa.getAddress(); if (ia.isAnyLocalAddress()) ia = InetAddress.getLocalHost(); n = Net.connect(fd, ia, isa.getPort(),trafficClass); if ((n == IOStatus.INTE

100% CPU on SocketChannelImpl.connect()

2008-04-15 Thread Guy Korland
Hi, It seems like the following code causes an endless loop in some cases. for (;;) { InetAddress ia = isa.getAddress(); if (ia.isAnyLocalAddress()) ia = InetAddress.getLocalHost(); n = Net.connect(fd, ia, isa.getPort(),trafficClass); if ((n == IOStatus.INTERRUPTED) && is

Re: 6659779 code review

2008-04-15 Thread Jean-Christophe Collet
Approved. Christopher Hegarty - Sun Microsystem wrote: Hi Michael, Jessie, Can I please get a code review for CR 6659779. This trivially adds logger invocations to log tunnel requests, ie. HTTP CONNECT. -Chris.

6659779 code review

2008-04-15 Thread Christopher Hegarty - Sun Microsystem
Hi Michael, Jessie, Can I please get a code review for CR 6659779. This trivially adds logger invocations to log tunnel requests, ie. HTTP CONNECT. -Chris. --- old/src/share/classes/sun/net/www/protocol/http/HttpURLConnection.java Tue Apr 15 13:59:44 2008 +++ new/src/share/classes/sun/ne

Code review for 6644726: Cookie management issues

2008-04-15 Thread Jean-Christophe Collet
Here are my proposed changes to fix 6644726 It does fix all 7 issues listed in the CR (see http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=6644726 for details) and adds a proper regression test. The short list is: - support for more 'expires' date format - enforce 'secure' cookies - enforc