manual.txt has encoding errors

2015-09-02 Thread Olaf Hering
Is there no better way to translate manual.xml into manual.txt beside using a webbrowser to dump manual.html? Perhaps there is none. The current state for me is oddly looking output. Example: ... 7. Forwarding and Bouncing Mail ... function bound to ?b? and ?f? respectively. ... xxd says: 00017d

handling of incorrect password for imap

2015-09-08 Thread Olaf Hering
What is supposed to happen if imap_pass= in .muttrc has a typo? Right now mutt goes into a loop of retries. After a long time it stops, but without recognizing that the password was wrong. At some point I expected some "try other password" prompt, but no such thing appears. This happens with gmail

broken threading, how to highlight broken replies?

2015-09-11 Thread Olaf Hering
To fixup mails with broken threading I will like to spot the emails which lack proper references. Right now such mails are just marked with a '*' in thread view, which is hard to spot and easy to miss. Is there a way to show such mails differently? Olaf

recovering trac account

2015-09-11 Thread Olaf Hering
How does one get into trac? The "Forgot password" link requires username and email, I know just the latter. Username is not obvious from Ticket #2421. Olaf

Re: broken threading, how to highlight broken replies?

2015-09-16 Thread Olaf Hering
On Fri, Sep 11, Olaf Hering wrote: > To fixup mails with broken threading I will like to spot the emails > which lack proper references. Right now such mails are just marked with > a '*' in thread view, which is hard to spot and easy to miss. > > Is there a way to sh

signed messages from Thunderbird are not handled

2015-12-07 Thread Olaf Hering
If I send a signed message it gets a "Content-Type: text/plain; charset=utf-8; x-action=pgp-signed" header, and the "BEGIN PGP SIGNED MESSAGE/BEGIN PGP SIGNATURE/END PGP SIGNATURE" group in body. Both Thunderbird and mutt recognize such message as signed. A reply from Thunderbird however has "Cont

decoding of base64 fails

2016-02-19 Thread Olaf Hering
How does mutt decode and display base64 parts of a message? My xterm running mutt, and also ThunderBird, shows garbage like this: ... # # Regards, # NormanN?r??y隊Z)z{.ۚ?맲??r??z?^?ˬz??N?(?֜??^? ޭ隊Z)z{.ۚ??0???Ǩ # ... The input looks like this: # Content-Transfer-Encoding: ba

Re: decoding of base64 fails

2016-02-19 Thread Olaf Hering
On Fri, Feb 19, Olaf Hering wrote: > How does mutt decode and display base64 parts of a message? Its Friday, so I ran it in gdb. The bug is in mutt_decode_base64. After the base64 stream ends, a newline comes. Then the '-- ' and the remaining msg. Initially each ch yields -1,

attempt to sign a msg sends mutt into loop

2016-03-04 Thread Olaf Hering
During an attempt to sign a message with mutt it entered an endless loop with no obvious way to escape. I replied to an email, then hit 'S', the sign/encrypt question appeared. I selected 's' (I think) to just sign the thing. Then a question 'Sign as:' appeared. Whatever I enter there, the question

Re: attempt to sign a msg sends mutt into loop

2016-03-04 Thread Olaf Hering
On Fri, Mar 04, Olaf Hering wrote: > During an attempt to sign a message with mutt it entered an endless loop smime_get_key_by_str keeps returning NULL. Olaf

Re: attempt to sign a msg sends mutt into loop

2016-03-04 Thread Olaf Hering
On Fri, Mar 04, Kevin J. McCarthy wrote: > ctrl-g should get you out of the loop. A list of some of the other > keyboard commands for editing input fields is at > https://dev.mutt.org/doc/manual.html#editing Thanks. Actually I was looking for the 'p' key. Olaf signature.asc Description: PGP s

Re: manual.txt has encoding errors

2016-03-23 Thread Olaf Hering
On Sat, Sep 05, Vincent Lefevre wrote: > On 2015-09-02 16:50:21 +0200, Olaf Hering wrote: > > After some debugging it turned out that mutt has a bug: > > LC_ALL=C w3m -dump doc/manual.html > bad.txt > > LC_ALL=C.UTF-8 w3m -dump doc/manual.html > good.txt > > >

Re: make build date in version string configurable?

2016-03-30 Thread Olaf Hering
On Wed, Mar 30, Vincent Lefevre wrote: > There is no need for such an option. The date in Mutt's version > string is *not* the build date, but the release date, which is > fixed. ... and as such can be easily looked up at mutt.org ;-) Olaf

Re: broken threading, how to highlight broken replies?

2016-06-08 Thread Olaf Hering
Since there is now appearently some work going on in the drawing part of mutt: Any idea how a local hack/change has to look like to highlight an entire line in case M_TREE_STAR is set? Olaf On Wed, Sep 16, Olaf Hering wrote: > On Fri, Sep 11, Olaf Hering wrote: > > > To fixu

[PATCH 5/5] fix bug 2421: show number of new mails in Maildir mailboxes

2016-06-15 Thread Olaf Hering
Show number of new mails in Maildir mailboxes. Reuse the st_size value for this purpose. This fixes bug 2421. v2: - fix stale values in local new variable Signed-off-by: Olaf Hering --- browser.c | 35 ++- 1 file changed, 34 insertions(+), 1 deletion(-) diff

[PATCH 4/5] mutt_pretty_size: show real number for small files

2016-06-15 Thread Olaf Hering
With the upcoming change for bug #2421 to show the number of mails in a maildir, update the format of small files. If a file is smaller than a certain size it is user unfriendly to print 0K or 0,1K as number of mails or as file size. Instead use the real number. Signed-off-by: Olaf Hering

[PATCH 3/5] examine_directory: set directory/symlink size to zero

2016-06-15 Thread Olaf Hering
the folder browser output. Signed-off-by: Olaf Hering --- browser.c | 6 -- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/browser.c b/browser.c index a491e2e..ef9783f 100644 --- a/browser.c +++ b/browser.c @@ -428,8 +428,10 @@ static int examine_directory (MUTTMENU *menu

[PATCH 1/5] add real prototype for re_match_2_internal in regex.c

2016-06-15 Thread Olaf Hering
rnal' without a real prototype [-Wunprototyped-calls] regex.c:384:12: note: 're_match_2_internal' was declared here Signed-off-by: Olaf Hering --- regex.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/regex.c b/regex.c index f46c806..40979af 100644 --- a/regex.

[PATCH 2/5] folder_file: remove struct stat

2016-06-15 Thread Olaf Hering
e struct stat, the used values were already duplicated in the struct. This reduces memory usage. Signed-off-by: Olaf Hering --- browser.c | 63 +-- browser.h | 5 - 2 files changed, 37 insertions(+), 31 deletions(-) diff --git a/bro

Re: [PATCH 1/5] add real prototype for re_match_2_internal in regex.c

2016-06-29 Thread Olaf Hering
On Thu, Jun 16, Kevin J. McCarthy wrote: > Thank you for the patches. I'm going to apply patch 1 and 2, but I'd > like to think about 3, 4, and 5. Did you came to a conclusion how the directory browser should be changed to display usable info about non-files? Olaf signature.asc Description: P

message stored in Sent folder even if sending fails

2016-07-24 Thread Olaf Hering
In my setup smtp_pass= is empty so that mutt asks for password before sending. smtp_url= is smtp://user@host. If I fatfinger the password the message to be sent stored in record= anyway, then mutt asks for the smtp password again. For each iteration another copy of the message to be sent is stored

Re: message stored in Sent folder even if sending fails

2016-07-25 Thread Olaf Hering
Am 25. Juli 2016 14:52:27 MESZ, schrieb Michael Tatge : >No. Sending from the command line, in scripts, the error might come up >later during delivery,... Have you actually tried it with smtp_pass= ? There is no interaction and as a result no password and as a result no mail gets created. Olaf

Re: message stored in Sent folder even if sending fails

2016-08-07 Thread Olaf Hering
On Mon, Jul 25, Olaf Hering wrote: > In my setup smtp_pass= is empty so that mutt asks for password before > sending. smtp_url= is smtp://user@host. If I fatfinger the password the > message to be sent stored in record= anyway, then mutt asks for the smtp > password again. For ea

Re: [PATCH 1/5] add real prototype for re_match_2_internal in regex.c

2016-11-23 Thread Olaf Hering
On Thu, Jun 16, Kevin J. McCarthy wrote: > Hi Olaf, > > Thank you for the patches. I'm going to apply patch 1 and 2, but I'd > like to think about 3, 4, and 5. > > With $mail_check_stats set, buffy will have msg counts for all different > kinds of mailboxes. I think it makes more sense to augm

Re: [PATCH 1/5] add real prototype for re_match_2_internal in regex.c

2016-11-24 Thread Olaf Hering
On Wed, Nov 23, Kevin J. McCarthy wrote: > On Wed, Nov 23, 2016 at 07:20:06PM +0100, Olaf Hering wrote: > > Neither %n nor %N work properly, > Sorry but you'll need to be more specific than that. After playing around more with the settings after sending the mail it occoured t

Missing HISTCONTROL=erasedups in mutt

2016-12-05 Thread Olaf Hering
In bash its easy to avoid duplicate commands with HISTCONTROL=ignoreboth:erasedups. In mutt each "c" (to change the mailbox) stores the mailbox name multiple times into the history. It would be nice if mutt gets either a knob to avoid duplicates, or if duplicates will be avoided upfront. Olaf

how to escape the edit-fcc prompt?

2017-01-03 Thread Olaf Hering
Is the only way to escape the 'edit-fcc' prompt in the Compose menu? If one accidently hits 'f', which allows to adjust the location of the "Sent" folder, its not easy to undo changes. Perhaps should be used to leave the prompt and restore the previous value? Olaf signature.asc Description: PG

Re: how to escape the edit-fcc prompt?

2017-01-14 Thread Olaf Hering
Am 3. Januar 2017 13:43:47 MEZ schrieb Moritz Barsnick : >Ctrl+G works for me, as for most prompts. Thanks. Should this be documented? I have not checked if it is already in the man page. I assume its a readline feature. Olaf

expired ssl cert, wrong keyboard shortcuts

2017-07-02 Thread Olaf Hering
If a host has an expired certificate mutt warns about that fact. It offers to permanently use it, or accept it just once. This UI works with 'env -u LANG mutt', but not with 'env LANG=de_DE.UTF-8 mutt'. The suggested keys do just nothing. 'killall mutt' is appearently the only way out. This happens

mutt hangs when IMAP server does not respond anymore

2017-07-10 Thread Olaf Hering
retainable_sigs is unset pgp_self_encrypt is unset pgp_self_encrypt_as="" pgp_show_unusable is set pgp_sign_as="" pgp_sign_command="gpg --no-verbose --batch --quiet --output - %?p?--passphrase-fd 0? --armor --detach-sign --textmode %?a?-u %a? %f" pgp_sort_keys=address pg

Re: mutt hangs when IMAP server does not respond anymore

2017-07-11 Thread Olaf Hering
On Tue, Jul 11, Olaf Hering wrote: > +USE_SSL_OPENSSL -USE_SSL_GNUTLS +USE_SASL +USE_GSS +HAVE_GETADDRINFO I switched from openssl to gnutls, and no issue since then. Is there any downside by using gnutls? So far the only issue I noticed is that during login to every IMAP server I go

Re: mutt hangs when IMAP server does not respond anymore

2017-07-12 Thread Olaf Hering
On Wed, Jul 12, Vincent Lefevre wrote: > This might mean that Mutt was hanging on certificate checking with > OpenSSL, but with GnuTLS, certificate checking doesn't work at all > on your machine, which is a quite serious security issue. The exact message is "Warning: Server certificate was signed

Re: mutt hangs when IMAP server does not respond anymore

2017-07-12 Thread Olaf Hering
On Wed, Jul 12, Vincent Lefevre wrote: Thanks for the followup. > "If you connect to a server and use GnuTLS' functions to verify the > certificate chain, and get a GNUTLS_CERT_INSECURE_ALGORITHM validation > error (see Verifying X.509 certificate paths), it means that somewhere > in the certific

Re: mutt hangs when IMAP server does not respond anymore

2017-07-12 Thread Olaf Hering
On Wed, Jul 12, Olaf Hering wrote: > I posted the backtrace. gnutls deals with the timeout, openssl does not. It seems my copy of claws-mail also uses gnutls, thats likely the reason why it does not get stuck as well. Is there perhaps a need for mutt to drive openssl differently, l

crash in imap_status with two IMAP servers

2017-07-12 Thread Olaf Hering
17-07-12 14:58:54] parse_attach_list: ldata = 0x55916ef10450, *ldata = (nil) [2017-07-12 14:58:54] parse_attach_list: added message/external-body [4] [2017-07-12 14:58:54] Reading configuration file '/home/olaf/.mutt/personal-gmail-aepfle'. [2017-07-12 14:58:54] Reading configuration file &

Re: mutt hangs when IMAP server does not respond anymore

2017-07-12 Thread Olaf Hering
On Wed, Jul 12, Vincent Lefevre wrote: > But you can check the details with "openssl s_client -connect ...", Thanks. These are all wellknown providers: openssl s_client -connect imap.gmail.com:imaps openssl s_client -connect imap.strato.de:imaps openssl s_client -connect smtp.strato.de:imaps ope

Re: crash in imap_status with two IMAP servers

2017-07-12 Thread Olaf Hering
On Wed, Jul 12, Vincent Lefevre wrote: > On 2017-07-12 15:11:12 +0200, Olaf Hering wrote: > > When one of postponed/record/spoolfile is set to another IMAP server > > than the one where INBOX is, mutt crashes in imap_status(). Not sure if > > ctx is required, or if returning

Re: mutt hangs when IMAP server does not respond anymore

2017-07-12 Thread Olaf Hering
On Wed, Jul 12, Vincent Lefevre wrote: > If GnuTLS is consistent, it should yield an error (in case you > have a broken configuration). Guess I have to browse the source to see if anything does actually check for that condition, like mutt does. $ gnutls-cli -p imaps imap.gmail.com Processed

Re: mutt hangs when IMAP server does not respond anymore

2017-07-12 Thread Olaf Hering
On Wed, Jul 12, Olaf Hering wrote: > $ gnutls-cli -p imaps imap.gmail.com I noticed in strace it walks /var/lib/ca-certificates/, which mutt does not do. Maybe thats the difference. Olaf signature.asc Description: PGP signature

Re: mutt hangs when IMAP server does not respond anymore

2017-07-12 Thread Olaf Hering
On Wed, Jul 12, Kevin J. McCarthy wrote: > Check if you have $ssl_ca_certificates_file set. GnuTLS uses this to > know where to look. A few days ago I forgot to specify the relevant configure option for pidgin. It seems mutt should also get a compiletime value. Perhaps I can just tweak /etc/Mutt

Re: mutt hangs when IMAP server does not respond anymore

2017-07-12 Thread Olaf Hering
On Wed, Jul 12, Kevin J. McCarthy wrote: > Just a random question. Olaf, do you have $imap_passive set? imap_passive is unset Olaf signature.asc Description: PGP signature

Re: crash in imap_status with two IMAP servers

2017-07-12 Thread Olaf Hering
On Wed, Jul 12, Kevin J. McCarthy wrote: > Thanks for the detailed bug report. What does your $postponed variable > look like? set folder="imaps://imap.gmail.com/" set postponed="imap://user%25aepfle...@imap.strato.de/INBOX" Olaf signature.asc Description: PGP signature

Re: mutt hangs when IMAP server does not respond anymore

2017-07-13 Thread Olaf Hering
On Wed, Jul 12, Kevin J. McCarthy wrote: > Check if you have $ssl_ca_certificates_file set. GnuTLS uses this to > know where to look. This setting avoids the certificate warning: set ssl_ca_certificates_file="/etc/ssl/ca-bundle.pem" Olaf signature.asc Description: PGP signature

Re: mutt hangs when IMAP server does not respond anymore

2017-07-20 Thread Olaf Hering
On Tue, Jul 11, Olaf Hering wrote: > Any ideas how to deal with this? Looks like the changes made for bug #3956 fixed this one as well. Olaf signature.asc Description: PGP signature

clock_gettime needs -lrt

2017-07-24 Thread Olaf Hering
On Sat, Jul 22, Brendan Cully wrote: > changeset: 7111:908bea74acef > changeset: 7112:4a1390537a29 > +int raw_socket_poll (CONNECTION* conn, time_t wait_secs) > +clock_gettime (CLOCK_MONOTONIC, &pre_t); Depending on what the target audience of mutt is, this call to clock_gettime needs "-lrt

Re: clock_gettime needs -lrt

2017-07-24 Thread Olaf Hering
On Mon, Jul 24, Kevin J. McCarthy wrote: > By the way, I was also pleased to hear the fix for #3956 appears to have > fixed your hang issue too. There are probably some other paths that > are reinvoking imap_cmd_step() too. Unfortunately it did not fix it. The session did last longer, but in the

outdated (german) translation

2017-08-02 Thread Olaf Hering
The german translations for mutt are outdated/incomplete. What needs to be done to get them back to 100%? I have never worked with translations before, is there a howto/guide to provide an updated de.po file? Olaf signature.asc Description: PGP signature

incorrect size of mail shown in IMAP folders

2018-01-12 Thread Olaf Hering
The list of mails in INBOX has a "size" field. Once the INBOX is opened, the size of a mail is "large", likely because the size is set based on the result of RFC822.SIZE. This is the size of header+body. Once the mail is opened, the shown size changes to the size of the body. Why is this inconsist

Re: incorrect size of mail shown in IMAP folders

2018-01-15 Thread Olaf Hering
On Fri, Jan 12, Kevin J. McCarthy wrote: > Later when the actual message is downloaded, hdr->content->length is set > more accurately. Is it accurate that the size is actually just the body? What is the benefit of size==body, vs. size==header+body? Olaf signature.asc Description: PGP signature

IMAP mailbox not selectable in browser

2018-10-28 Thread Olaf Hering
I have two mailboxes named "foo" and "foo.bar" on an IMAP server. If I want to change into "foo", mutt only shows that entry as a directory. It can only be selected if the name is specified manually. Both mailboxes are apparently properly offered in claws. I wonder what makes mutt think "foo" is a

Re: Mutt 1.13.0 problem with German umlauts

2019-12-01 Thread Olaf Hering
Am Sun, 1 Dec 2019 17:44:16 +0100 schrieb Ulrich Lauther : > since compiling and installing Mutt 1.13.0, German Umlauts, for instance in > the subject line are not > displayed correctly. Please type the following, without quotes, in the mailbox browser when an affected email is selected and pro

[PATCH 00 of 20] various changes for mutt.hg

2011-05-23 Thread Olaf Hering
The following series for mutt.hg does various things: Fixes a gcc 4.6 compiler warning -Wunused-but-set-variable in various files. While working on bug 2421 I noticed some redundancy in struct folder_file. The struct stat is not needed, instead the used fields can be added to the struct. Finall

[PATCH 01 of 20] fix gcc 4.6 warning -Wunused-but-set-variable in imap.c

2011-05-23 Thread Olaf Hering
# HG changeset patch # User Olaf Hering # Date 1306148351 -7200 # Branch HEAD # Node ID 919b06d8aef732f6dd375a23aac333f312d44868 # Parent 1fc2afbf9e3a0c572848e145944de8a5c1501187 fix gcc 4.6 warning -Wunused-but-set-variable in imap.c imap.c: In function 'imap_open_mailbox': ima

[PATCH 02 of 20] fix gcc 4.6 warning -Wunused-but-set-variable in compose.c

2011-05-23 Thread Olaf Hering
# HG changeset patch # User Olaf Hering # Date 1306148351 -7200 # Branch HEAD # Node ID 9ac9a31991d291981eaa497e17bcf0fc77998905 # Parent 919b06d8aef732f6dd375a23aac333f312d44868 fix gcc 4.6 warning -Wunused-but-set-variable in compose.c compose.c: In function 'redraw_crypt_lines':

[PATCH 04 of 20] fix gcc 4.6 warning -Wunused-but-set-variable in rfc1524.c

2011-05-23 Thread Olaf Hering
# HG changeset patch # User Olaf Hering # Date 1306148352 -7200 # Branch HEAD # Node ID e38af23a52296fbef5a9e42f3651c4808a899665 # Parent 92b202b0e724ff6a80be8c10de4125866416e002 fix gcc 4.6 warning -Wunused-but-set-variable in rfc1524.c rfc1524.c: In function 'rfc1524_expand_filename'

[PATCH 06 of 20] fix gcc 4.6 warning -Wunused-but-set-variable in pgp.c

2011-05-23 Thread Olaf Hering
# HG changeset patch # User Olaf Hering # Date 1306148353 -7200 # Branch HEAD # Node ID 8d8495a033a8f939a8db262cbe847e47147a2417 # Parent 5782f65d3772274f8971091329757bc9e884d201 fix gcc 4.6 warning -Wunused-but-set-variable in pgp.c pgp.c: In function 'pgp_application_pgp_handler': p

[PATCH 14 of 20] folder_file: use existing ->size member for st_size

2011-05-23 Thread Olaf Hering
# HG changeset patch # User Olaf Hering # Date 1306149752 -7200 # Branch HEAD # Node ID a5c4602946291a49754cb6c1805d3b2e5ed16d01 # Parent 5f1f453e3bad1cf1c12f6f875f41b4f213247053 folder_file: use existing ->size member for st_size Use existing ->size member instead of stat->st_size.

[PATCH 03 of 20] fix gcc 4.6 warning -Wunused-but-set-variable in parse.c

2011-05-23 Thread Olaf Hering
# HG changeset patch # User Olaf Hering # Date 1306148352 -7200 # Branch HEAD # Node ID 92b202b0e724ff6a80be8c10de4125866416e002 # Parent 9ac9a31991d291981eaa497e17bcf0fc77998905 fix gcc 4.6 warning -Wunused-but-set-variable in parse.c parse.c: In function 'mutt_read_rfc822_header'

[PATCH 07 of 20] fix gcc 4.6 warning -Wunused-but-set-variable in smime.c

2011-05-23 Thread Olaf Hering
# HG changeset patch # User Olaf Hering # Date 1306148353 -7200 # Branch HEAD # Node ID 27fb2d16bd930ea6f1457aa78befab996bcb5d02 # Parent 8d8495a033a8f939a8db262cbe847e47147a2417 fix gcc 4.6 warning -Wunused-but-set-variable in smime.c smime.c: In function 'smime_handle_entity': smim

[PATCH 13 of 20] folder_file: use existing ->mode member for st_mode

2011-05-23 Thread Olaf Hering
# HG changeset patch # User Olaf Hering # Date 1306149751 -7200 # Branch HEAD # Node ID 5f1f453e3bad1cf1c12f6f875f41b4f213247053 # Parent eaa08e0a37bd61192380b52ebe53aed3e9f6dd4f folder_file: use existing ->mode member for st_mode Use existing ->mode member instead of stat->st_mode.

[PATCH 05 of 20] fix gcc 4.6 warning -Wunused-but-set-variable in crypt-gpgme.c

2011-05-23 Thread Olaf Hering
# HG changeset patch # User Olaf Hering # Date 1306148352 -7200 # Branch HEAD # Node ID 5782f65d3772274f8971091329757bc9e884d201 # Parent e38af23a52296fbef5a9e42f3651c4808a899665 fix gcc 4.6 warning -Wunused-but-set-variable in crypt-gpgme.c crypt-gpgme.c: In function 'show_one_sig_s

[PATCH 12 of 20] folder_file: introduce and use new ->nlink member

2011-05-23 Thread Olaf Hering
# HG changeset patch # User Olaf Hering # Date 1306149751 -7200 # Branch HEAD # Node ID eaa08e0a37bd61192380b52ebe53aed3e9f6dd4f # Parent 93427f87ba7ebacf2dbafaf5491804dad78f1e81 folder_file: introduce and use new ->nlink member Add and use new nlink member. This is a prereq before remov

[PATCH 11 of 20] folder_file: introduce and use new ->uid member

2011-05-23 Thread Olaf Hering
# HG changeset patch # User Olaf Hering # Date 1306149750 -7200 # Branch HEAD # Node ID 93427f87ba7ebacf2dbafaf5491804dad78f1e81 # Parent dfddd1a8f912355a95c373f6c34189309e149383 folder_file: introduce and use new ->uid member Add and use new uid member. This is a prereq before removing str

[PATCH 10 of 20] folder_file: introduce and use new ->gid member

2011-05-23 Thread Olaf Hering
# HG changeset patch # User Olaf Hering # Date 1306149750 -7200 # Branch HEAD # Node ID dfddd1a8f912355a95c373f6c34189309e149383 # Parent 4d73cc1a137c98a9b75bc40065b94f58f1b5e6ce folder_file: introduce and use new ->gid member Add and use new gid member. This is a prereq before removing str

[PATCH 08 of 20] fix gcc 4.6 warning -Wunused-but-set-variable in pgppubring.c

2011-05-23 Thread Olaf Hering
# HG changeset patch # User Olaf Hering # Date 1306148354 -7200 # Branch HEAD # Node ID a6fb39a7847a1d27ecb6896fe6df3f8902a8ca22 # Parent 27fb2d16bd930ea6f1457aa78befab996bcb5d02 fix gcc 4.6 warning -Wunused-but-set-variable in pgppubring.c pgppubring.c: In function 'pgp_parse_pgp

[PATCH 09 of 20] folder_file: introduce and use new ->local flag

2011-05-23 Thread Olaf Hering
# HG changeset patch # User Olaf Hering # Date 1306149750 -7200 # Branch HEAD # Node ID 4d73cc1a137c98a9b75bc40065b94f58f1b5e6ce # Parent a6fb39a7847a1d27ecb6896fe6df3f8902a8ca22 folder_file: introduce and use new ->local flag Add and use new flag to indicate the folder is on local filesys

[PATCH 20 of 20] fix bug 2421: show number of new mails in Maildir mailboxes

2011-05-23 Thread Olaf Hering
# HG changeset patch # User Olaf Hering # Date 1306149754 -7200 # Branch HEAD # Node ID 7014d8839fa58fc8ab33397ad7755ae5cff2435f # Parent 356b22030d868e34fbc552a358398d068d776a4a fix bug 2421: show number of new mails in Maildir mailboxes Show number of new mails in Maildir mailboxes. Reuse the

[PATCH 19 of 20] mutt_pretty_size: show real number for small files

2011-05-23 Thread Olaf Hering
# HG changeset patch # User Olaf Hering # Date 1306149754 -7200 # Branch HEAD # Node ID 356b22030d868e34fbc552a358398d068d776a4a # Parent 0d1d529d6205a2144f5c1495fb2e008a942495b2 mutt_pretty_size: show real number for small files With the upcoming change for bug #2421 to show the number of

[PATCH 18 of 20] examine_directory: set directory/symlink size to zero

2011-05-23 Thread Olaf Hering
# HG changeset patch # User Olaf Hering # Date 1306149753 -7200 # Branch HEAD # Node ID 0d1d529d6205a2144f5c1495fb2e008a942495b2 # Parent 160e52d652e0d5161afd1ae4c067b1094b4f82e5 examine_directory: set directory/symlink size to zero The size of a directory or symlink in the folder browser is

[PATCH 17 of 20] folder_file: change type of new from short to int

2011-05-23 Thread Olaf Hering
# HG changeset patch # User Olaf Hering # Date 1306149753 -7200 # Branch HEAD # Node ID 160e52d652e0d5161afd1ae4c067b1094b4f82e5 # Parent db2c3d895a1645159338d9a8d0b9361a832f276c folder_file: change type of new from short to int As requested by Rocco Rutte in bug #2421 increase the type to int

[PATCH 16 of 20] folder_file: remove struct stat

2011-05-23 Thread Olaf Hering
# HG changeset patch # User Olaf Hering # Date 1306149753 -7200 # Branch HEAD # Node ID db2c3d895a1645159338d9a8d0b9361a832f276c # Parent 4de4b24b9b362fcbf04a2901c2c2e9f3c9e91c9d folder_file: remove struct stat Remove struct stat, the used values were already duplicated in the struct. Signed

[PATCH 15 of 20] folder_file: use existing ->mtime member for st_mtime

2011-05-23 Thread Olaf Hering
# HG changeset patch # User Olaf Hering # Date 1306149752 -7200 # Branch HEAD # Node ID 4de4b24b9b362fcbf04a2901c2c2e9f3c9e91c9d # Parent a5c4602946291a49754cb6c1805d3b2e5ed16d01 folder_file: use existing ->mtime member for st_mtime Use existing ->mtime member instead of stat->st_mtime

access to trac on dev.mutt.org

2011-05-23 Thread Olaf Hering
I lost my credentials for the bugtracking system, at some point I reported bug 2421. The webinterface on dev.mutt.org wants both email and username, and I forgot the latter. Can someone send me new credentials? Thanks, Olaf

Re: [PATCH 18 of 20] examine_directory: set directory/symlink size to zero

2011-05-24 Thread Olaf Hering
On Tue, May 24, David Champion wrote: > * On 23 May 2011, Olaf Hering wrote: > > Set both to zero to simplify the folder browser output. > > I would say that seeing the size of the linked-to file is useful -- Then lstat() shouldnt be used, right now its just the lenght of the path. Olaf

Re: [PATCH 01 of 20] fix gcc 4.6 warning -Wunused-but-set-variable in imap.c

2011-05-24 Thread Olaf Hering
On Tue, May 24, Brendan Cully wrote: > On Monday, 23 May 2011 at 14:21, Olaf Hering wrote: > > # HG changeset patch > > # User Olaf Hering > > # Date 1306148351 -7200 > > # Branch HEAD > > # Node ID 919b06d8aef732f6dd375a23aac333f312d44868 > > # Parent 1

Re: [PATCH 09 of 20] folder_file: introduce and use new ->local flag

2011-05-30 Thread Olaf Hering
On Tue, May 24, David Champion wrote: > * On 23 May 2011, Olaf Hering wrote: > > # HG changeset patch > > # User Olaf Hering > > # Date 1306149750 -7200 > > # Branch HEAD > > # Node ID 4d73cc1a137c98a9b75bc40065b94f58f1b5e6ce > > # Parent a

[PATCH 20 of 20 v2] fix bug 2421: show number of new mails in Maildir mailboxes

2011-05-30 Thread Olaf Hering
-off-by: Olaf Hering diff -r 356b22030d86 browser.c --- a/browser.c Mon May 23 13:22:34 2011 +0200 +++ b/browser.c Mon May 30 10:24:00 2011 +0200 @@ -372,6 +372,25 @@ static void init_state (struct browser_s menu->data = state->entry; } +static unsigned int walk_maildir_new(const char

missing patch to reconnect mail threads

2012-01-09 Thread Olaf Hering
Hello, there was a patch floating around (quite some time ago) which enabled mutt to reconnect mail threads by inserting correct In-reply-to: and References: header tags. I cant find the patch via google search. Also, I did not use that feature at that time, just noticed that someone implemented

Re: missing patch to reconnect mail threads

2012-01-09 Thread Olaf Hering
On Mon, Jan 09, Gero Treuner wrote: > On Mon, Jan 09, 2012 at 12:34:21PM +0100, Olaf Hering wrote: > > there was a patch floating around (quite some time ago) which enabled mutt > > to reconnect mail threads by inserting correct In-reply-to: and References: > > header tags.

[PATCH] add real prototype for re_match_2_internal in regex.c

2012-02-03 Thread Olaf Hering
# HG changeset patch # User Olaf Hering # Date 1328299312 -3600 # Branch HEAD # Node ID 8743a4a6bd37bd5c1b873c7758046fdbc47f4021 # Parent c26dbc7021f4ec56c0e41d43019e43dd0be666de add real prototype for re_match_2_internal in regex.c regex.c: In function 're_search_2': regex.c:3584:

Re: [PATCH RFC] Add compiler and configure info to mutt -v output

2012-10-18 Thread Olaf Hering
On Tue, Oct 16, David Champion wrote: > +conststrings.c: txt2c.py > + ( \ > + $${CC-cc} --version || \ > + $${CC-cc} -v || \ > + $${CC-cc} -V || \ > + echo "unknown compiler"; \ > + ) 2>/dev/null | python txt2c.py cc_version >conststrings.c >

Re: toward a 1.5.22 release

2013-01-14 Thread Olaf Hering
On Tue, Dec 18, Michael Elkins wrote: > Note that right now I am focusing just on bugfixes, not feature patches, so > that a new release can be created soon. What about this issue, is it solved by some other change already? Is it a code bug or a configuration bug? http://dev.mutt.org/trac/ticket

mutt leaves disconnect from imap on console after exit

2013-02-06 Thread Olaf Hering
Currently mutt prints "Closing connection to ..." to console when I quit mutt with the "q" key. This last message is not properly cleared and still visible on console. I think this was introduced recently (a few weeks?), I run hg rev5637. Anyone else seeing this? Olaf

Re: mutt leaves disconnect from imap on console after exit

2013-02-06 Thread Olaf Hering
On Wed, Feb 06, Michael Elkins wrote: > On Wed, Feb 06, 2013 at 03:46:44PM +0100, Olaf Hering wrote: > >Currently mutt prints "Closing connection to ..." to > >console when I quit mutt with the "q" key. This last message is not > >properly cleared and stil

Re: mutt leaves disconnect from imap on console after exit

2013-02-06 Thread Olaf Hering
On Wed, Feb 06, Michael Elkins wrote: > On Wed, Feb 06, 2013 at 08:24:25PM +0100, Olaf Hering wrote: > >I also see these "Mailbox unchanged" messages (in a separate line), but > >to me it looks like the "Closing connection ..." message just lacks a > >newl

Re: mutt leaves disconnect from imap on console after exit

2013-02-06 Thread Olaf Hering
On Wed, Feb 06, Michael Elkins wrote: > On Wed, Feb 06, 2013 at 08:32:15PM +0100, Olaf Hering wrote: > >On Wed, Feb 06, Michael Elkins wrote: > >>Which curses implementation? I did recently commit a change to remove the > >>code that moved the cursor to the lower le

Re: mutt leaves disconnect from imap on console after exit

2013-02-06 Thread Olaf Hering
On Wed, Feb 06, Michael Elkins wrote: > On Wed, Feb 06, 2013 at 08:42:59PM +0100, Olaf Hering wrote: > >>>ncurses: ncurses 5.7.20101009 (compiled with 5.7) > >> > >>Which terminal emulator, and what $TERM ? > > > >TERM is screen in an xterm. And i

Re: mutt leaves disconnect from imap on console after exit

2013-02-07 Thread Olaf Hering
On Wed, Feb 06, Michael Elkins wrote: > You might try temporarily rolling back > http://dev.mutt.org/hg/mutt/rev/acc8b2afdf29 and see if the change in > http://dev.mutt.org/hg/mutt/rev/4903e80356d3 is indeed the culprit. Reverting 5635:4903e80356d3 fixes it for me. Olaf

Re: mutt leaves disconnect from imap on console after exit

2013-02-07 Thread Olaf Hering
On Wed, Feb 06, Michael Elkins wrote: > On Wed, Feb 06, 2013 at 08:42:59PM +0100, Olaf Hering wrote: > >>>ncurses: ncurses 5.7.20101009 (compiled with 5.7) > >> > >>Which terminal emulator, and what $TERM ? > > > >TERM is screen in an xterm. And i

Re: mutt leaves disconnect from imap on console after exit

2013-02-08 Thread Olaf Hering
On Thu, Feb 07, Michael Elkins wrote: > On Thu, Feb 07, 2013 at 04:13:27PM +0100, Olaf Hering wrote: > >On Wed, Feb 06, Michael Elkins wrote: > > > >>On Wed, Feb 06, 2013 at 08:42:59PM +0100, Olaf Hering wrote: > >>>>>ncurses: ncurses 5.7.20101009 (comp

crash when imap login fails

2014-01-06 Thread Olaf Hering
Current HEAD crashes if IMAP login fails. The backtrace is: (gdb) bt #0 __strstr_sse2 (haystack_start=0x0, needle_start=0x4c0276 "AUTH=LOGIN") at ../string/strstr.c:63 #1 0x004a76ac in imap_auth_sasl (idata=0x8b6a90, method=0x8daf90 "login") at auth_sasl.c:73 #2 0x004a7355 in

Re: Solutions for CVE-2014-9116 (ticket #3716)

2014-12-02 Thread Olaf Hering
On Mon, Dec 01, Kevin J. McCarthy wrote: > In general, mutt checks NULLs pretty well, but returning NULL from > mutt_substrdup() isn't without risk of just generating a segfault in > another place. So personally I would vote for the second or third > choice. Why is there any risk? Just audit the

Re: crash when imap login fails

2015-06-12 Thread Olaf Hering
On Mon, Jan 06, Olaf Hering wrote: > Current HEAD crashes if IMAP login fails. The backtrace is: > > (gdb) bt > #0 __strstr_sse2 (haystack_start=0x0, needle_start=0x4c0276 "AUTH=LOGIN") at > ../string/strstr.c:63 > #1 0x004a76ac in imap_auth_sasl (ida

Re: crash when imap login fails

2015-06-17 Thread Olaf Hering
configuration file '/home/olaf/.mutt/muttrc.common'. [2015-06-17 21:02:25] Reading configuration file '/home/olaf/.mutt/aliases'. [2015-06-17 21:02:25] parse_alias: Second token is 'Olaf Hering '. [2015-06-17 21:02:25] parse_alias: o...@aepfle.de [2015-06-17 21:02:25]

Re: [PATCH] Add support for the reply_format variable.

2020-07-30 Thread Olaf Hering
Am Tue, 28 Jul 2020 01:04:29 +0200 schrieb Mono DHS : > Subject says it all. Unfortunately not. Neither does the attachment. If the intent is to allow translation of the established standard "Re:" in a reply: It is up to each individual client to translate such strings on-the-fly in its user

missing exit condition in mutt_lookup_mime_type

2020-12-08 Thread Olaf Hering
While looking through mutt_lookup_mime_type, I fail to find an exit condition. It seems the function would parse all three 'mime.types' files. If all three have a match, the system provided entry would override the admin entry, which in turn overrides the user entry. It has always been that way

What is a Message-id?

2023-05-24 Thread Olaf Hering
I just had the case "Message-Id: something" in one email, and "References/In-Reply-To: " in replies. As a result mutt failed to recognize that both mails are indeed one single thread. Are the less-than and greater-than signs supposed to be part of the of the message id? In other words: is it s