Re: Tidying the Mutt Code

2015-11-21 Thread Dan Fandrich
On Sat, Nov 21, 2015 at 02:59:09PM +, Richard Russon wrote: > Mutt won't accept the changes and the patches won't go away. Is this true? I've been lurking here a while and don't recall seeing many cases of distros submitting patchsets for review, let alone them being rejected. I just took e qu

Re: [patch] sorting efficiency

2008-09-07 Thread Dan Fandrich
On Sun, Sep 07, 2008 at 04:12:18PM +0200, Thomas Roessler wrote: > Sorting by to or from header is inacceptably slow for large > mailboxes if reverse_alias is enabled, and if there is even a modest > number of aliases in place (here: 500). The main culprit is the > reverse alias lookup code which

Re: [patch] sorting efficiency

2008-09-08 Thread Dan Fandrich
On Mon, Sep 08, 2008 at 10:56:13AM +0200, Thomas Roessler wrote: > Out of curiosity, mind reposting that patch so we can see which > one's better? ;-) It's not really a question of which is better because they're both addressing different parts of the code--aliases versus groups. Attached is my t

multibyte handling patch

2009-01-04 Thread Dan Fandrich
The latest daily build of mutt fails to link on old systems where HAVE_WC_FUNCS is not defined due to missing functions fgetwc, ungetwc and fputws. Attached is a half-baked patch to address this. It's barely tested (it compiles fine!) and only attempts multibyte conversion on the output side (the

Re: current mutt on Cygwin fails to compile.

2009-02-04 Thread Dan Fandrich
On Wed, Feb 04, 2009 at 04:41:40PM +0100, Matthias Andree wrote: > mutt cannot currently be compiled on Cygwin (1.5), as it uses > unimplemented functions in a handful of places, namely fputws, fgetws, > ungetwc [1]. It appears as though Cygwin 1.7 test versions implement these > [2], however,

Re: SMTP authentication

2011-01-14 Thread Dan Fandrich
On Fri, Jan 14, 2011 at 01:39:32PM +0100, Luca Matteis wrote: > I am using an smtp server which requires authentication. The issue is that > the username must be provided in the form of domain/user. > I have this in my .muttrc: > > set smtp_url = "smtp://domain/u...@somesmtpserver.com:587/"

Re: Feature (plugin?) request, boomerang mail

2011-10-27 Thread Dan Fandrich
On Thu, Oct 27, 2011 at 10:38:40PM +0200, Rado Q wrote: > =- Jostein Gogstad wrote on Thu 27.Oct'11 at 22:06:54 +0200 -= > > "I'm sending a mail to Bob asking him to perform some task. I > > expect his response before the work day is over. It's important > > that I remind him of this task if he doe

Re: Saving attachments to disk

2012-03-01 Thread Dan Fandrich
On Thu, Mar 01, 2012 at 07:26:41AM +0100, aitor wrote: > The problem is that there is no way to save these attachment > properly. For instance, when saving file.xml all the non ascii > characters are replaced with "?". So if file.xml originally was: I've been hit by this problem as well. I've also

Re: [PATCH] Add compiler and configure info to mutt -v output (closes #3537)

2012-10-18 Thread Dan Fandrich
On Thu, Oct 18, 2012 at 03:12:21PM -0500, David Champion wrote: > Thanks for the reviews! Changes: > * Uses a C txt2c instead of Python - no new build prereqs But it's going to break when cross-compiling, whereas the Python version doesn't. >>> Dan

Re: Mutt on ubuntu 20

2022-01-10 Thread Dan Fandrich
On Mon, Jan 10, 2022 at 06:27:04PM -0600, Derek Martin wrote: > 1. Does anyone have any idea why ubuntu is shipping such an ancient >version of Mutt? ;-) 1.13.2 was the most recent release of mutt at the beginning of 2020 when Ubuntu 20.04 went into testing, and the OS was released only a few

[PATCH] Double include of config.h

2007-06-26 Thread Dan Fandrich
The attached patch to 1.5.16 fixes a double inclusion of config.h. This causes a compile failure on some compilers (e.g. old gcc) if config.h defines a typedef. >>> Dan -- http://www.MoveAnnouncer.com The web change of address service Let webmasters know that your web site

[PATCH] Incorrect pager percentage

2007-06-27 Thread Dan Fandrich
The percentage through the message indicator (%P) on the pager status line is incorrect on systems that don't support 64-bit offsets. The attached patch corrects this on mutt 1.5.16. >>> Dan -- http://www.MoveAnnouncer.com The web change of address service Let webmasters k

Default groups

2008-03-19 Thread Dan Fandrich
While figuring out a way to colour e-mails from people in my aliases, I've discovered mutt's address groups. That will do what I'm after, except that it looks like I have to add a -group option to all my alias definitions to make it work. That will break whenever I use the 'a' command to add a new

Re: Default groups

2008-03-20 Thread Dan Fandrich
It turned out to be easy to add the default group feature I proposed, so here's a patch to do so. >>> Dan -- http://www.MoveAnnouncer.com The web change of address service Let webmasters know that your web site has moved --- init.h.orig Wed Jan 16 00:00:05 2008 +++ init.h W

[PATCH] Lacking strtok_r

2008-03-20 Thread Dan Fandrich
Here's a patch to allow compilation on old systems without strtok_r. The patch doesn't bother removing the unused "p" pointer, but that's hardly the only warning showing up... >>> Dan -- http://www.MoveAnnouncer.com The web change of address service Let webmasters know tha

[PATCH] Speed and size improvements

2008-03-27 Thread Dan Fandrich
The first attached patch adds a few strategic inlines and an unnecessary list traversal that improves mutt's startup time on a 50 message local mbox by 15% on my configuration. The second patch reduces the .data section (decreasing unsharable RAM requirements) by 25% by marking a bunch of static a

Re: [PATCH] Lacking strtok_r

2008-03-28 Thread Dan Fandrich
On Fri, Mar 28, 2008 at 12:36:58PM +0100, Alain Bench wrote: > The patch compiles, but on old systems uses strtok() instead of > strtok_r(). Such Mutt will misparse some URLs, as reported in bugs: > > | #2968 (Debian #426148): "mailto:"; URL parsing stops at "references" > header > | Debi

Re: [PATCH] Lacking strtok_r

2008-03-28 Thread Dan Fandrich
On Fri, Mar 28, 2008 at 08:33:00AM -0700, Dan Fandrich wrote: > On Fri, Mar 28, 2008 at 12:36:58PM +0100, Alain Bench wrote: > > ...due to recursive calls to strtok(). We'd need a replacement > > strtok_r() for systems where it lacks. > > Hmmm, I didn't notice t

Re: [PATCH] Speed and size improvements

2008-03-30 Thread Dan Fandrich
I've revisited the performance patch I sent and found a problem due to an incorrect assumption. Here's a new version that stores the group addresses in a hash table instead of a linked list so group lookups can be much faster. I've split the original inlining portion of the patch into a separate

Re: [PATCH] Speed and size improvements

2008-04-11 Thread Dan Fandrich
On Fri, Apr 11, 2008 at 09:45:13AM +0200, Rocco Rutte wrote: > Just out of curiosity: How many groups do you have defined? I didn't look in > detail at when and how often mutt needs to lookup groups, though... I only have a small handful of groups, but I'm using the default group patch I sent ear

Re: [PATCH] init warning

2008-05-21 Thread Dan Fandrich
On Wed, May 21, 2008 at 02:45:33PM -0500, David Champion wrote: > Does mutt support < C99? I don't remember. For the most part it does. >>> Dan -- http://www.MoveAnnouncer.com The web change of address service Let webmasters know that your web site has moved

Re: [PATCH] init warning

2008-05-22 Thread Dan Fandrich
On Thu, May 22, 2008 at 08:22:09AM +0200, Rocco Rutte wrote: > -# if SIZEOF_OFF_T == 8 > -# define OFF_T_FMT "%lld" > +# if HAVE_C99_INTTYPES > +# if SIZEOF_OFF_T == 8 > +# define OFF_T_FMT "%" PRId64 > +# else > +# define OFF_T_FMT "%" PRId32 > +# endif > # else > -# define OFF_T_FMT "%l