[PATCH] Add ~M pattern to match mime Content-Types.

2018-04-26 Thread Ammon Riley
Hi, I'm scratching an itch, here. I want to limit email messages to those with pdf attachments, or text/calendar, or images, etc. Is a merge request on gitlab preferable to a patch like this? Cheers, Ammon --- doc/manual.xml.head | 2 ++ doc/muttrc.man.head | 6 ++ mutt.h |

Re: [PATCH] Add ~M pattern to match mime Content-Types.

2018-04-26 Thread Ammon Riley
See attached! On Thu, Apr 26, 2018 at 2:30 PM, Kevin J. McCarthy wrote: > On Thu, Apr 26, 2018 at 12:15:18PM -0700, Ammon Riley wrote: > > I'm scratching an itch, here. I want to limit email messages to those > with > > pdf attachments, or text/calendar, or images, e

Re: [PATCH] Add ~M pattern to match mime Content-Types.

2018-04-26 Thread Ammon Riley
On Thu, Apr 26, 2018 at 4:23 PM, Kevin J. McCarthy wrote: > > diff --git a/doc/manual.xml.head b/doc/manual.xml.head > > > +~M EXPRmessages which > > contain a mime Content-Type matching EXPR > > +=M STRINGmessages > > which contain a mime Content-Type containing > > STRING > > There is no need t

Re: [PATCH] Add ~M pattern to match mime Content-Types.

2018-04-26 Thread Ammon Riley
On Thu, Apr 26, 2018 at 5:34 PM, Kevin J. McCarthy wrote: > On Thu, Apr 26, 2018 at 05:14:27PM -0700, Ammon Riley wrote: > Your new patch was too fast. :-) I realized I forgot to include one > other comment, below. I have to run, but I'll take another closer look > at the re

Re: [PATCH] Add ~M pattern to match mime Content-Types.

2018-04-27 Thread Ammon Riley
On Thu, Apr 26, 2018 at 7:57 PM, Kevin J. McCarthy wrote: > On Thu, Apr 26, 2018 at 06:00:00PM -0700, Ammon Riley wrote: >> 3rd time's the charm, right? > > I think so - this version looks good. I'll give a few days for others > to chime in. > > There don&

Re: [PATCH] Add ~M pattern to match mime Content-Types.

2018-04-27 Thread Ammon Riley
On Fri, Apr 27, 2018 at 12:09 PM, Kevin J. McCarthy wrote: > On Fri, Apr 27, 2018 at 11:05:28AM -0700, Ammon Riley wrote: >> However, looking at imap_read_headers(), I see that it fetches the >> Content-Type header. There's a comment near the bottom that >> reads "

Re: [PATCH] Add ~M pattern to match mime Content-Types.

2018-04-27 Thread Ammon Riley
On Fri, Apr 27, 2018 at 12:18 PM, Kevin J. McCarthy wrote: > On Fri, Apr 27, 2018 at 12:13:54PM -0700, Ammon Riley wrote: >> On Fri, Apr 27, 2018 at 12:09 PM, Kevin J. McCarthy wrote: >> > On Fri, Apr 27, 2018 at 11:05:28AM -0700, Ammon Riley wrote: >> >> However

Re: [PATCH] Add ~M pattern to match mime Content-Types.

2018-05-01 Thread Ammon Riley
On Tue, May 1, 2018 at 10:54 AM, Derek Martin wrote: > On Tue, May 01, 2018 at 11:59:27AM -0500, Derek Martin wrote: >> FWIW, I've said this before, but I think anywhere strncpy() is used, >> code that does the above should replace it. This avoids silent >> truncation (which strncpy() does), and

Re: [PATCH] Add ~M pattern to match mime Content-Types.

2018-05-03 Thread Ammon Riley
On Thu, May 3, 2018 at 10:21 AM, Kevin J. McCarthy wrote: > On Thu, Apr 26, 2018 at 07:57:00PM -0700, Kevin J. McCarthy wrote: >> On Thu, Apr 26, 2018 at 06:00:00PM -0700, Ammon Riley wrote: >> > 3rd time's the charm, right? >> >> I think so - this version lo