[PATCH 3/3] Remove support for OpenSSL <0.9.5

2020-05-24 Thread Remco Rijnders
The current code provides a workaround for the absence of RAND_status in OpenSSL versions before 0.9.5. The comments in the code indicate these versions have to be supported, but as these versions are now more than 20 years old, this no longer applies. Removing this support simplifies the code and

[PATCH 1/3] Use LFSR113 PRNG for mutt's internal random needs

2020-05-24 Thread Remco Rijnders
When mutt needs a random number (for example for naming the tmp files or generating a boundary for MIME attachments) it currently uses different implementation specific functions: random() and either lrand48() or rand() are used. Which one gets used in specific and the quality of its randomness is

[PATCH 2/3] Simplify mutt_generate_boundary to use new mutt_base64_random96 function

2020-05-24 Thread Remco Rijnders
--- sendlib.c | 7 +-- 1 file changed, 1 insertion(+), 6 deletions(-) diff --git a/sendlib.c b/sendlib.c index f5389d8b..77c14e8f 100644 --- a/sendlib.c +++ b/sendlib.c @@ -516,13 +516,8 @@ int mutt_write_mime_body (BODY *a, FILE *f) void mutt_generate_boundary (PARAMETER **parm) { char

Re: [PATCH] Change Message-ID generation to be more unique and leak less information

2020-05-24 Thread Remco Rijnders
Please find (in seperate emails to follow shortly) three proposed patches to address this issue that I and others have raised. All three patches have the use of (some of) the other patches I sent today as a prerequisite. Patch #1 generates ID's in the form: <1590350694.yJEHqG0ie/TbuynV@settler>,

[PATCH 2/3] Change Message-ID generation to be more unique and leak less information

2020-05-24 Thread Remco Rijnders
A Message-ID should be globally unique. Currently mutt generates this ID based on the current date and time, followed by ".G", followed by a letter A to Z (A for the 1st and 27th email sent, Z for the 26th, etc.), followed by the pid of the active mutt process, followed by "@" and the configured fq

[PATCH 1/3] Change Message-ID generation to be more unique and leak less information

2020-05-24 Thread Remco Rijnders
A Message-ID should be globally unique. Currently mutt generates this ID based on the current date and time, followed by ".G", followed by a letter A to Z (A for the 1st and 27th email sent, Z for the 26th, etc.), followed by the pid of the active mutt process, followed by "@" and the configured fq

[PATCH 3/3] Change Message-ID generation to be more unique and leak less information

2020-05-24 Thread Remco Rijnders
A Message-ID should be globally unique. Currently mutt generates this ID based on the current date and time, followed by ".G", followed by a letter A to Z (A for the 1st and 27th email sent, Z for the 26th, etc.), followed by the pid of the active mutt process, followed by "@" and the configured fq

Re: [PATCH 1/3] Use LFSR113 PRNG for mutt's internal random needs

2020-05-24 Thread Remco Rijnders
Makefile.am | 3 ++- configure.ac | 1 - Please note that I am not comfortable enough with autotools to be certain if I did this the correct way (configure.ac) and also my change to the Makefile might be sub optimal, I am not sure. Cheers, Remco

Re: [PATCH 1/3] Use LFSR113 PRNG for mutt's internal random needs

2020-05-24 Thread Kevin J. McCarthy
On Sun, May 24, 2020 at 04:59:24PM -0400, Remco Rijnders wrote: By implementing the LFSR113 function by Pierre L'Ecuyer mutt gets a fast and high quality PRNG that, given the same seeds, results in the same output no matter the environment mutt is running on. I'm not knowledgeable about PRNGs.

Re: [PATCH 3/3] Remove support for OpenSSL <0.9.5

2020-05-24 Thread Kevin J. McCarthy
On Sun, May 24, 2020 at 04:59:26PM -0400, Remco Rijnders wrote: The current code provides a workaround for the absence of RAND_status in OpenSSL versions before 0.9.5. The comments in the code indicate these versions have to be supported, but as these versions are now more than 20 years old, this

Re: [PATCH] Change Message-ID generation to be more unique and leak less information

2020-05-24 Thread Kevin J. McCarthy
On Sun, May 24, 2020 at 06:52:06PM -0400, Remco Rijnders wrote: Please find (in seperate emails to follow shortly) three proposed patches to address this issue that I and others have raised. All three patches have the use of (some of) the other patches I sent today as a prerequisite. Thanks Rem

Re: [PATCH 1/3] Use LFSR113 PRNG for mutt's internal random needs

2020-05-24 Thread Petr Pisar
On Sun, May 24, 2020 at 04:59:24PM -0400, Remco Rijnders wrote: > When mutt needs a random number (for example for naming the tmp files or > generating a boundary for MIME attachments) it currently uses different > implementation specific functions: random() and either lrand48() or rand() > are used