Re: [PATCH] Add additional error handling to safe_rename().

2018-08-28 Thread Derek Martin
On Sun, Aug 26, 2018 at 06:48:46PM -0700, Kevin J. McCarthy wrote: > Here's a first try at a patch to check for the historically documented > "link() returning -1 but succeeding" case for NFS. This seems fine. Though, it seems it leaves in the stat comparison if link() succeeds, which is superflu

Re: [PATCH] Add additional error handling to safe_rename().

2018-08-28 Thread Kevin J. McCarthy
On Tue, Aug 28, 2018 at 03:27:51PM -0500, Derek Martin wrote: > On Sun, Aug 26, 2018 at 06:48:46PM -0700, Kevin J. McCarthy wrote: > > Here's a first try at a patch to check for the historically documented > > "link() returning -1 but succeeding" case for NFS. > > This seems fine. Thank you for t