On Wed, May 11, 2016 at 09:25:41PM -0400, Damien Riegel wrote:
> # HG changeset patch
> # User Damien Riegel
> # Date 1462391862 14400
> # Wed May 04 15:57:42 2016 -0400
> # Node ID eb3c1cd64366352abc9f182d7269ac24298533d0
> # Parent d18cd04e3f5a07ea6c3d0c0b624c917a0024e037
> create a dedica
On Thu, May 12, 2016 at 10:39:00AM +0200, Oswald Buddenhagen wrote:
> On Wed, May 11, 2016 at 09:25:41PM -0400, Damien Riegel wrote:
> > # HG changeset patch
> > # User Damien Riegel
> > # Date 1462391862 14400
> > # Wed May 04 15:57:42 2016 -0400
> > # Node ID eb3c1cd64366352abc9f182d7269ac2
Hi,
I noticed (a while ago) that contib/gpg.rc has duplicated arguments
'--with-fingerprint' for a couple of settings. Probably benign, but
a very simple patch (hg diff -U 5) is attached. Thanks for developing a
great mail client!
Daniel
diff -r 391492f27fef contrib/gpg.rc
--- a/contrib/gpg.rc
On Thu, May 12, 2016 at 11:06:26AM -0400, Damien Riegel wrote:
> Anyway, this is just what I am used to do. If Kevin wants larger
> commits or to squash them when he picks them, that's fine by me.
> It is a remainer of the first version, which used probe callbacks to
> find the right mx_ops to use
On Thu, May 12, 2016 at 04:25:34PM +0100, Daniel Morris wrote:
> I noticed (a while ago) that contib/gpg.rc has duplicated arguments
> '--with-fingerprint' for a couple of settings. Probably benign, but
> a very simple patch (hg diff -U 5) is attached. Thanks for developing a
> great mail client!
On 2016-05-09 10:13:53 -0700, Kevin J. McCarthy wrote:
> Unless there are any objections, I will push this along with the backout
> of 23334e967dd7 "Create a wrapper sys_socket.h to work around Solaris
> namespace issues." later today.
The code is correct, but note that the patch broke indentation
On Thu, May 12, 2016 at 07:00:23PM +0200, Vincent Lefevre wrote:
> On 2016-05-09 10:13:53 -0700, Kevin J. McCarthy wrote:
> > Unless there are any objections, I will push this along with the backout
> > of 23334e967dd7 "Create a wrapper sys_socket.h to work around Solaris
> > namespace issues." lat
changeset: 6649:6356f1068fe2
user: Damien Riegel
date: Thu May 12 12:41:01 2016 -0700
link: http://dev.mutt.org/hg/mutt/rev/6356f1068fe2
rename mbox_close_mailbox to mx_close_mailbox_append and move it
mbox_close_mailbox was used as the counterpart of
mx_open_mailbox_append. To ma
On Thu, May 12, 2016 at 08:47:02AM -0700, Kevin J. McCarthy wrote:
> Let me take a look. I may just squash it down to a single commit.
> Unless there is an actual issue, though, there's no need to re-order and
> resubmit.
I moved the mbox_close_mailbox() rename to the front, and squashed all
the
On Thu, May 12, 2016 at 11:06:26AM -0400, Damien Riegel wrote:
> On Thu, May 12, 2016 at 10:39:00AM +0200, Oswald Buddenhagen wrote:
> > the series is over-fragmented. 6, 7, and 8 definitely should be
> > squashed, as the first two patches make no sense whatsoever without the
> > third.
>
> I am u
# HG changeset patch
# User Damien Riegel
# Date 1463093733 14400
# Thu May 12 18:55:33 2016 -0400
# Node ID 12fc6e961dc15b1cfea86397b40cdb565c51c581
# Parent ae203b2c56a623a3e5c2500f0e845acac554c44b
add open_new_msg operation to struct mx_ops
The code was already using a function pointer t
On Thu, May 12, 2016 at 07:11:20PM -0400, Damien Riegel wrote:
> A few lines in mx_open_new_message are also reindented using spaces
> instead of tabs.
>
that qualifies as an unrelated change in my book.
style fixes should only happen on lines which are touched anyway. the
rest is for a separte co
12 matches
Mail list logo
