mutt: 13 new changesets

2007-04-03 Thread Brendan Cully
13 new changesets in mutt: http://dev.mutt.org/hg/mutt/rev/59fcc37f8c75 changeset: 5054:59fcc37f8c75 branch: HEAD tag: tip user:Brendan Cully <[EMAIL PROTECTED]> date:Mon Apr 02 20:44:47 2007 -0700 summary: Check message for boundary collisions (closes #902) htt

segfault: d5ab883ef90a breaks header cache

2007-04-03 Thread Thomas Roessler
d5ab883ef90a reproducibly leads to segmentation faults in either line 999 or 1002 of hcache.c. At that point, h->db is a NULL pointer which is dereferenced. Backing out d5ab883ef90a cures that. To reproduce the problem, run tip with the header_cache variable set. Regards -- Thomas Roessler <

Re: #2846: Security vulnerability in APOP authentication

2007-04-03 Thread Rocco Rutte
Hi, * Brendan Cully [07-04-02 15:31:14 -0700] wrote: On Sunday, 18 March 2007 at 17:36, Rocco Rutte wrote: I was looking at some mutt code for this issue and other issues that report broken threading upon invalid message-ids. It seems that mutt happily accepts the following syntax: '<.*>'

Re: [Mutt] #2846: Security vulnerability in APOP authentication

2007-04-03 Thread Mutt
#2846: Security vulnerability in APOP authentication Comment (by Rocco Rutte): {{{ Hi, * Brendan Cully [07-04-02 15:31:14 -0700] wrote: >On Sunday, 18 March 2007 at 17:36, Rocco Rutte wrote: >> I was looking at some mutt code for this issue and other issues that >> report broken threadi

[PATCH] Missing include of hcache.h in imap/util.c

2007-04-03 Thread Fabian Groffen
On Gentoo some warnings are treated as fatal errors on 64-bits platforms. While compiling the snapshot of 20070403, I got the following error: * QA Notice: Package has poor programming practices which may compile *but will almost certainly crash on 64bit architectures. * Function

Re: segfault: d5ab883ef90a breaks header cache

2007-04-03 Thread Fabian Groffen
On 03-04-2007 09:46:13 +0200, Thomas Roessler wrote: > d5ab883ef90a reproducibly leads to segmentation faults in either > line 999 or 1002 of hcache.c. At that point, h->db is a NULL > pointer which is dereferenced. > > Backing out d5ab883ef90a cures that. I reverse-patched that particular patch

Re: segfault: d5ab883ef90a breaks header cache

2007-04-03 Thread Fabian Groffen
On 03-04-2007 11:12:29 +0200, Fabian Groffen wrote: > On 03-04-2007 09:46:13 +0200, Thomas Roessler wrote: > > d5ab883ef90a reproducibly leads to segmentation faults in either > > line 999 or 1002 of hcache.c. At that point, h->db is a NULL > > pointer which is dereferenced. > > > > Backing out d

Re: [PATCH] Missing include of hcache.h in imap/util.c

2007-04-03 Thread Brendan Cully
Applied. On Tuesday, 03 April 2007 at 10:35, Fabian Groffen wrote: > On Gentoo some warnings are treated as fatal errors on 64-bits > platforms. While compiling the snapshot of 20070403, I got the > following error: > > * QA Notice: Package has poor programming practices wh

Re: segfault: d5ab883ef90a breaks header cache

2007-04-03 Thread Brendan Cully
On Tuesday, 03 April 2007 at 09:46, Thomas Roessler wrote: > d5ab883ef90a reproducibly leads to segmentation faults in either > line 999 or 1002 of hcache.c. At that point, h->db is a NULL > pointer which is dereferenced. > > Backing out d5ab883ef90a cures that. > > To reproduce the problem, run

Re: [Mutt] #1497: mutt: Mail retrieval fails with a certain message

2007-04-03 Thread Mutt
#1497: mutt: Mail retrieval fails with a certain message coming in Changes (by myon): * status: new => closed * resolution: => fixed Comment: The corresponding Debian bug was closed ages ago. I also vaguely remember a semi-recent fix for messages containing NUL bytes (though I can't fin

Re: [Mutt] #2846: Security vulnerability in APOP authentication

2007-04-03 Thread Mutt
#2846: Security vulnerability in APOP authentication Comment (by brendan): From the BNR, 0-31 appears to be legal when quoted in the local part. As long as the current MD5 collision generators need characters above 127, I think this is OK. -- Ticket URL:

Re: [Mutt] #2846: Security vulnerability in APOP authentication

2007-04-03 Thread Mutt
#2846: Security vulnerability in APOP authentication Changes (by brendan): * status: new => closed * resolution: => fixed -- Ticket URL:

[PATCH] Compilation warnings, configure

2007-04-03 Thread Fabian Groffen
Hi, I believe Brendan already fixed the headercache segfault, but I post my anti-warning patches anyway. I believe it's good to have warningless code. I attach two patches here. configure.patch might be useful in the future, enables X_CFLAGS to be recognised and added to CFLAGS after config

Re: [PATCH] Compilation warnings, configure

2007-04-03 Thread Fabian Groffen
On 03-04-2007 19:38:57 +0200, Fabian Groffen wrote: > diff -ur mutt-1.5.14cvs.orig/regex.c mutt-1.5.14cvs/regex.c > > warning: comparison always yields in false due to limited data type > second hunk: warning: XXX defined but never used > > --- mutt-1.5.14cvs.orig/regex.c 2007-04-03 17:32:4

Re: [PATCH] Compilation warnings, configure

2007-04-03 Thread Brendan Cully
On Tuesday, 03 April 2007 at 19:38, Fabian Groffen wrote: > Hi, > > I believe Brendan already fixed the headercache segfault, but I post my > anti-warning patches anyway. I believe it's good to have warningless > code. I attach two patches here. > > configure.patch > might be useful in the fu

Re: [Mutt] #2790: re-executing a "too long" 'color body ...' cmd

2007-04-03 Thread Mutt
#2790: re-executing a "too long" 'color body ...' cmd causes segv crash after a while Changes (by brendan): * priority: major => minor Comment: Kind of an edge case. -- Ticket URL:

Re: [Mutt] #2056: Attempt re-connect when idle mailbox connection

2007-04-03 Thread Mutt
#2056: Attempt re-connect when idle mailbox connection closes Changes (by brendan): * milestone: => 2.0 -- Ticket URL:

Re: tempfile creation on NFS, VFAT, sshfs

2007-04-03 Thread Christoph Berg
Re: Derek Martin 2007-04-02 <[EMAIL PROTECTED]> > I'd personally like to take a look at these, but I won't have time > until later in the week... What bug number(s) are the SSHFS/VFAT > bugs? (or, I can just search for them when I get the chance...) There's some Debian bugs: #336574: mutt: Coul

Re: [PATCH] Compilation warnings, configure

2007-04-03 Thread Fabian Groffen
On 03-04-2007 19:38:57 +0200, Fabian Groffen wrote: > warnings.patch > warnings I fixed that GCC chokes on using -Werror -std=gnu99. Because > I don't know how to solve the "%lld is forbidden in C90" error I used > the latter option. Please review carefully. The "may be used > unitialise

[Mutt] #2871: #367405: command-line completion backspaces instead

2007-04-03 Thread Mutt
#2871: #367405: command-line completion backspaces instead {{{ Hi, the following was submitted as Debian bug #367405: - Forwarded message from Chung-chieh Shan <[EMAIL PROTECTED]> - Date: Mon, 15 May 2006 14:37:40 -0400 From: Chung-chieh Shan <[EMAIL PROTECTED]> Reply-To: Chung-

Re: mutt cache sensitivity

2007-04-03 Thread Brendan Cully
On Sunday, 01 April 2007 at 11:04, Rocco Rutte wrote: > Hi, > > * Kyle Wheeler [07-04-01 00:31:56 -0600] wrote: > > On Friday, March 30 at 03:29 PM, quoth Rocco Rutte: > >>> So... you're telling me that pointers are no longer stored in the > >>> hcache? Mutt (with hcache) no longer relies on ma

Re: saving attachement fails on sshfs filesystem

2007-04-03 Thread Brendan Cully
On Tuesday, 02 January 2007 at 18:23, Thomas Roessler wrote: > I suspect that this is indeed related. Actually, a similar problem > exists for the vfat file system. > > What happens for vfat is this: In order to create a file safely, > mutt creates a temporary directory that it believes it contro

Re: [PATCH] attach multiple files from command line (v2)

2007-04-03 Thread Christoph Berg
Re: To Mutt Developers 2007-03-24 <[EMAIL PROTECTED]> > Re: To Mutt Developers 2007-03-21 <[EMAIL PROTECTED]> > > The syntax is even "almost" backwards compatible: > > > > mutt -a filelist -- rcptlist > > mutt -a file rcptlist > > Here's a patch that implements this. (And does likewise for mutt -

Re: [PATCH] attach multiple files from command line (v2)

2007-04-03 Thread Brendan Cully
On Tuesday, 03 April 2007 at 22:54, Christoph Berg wrote: > Re: To Mutt Developers 2007-03-24 <[EMAIL PROTECTED]> > > Re: To Mutt Developers 2007-03-21 <[EMAIL PROTECTED]> > > > The syntax is even "almost" backwards compatible: > > > > > > mutt -a filelist -- rcptlist > > > mutt -a file rcptlist >

Re: [PATCH] Compilation warnings, configure

2007-04-03 Thread Brendan Cully
On Tuesday, 03 April 2007 at 21:13, Fabian Groffen wrote: > Now, something that at least seems to run as before on Darwin, and > Solaris (that is Solaris crashing somewhere in the headercache). > The type-puns were not solved correctly. The following thread contains > some info that I followed thi

Re: [PATCH] Compilation warnings, configure

2007-04-03 Thread Lars Hecking
> configure.patch > might be useful in the future, enables X_CFLAGS to be recognised and > added to CFLAGS after configure has done its tests X_CFLAGS is already used by standard autoconf macros. It is also not advisable to have different compiler flags at configure and compile time as co

[PATCH] #if typos in cryptglue.c

2007-04-03 Thread Christoph Berg
# HG changeset patch # User Christoph Berg <[EMAIL PROTECTED]> # Date 1175643311 -7200 # Node ID 400ec2c7a0a565e8786293d2ddcc7d74c93b9378 # Parent 89abe8bd07136ea93bb0395177c65c721cc7f350 Fix typos in CRYPT_BACKEND #ifs. diff -r 89abe8bd0713 -r 400ec2c7a0a5 cryptglue.c --- a/cryptglue.c Tue

Anyone using $imap_home_namespace?

2007-04-03 Thread Brendan Cully
I'd like to yank the $imap_home_namespace option. I don't think it does anything sensible. It's mostly just confusing. Would anyone mind if I pulled it? pgpmEVVpsNcP4.pgp Description: PGP signature