Re: memory leaks sending mail via SSL/TLS

2016-07-15 Thread Kevin J. McCarthy
On Thu, Jul 14, 2016 at 06:32:52PM -0500, Will Fiveash wrote: > On Wed, Jul 13, 2016 at 07:47:04PM -0700, Kevin J. McCarthy wrote: > > There is a len field, but I'd also still like to see the account->pass > > nul-terminated. I see plugins/plugin_common.c doing that in the sasl > > source (when th

Re: memory leaks sending mail via SSL/TLS

2016-07-14 Thread Will Fiveash
On Wed, Jul 13, 2016 at 07:47:04PM -0700, Kevin J. McCarthy wrote: > On Wed, Jul 13, 2016 at 08:05:03PM -0500, Will Fiveash wrote: > > On Tue, Jul 12, 2016 at 07:02:01PM -0700, Kevin J. McCarthy wrote: > > > It looks like the SASL password is leaked, but it's not clear to me how > > > we're suppose

Re: memory leaks sending mail via SSL/TLS

2016-07-13 Thread Kevin J. McCarthy
On Wed, Jul 13, 2016 at 08:05:03PM -0500, Will Fiveash wrote: > On Tue, Jul 12, 2016 at 07:02:01PM -0700, Kevin J. McCarthy wrote: > > It looks like the SASL password is leaked, but it's not clear to me how > > we're supposed to free that. I saw one of the example clients used a > > static variabl

Re: memory leaks sending mail via SSL/TLS

2016-07-13 Thread Will Fiveash
On Wed, Jul 13, 2016 at 08:05:03PM -0500, Will Fiveash wrote: > On Tue, Jul 12, 2016 at 07:02:01PM -0700, Kevin J. McCarthy wrote: > > It looks like the SASL password is leaked, but it's not clear to me how > > we're supposed to free that. I saw one of the example clients used a > > static variabl

Re: memory leaks sending mail via SSL/TLS

2016-07-13 Thread Will Fiveash
On Tue, Jul 12, 2016 at 07:02:01PM -0700, Kevin J. McCarthy wrote: > It looks like the SASL password is leaked, but it's not clear to me how > we're supposed to free that. I saw one of the example clients used a > static variable and reused it for each authentication. I'm reluctant to > make that

Re: memory leaks sending mail via SSL/TLS

2016-07-13 Thread Will Fiveash
On Tue, Jul 12, 2016 at 07:02:01PM -0700, Kevin J. McCarthy wrote: > On Tue, Jul 12, 2016 at 01:44:33PM -0500, Will Fiveash wrote: > > Today I did some memory leak testing of mutt v1.6.2 and found that when > > sending email via mutt->libsasl->libcrypto (OpenSSL) there were a number > > of memory l

Re: memory leaks sending mail via SSL/TLS

2016-07-12 Thread Kevin J. McCarthy
On Tue, Jul 12, 2016 at 01:44:33PM -0500, Will Fiveash wrote: > Today I did some memory leak testing of mutt v1.6.2 and found that when > sending email via mutt->libsasl->libcrypto (OpenSSL) there were a number > of memory leaks. Basically I see about 10KB leaked per message sent. > Has anyone els

memory leaks sending mail via SSL/TLS

2016-07-12 Thread Will Fiveash
Today I did some memory leak testing of mutt v1.6.2 and found that when sending email via mutt->libsasl->libcrypto (OpenSSL) there were a number of memory leaks. Basically I see about 10KB leaked per message sent. Has anyone else observed this? Note that my configuration is using smtp_url="smtps: