Hi Eike,
Eike Rathke wrote:
> On Friday, 2015-02-13 18:53:17 -0800, Kevin J. McCarthy wrote:
>
> > If you are okay with my modifications to your patches, I'll push these
> > after some more testing and giving others a chance to review them.
>
> I tried now, works fine.
Great!
> If you didn't p
Hi Kevin,
On Friday, 2015-02-13 18:53:17 -0800, Kevin J. McCarthy wrote:
> If you are okay with my modifications to your patches, I'll push these
> after some more testing and giving others a chance to review them.
I tried now, works fine.
If you didn't push yet, attached is a slightly modified
Hi Kevin,
On Friday, 2015-02-13 18:53:17 -0800, Kevin J. McCarthy wrote:
> If you are okay with my modifications to your patches, I'll push these
> after some more testing and giving others a chance to review them.
Yes, sure, makes sense. I didn't test the new series though.
Thanks
Eike
--
Kevin J. McCarthy wrote:
> The interface issues can be discussed and implemented later. The
> purpose of this patchset is simply to allow the user to enter a
> fingerprint when searching for a key.
>
> Putting it in a pgp_uid_t is the easiest approach, but it's not the
> correct approach. I'd re
Eike Rathke wrote:
> > For the pgp_getkeybystr() patch, I'd really like to have the fingerprint
> > stored in the pgp_key_t structure, rather than in one of the address
> > records.
>
> But then the fingerprint wouldn't be displayed in the list, or would it?
No, but right now, we also allow the u
Hi Kevin,
On Wednesday, 2015-02-11 19:57:18 -0800, Kevin J. McCarthy wrote:
> First, just a general note. If you add (see #3695) to the top of
> a patch, the commit will be associated with the ticket automatically.
Mentioning the number like in (part of #3695) does not? Ok, I'll use
'see' then.
Kevin J. McCarthy wrote:
> I'm a little uncomfortable with the code just assuming anything with
> modulo-4 spaces and a correct length is a fingerprint.
>
> If someone happens to be named 'JohnPaulStan Tomifuluslow Blahblue'
> and I searched for that, the code would treat this as a fingerprint,
>
Eike Rathke wrote:
> These patches probably don't qualify to close #3695, but at least
> a fingerprint is accepted as user input and fingerprints of keys are
> displayed. For both the pgp_list_pubring_command and
> pgp_list_secring_command need to contain the --with-fingerprint option,
> or have wi
