Re: [PATCH] Account for Timeout <= 0 for sending IMAP NOOP cmd

2022-10-20 Thread David Vernet
On Thu, Oct 20, 2022 at 09:57:56AM -0700, Kevin J. McCarthy wrote: > On Wed, Oct 19, 2022 at 09:42:55PM -0500, David Vernet wrote: > > On Wed, Oct 19, 2022 at 04:20:22PM -0700, Kevin J. McCarthy wrote: > > > That's fine, or I'll be happy to touch it up myself after this is > > > resolved. > > > >

Re: [PATCH] Account for Timeout <= 0 for sending IMAP NOOP cmd

2022-10-20 Thread Kevin J. McCarthy
On Wed, Oct 19, 2022 at 09:42:55PM -0500, David Vernet wrote: On Wed, Oct 19, 2022 at 04:20:22PM -0700, Kevin J. McCarthy wrote: That's fine, or I'll be happy to touch it up myself after this is resolved. Whatever will cause less churn / work for you is fine with me. I wouldn't mind throwing

Re: [PATCH] Account for Timeout <= 0 for sending IMAP NOOP cmd

2022-10-19 Thread David Vernet
On Wed, Oct 19, 2022 at 04:20:22PM -0700, Kevin J. McCarthy wrote: > On Wed, Oct 19, 2022 at 02:16:12PM -0500, David Vernet wrote: > > On Wed, Oct 19, 2022 at 10:47:26AM -0700, Kevin J. McCarthy wrote: > > > The documentation should be fixed for that. > > > > Ack, thanks for clarifying. I'm happy

Re: [PATCH] Account for Timeout <= 0 for sending IMAP NOOP cmd

2022-10-19 Thread Kevin J. McCarthy
On Wed, Oct 19, 2022 at 02:16:12PM -0500, David Vernet wrote: On Wed, Oct 19, 2022 at 10:47:26AM -0700, Kevin J. McCarthy wrote: The documentation should be fixed for that. Ack, thanks for clarifying. I'm happy to send an update to the documentation as part of this patch set as well if you'd l

Re: [PATCH] Account for Timeout <= 0 for sending IMAP NOOP cmd

2022-10-19 Thread David Vernet
On Wed, Oct 19, 2022 at 10:47:26AM -0700, Kevin J. McCarthy wrote: > Hi David, > > Thanks for the patch. > > On Wed, Oct 19, 2022 at 12:01:36PM -0500, David Vernet wrote: > > In imap_check_mailbox(), there is an if clause where we potentially poll > > IMAP with a NOOP command. This can be invoked

Re: [PATCH] Account for Timeout <= 0 for sending IMAP NOOP cmd

2022-10-19 Thread Kevin J. McCarthy
Hi David, Thanks for the patch. On Wed, Oct 19, 2022 at 12:01:36PM -0500, David Vernet wrote: In imap_check_mailbox(), there is an if clause where we potentially poll IMAP with a NOOP command. This can be invoked on many ops, including if we e.g. move to the next message on the index. Accordin