Re: Character set validation (with patch)

2008-01-26 Thread Alain Bench
Hi Rocco, On Friday, December 14, 2007 at 19:46:47 +0100, Rocco Rutte wrote: > I used mutt_iconv_open() as fallback which executes iconv-hooks, so > maybe this patch should use the same trick in general? And mutt_iconv_open() also canonicalizes charset names before anything else, so there s

Re: Character set validation (with patch)

2007-12-14 Thread Rocco Rutte
Hi, * Alain Bench wrote: Sorry, I'm busy elsewhere, and can take a look here only way too rarely. Noticed this thread only now, no time to test the patches. No problem. As I'm no charset/localization guru, any input at any time is appreciated. On Tuesday, November 13, 2007 at 13:48:25

Re: Character set validation (with patch)

2007-12-14 Thread Alain Bench
Hello Rocco! Sorry, I'm busy elsewhere, and can take a look here only way too rarely. Noticed this thread only now, no time to test the patches. On Tuesday, November 13, 2007 at 13:48:25 +0100, Rocco Rutte wrote: > there're some bugs open where trouble could have been avoided if mutt > did

Re: Character set validation (with patch)

2007-12-13 Thread Aron Griffis
Rocco Rutte wrote: [Wed Dec 12 2007, 06:21:04AM EST] > Sorry for spamming the list with patches, Dude, you never need to apologize for this. :-) You're doing great work on mutt. Thank you! Aron

Re: Character set validation (with patch)

2007-12-12 Thread Christian Ebert
* Rocco Rutte on Wednesday, December 12, 2007 at 12:21:04 +0100 > Sorry for spamming the list with patches, but I've made some cleanup and > put a user of mutt_check_charset() in place in init.c. > > In case an option name contains "charset" it does assume a > colon-delimited string and checks

Re: Character set validation (with patch)

2007-12-12 Thread Rocco Rutte
Hi, * Rocco Rutte wrote: Thoughts? Sorry for spamming the list with patches, but I've made some cleanup and put a user of mutt_check_charset() in place in init.c. In case an option name contains "charset" it does assume a colon-delimited string and checks it. In case the new value is wron

Re: Character set validation (with patch)

2007-12-10 Thread Kyle Wheeler
On Friday, December 7 at 01:36 PM, quoth Rocco Rutte: I was told iconvlist() is only implemented by libiconv, not glibc so that Linux users won't really benefit. Thus I've updated the patch to use mutt_iconv_open() to see if iconv_open() knows about the charset. Thoughts? Looks like an exc

Re: Character set validation (with patch)

2007-12-10 Thread Christian Ebert
* Rocco Rutte on Tuesday, November 13, 2007 at 13:48:25 +0100 > there're some bugs open where trouble could have been avoided if mutt > did validate character sets (e.g. #1668 and maybe //TRANSLIT in #2956). > I attached a patch with configure magic that checks for usability of > iconvlist()

Re: Character set validation (with patch)

2007-12-07 Thread Rocco Rutte
Hi, * Rocco Rutte wrote: Thoughts? I was told iconvlist() is only implemented by libiconv, not glibc so that Linux users won't really benefit. Thus I've updated the patch to use mutt_iconv_open() to see if iconv_open() knows about the charset. Thoughts? Rocco diff --git a/charset.c b/cha

Character set validation (with patch)

2007-11-13 Thread Rocco Rutte
Hi, there're some bugs open where trouble could have been avoided if mutt did validate character sets (e.g. #1668 and maybe //TRANSLIT in #2956). I attached a patch with configure magic that checks for usability of iconvlist() to see whether a character set is supported being used in mutt_che