Re: [PATCH 4/4] version.sh: Get detailed version info from git

2012-12-30 Thread Matthias Andree
Am 30.12.2012 16:23, schrieb Fabian Groffen: > On 30-12-2012 16:18:27 +0100, Matthias Andree wrote: >> Am 30.12.2012 15:55, schrieb Fabian Groffen: >>> On 30-12-2012 15:45:30 +0100, Matthias Andree wrote: This is bogofilter's configure.ac code, and for reference, check Solaris's standards

Re: [PATCH 4/4] version.sh: Get detailed version info from git

2012-12-30 Thread Fabian Groffen
On 30-12-2012 16:18:27 +0100, Matthias Andree wrote: > Am 30.12.2012 15:55, schrieb Fabian Groffen: > > On 30-12-2012 15:45:30 +0100, Matthias Andree wrote: > >> This is bogofilter's configure.ac code, and for reference, check > >> Solaris's standards(5) manual page. Actually, we should be tweaking

Re: [PATCH 4/4] version.sh: Get detailed version info from git

2012-12-30 Thread Matthias Andree
Am 30.12.2012 15:55, schrieb Fabian Groffen: > On 30-12-2012 15:45:30 +0100, Matthias Andree wrote: >> This is bogofilter's configure.ac code, and for reference, check >> Solaris's standards(5) manual page. Actually, we should be tweaking PATH >> to read >> >> PATH=/usr/xpg6/bin:/usr/xpg4/bin:/usr/

Re: [PATCH 4/4] version.sh: Get detailed version info from git

2012-12-30 Thread Fabian Groffen
On 30-12-2012 15:45:30 +0100, Matthias Andree wrote: > This is bogofilter's configure.ac code, and for reference, check > Solaris's standards(5) manual page. Actually, we should be tweaking PATH > to read > > PATH=/usr/xpg6/bin:/usr/xpg4/bin:/usr/ccs/bin:/usr/bin:/path/to/compiler/bin:... please

Re: [PATCH 4/4] version.sh: Get detailed version info from git

2012-12-30 Thread Matthias Andree
Am 15.12.2012 15:27, schrieb David Champion: > * On 15 Dec 2012, Oswald Buddenhagen wrote: >> On Fri, Dec 14, 2012 at 06:10:21PM -0600, David Champion wrote: >>> [...] note that the ${a#b} and ${a%b} family of parameter expressions >>> is nonportable. These are commonly accepted bashisms [...] >>

Re: [PATCH 4/4] version.sh: Get detailed version info from git

2012-12-30 Thread Matthias Andree
Am 15.12.2012 01:10, schrieb David Champion: > This is good to add support for, but note that the ${a#b} and ${a%b} > family of parameter expressions is nonportable. These are commonly > accepted bashisms that also work in zsh, but not in xpg4 shells. > > Can you redo with seds, or something? Co

Re: [PATCH 4/4] version.sh: Get detailed version info from git

2012-12-15 Thread David Laight
On Fri, Dec 14, 2012 at 07:59:13PM -0500, Aaron Schrab wrote: > + > + commit=` echo $version|sed -e's/.*-//'` > + version=` echo $version|sed -e's/-[^-]*$//'` > + > + distance=`echo $version|sed -e's/.*-//'` > + version=` echo $version|sed -e's/-[^-]*$//'` > + > + version=` ech

Re: [PATCH 4/4] version.sh: Get detailed version info from git

2012-12-15 Thread David Champion
* On 15 Dec 2012, Oswald Buddenhagen wrote: > On Fri, Dec 14, 2012 at 06:10:21PM -0600, David Champion wrote: > > [...] note that the ${a#b} and ${a%b} family of parameter expressions > > is nonportable. These are commonly accepted bashisms [...] > > > wrong. > http://pubs.opengroup.org/onlinepu

Re: [PATCH 4/4] version.sh: Get detailed version info from git

2012-12-15 Thread Oswald Buddenhagen
On Fri, Dec 14, 2012 at 06:10:21PM -0600, David Champion wrote: > [...] note that the ${a#b} and ${a%b} family of parameter expressions > is nonportable. These are commonly accepted bashisms [...] > wrong. http://pubs.opengroup.org/onlinepubs/009695399/utilities/xcu_chap02.html section 2.6.2 or

Re: [PATCH 4/4] version.sh: Get detailed version info from git

2012-12-14 Thread David Champion
* On 14 Dec 2012, Aaron Schrab wrote: > At 18:10 -0600 14 Dec 2012, David Champion wrote: > >This is good to add support for, but note that the ${a#b} and ${a%b} > >family of parameter expressions is nonportable. These are commonly > >accepted bashisms that also work in zsh, but not in xpg4 shel

Re: [PATCH 4/4] version.sh: Get detailed version info from git

2012-12-14 Thread Aaron Schrab
At 18:10 -0600 14 Dec 2012, David Champion wrote: This is good to add support for, but note that the ${a#b} and ${a%b} family of parameter expressions is nonportable. These are commonly accepted bashisms that also work in zsh, but not in xpg4 shells. Can you redo with seds, or something? I h

Re: [PATCH 4/4] version.sh: Get detailed version info from git

2012-12-14 Thread David Champion
This is good to add support for, but note that the ${a#b} and ${a%b} family of parameter expressions is nonportable. These are commonly accepted bashisms that also work in zsh, but not in xpg4 shells. Can you redo with seds, or something? * On 13 Dec 2012, Aaron Schrab wrote: > From: Aaron Schr

[PATCH 4/4] version.sh: Get detailed version info from git

2012-12-13 Thread Aaron Schrab
From: Aaron Schrab If not able to use mercurial to build a detailed version string, try using git to do so. --- version.sh | 26 ++ 1 file changed, 26 insertions(+) diff --git a/version.sh b/version.sh index 39709a0..54568ac 100644 --- a/version.sh +++ b/version.sh @@