Re: [PATCH 16 of 16] free intermediates in error path

2009-03-17 Thread Erik Hovland
> Hi, > > * Erik Hovland wrote: > >> Static analyzers do shine. But only when humans use them right. Here >> is the corrected patch for the same thing after fixing my usage of the >> tool. > > Sorry for being so tenacious on this issue. Don't be sorry, it is appreciated. > I'm still not convinced

Re: [PATCH 16 of 16] free intermediates in error path

2009-03-17 Thread Rocco Rutte
Hi, * Erik Hovland wrote: Static analyzers do shine. But only when humans use them right. Here is the corrected patch for the same thing after fixing my usage of the tool. Sorry for being so tenacious on this issue. I'm still not convinced this is right. The first free is okay. But in case o

Re: [PATCH 16 of 16] free intermediates in error path

2009-03-16 Thread Erik Hovland
>>> # HG changeset patch >>> # User Erik Hovland >>> # Date 1236899608 25200 >>> # Branch HEAD >>> # Node ID b195a368657041f8ad2a537dfeccf7b876b299c2 >>> # Parent  dfcfb5a6d00dec73c1ffa91e46f7fe37fe2aea50 >>> free intermediates in error path. >> >> Doesn't that function contain more error checks w

Re: [PATCH 16 of 16] free intermediates in error path

2009-03-15 Thread Erik Hovland
On Sun, Mar 15, 2009 at 5:59 AM, Rocco Rutte wrote: > Hi, > > * Erik Hovland wrote: > >> # HG changeset patch >> # User Erik Hovland >> # Date 1236899608 25200 >> # Branch HEAD >> # Node ID b195a368657041f8ad2a537dfeccf7b876b299c2 >> # Parent  dfcfb5a6d00dec73c1ffa91e46f7fe37fe2aea50 >> free inte

Re: [PATCH 16 of 16] free intermediates in error path

2009-03-15 Thread Rocco Rutte
Hi, * Erik Hovland wrote: # HG changeset patch # User Erik Hovland # Date 1236899608 25200 # Branch HEAD # Node ID b195a368657041f8ad2a537dfeccf7b876b299c2 # Parent dfcfb5a6d00dec73c1ffa91e46f7fe37fe2aea50 free intermediates in error path. Doesn't that function contain more error checks whe

[PATCH 16 of 16] free intermediates in error path

2009-03-13 Thread Erik Hovland
1 file changed, 1 insertion(+) smime.c |1 + # HG changeset patch # User Erik Hovland # Date 1236899608 25200 # Branch HEAD # Node ID b195a368657041f8ad2a537dfeccf7b876b299c2 # Parent dfcfb5a6d00dec73c1ffa91e46f7fe37fe2aea50 free intermediates in error path. diff --git a/smime.c b/smime.c -