* Kevin J. McCarthy [2015-05-24 15:06 -0400]:
David J. Weller-Fahy wrote:
I just tried the new patch and everything works as it should, thanks!
Great! I will push it as soon as dev.mutt.org comes back up. Thanks
for your help.
Thank you! And thanks again for your attention to these issue
David J. Weller-Fahy wrote:
> * Kevin J. McCarthy [2015-05-23 16:20 -0400]:
> >Currently I have left the root cert inside the intermediary file. If
> >this is bad or wrong behaviour, I can change it, it was just easier
> >that way.
>
> I do not think that is bad behavior.
Okay, I'll leave it as
* Kevin J. McCarthy [2015-05-24 12:54 -0400]:
I'm sorry I was in a hurry yesterday and neglected to thank you for the
patch. The logic wasn't quite right in the patch (if $state==1 then
the regexp match wouldn't happen), so I just made an easier change in
the patch I resubmitted. (Checking for
* Kevin J. McCarthy [2015-05-23 16:20 -0400]:
Thanks for testing my patch so quickly.
No worries.
Before replying below, let me describe the current behavior. Given a
cert file with:
Leaf-Inter1-Inter2-Inter3-Root
the "smime_keys add_cert" will create two files:
1. Leaf
2. Inter1-Inter2-
David J. Weller-Fahy wrote:
> * David J. Weller-Fahy [2015-05-23 13:52
> -0400]:
> >Second, the request: For some reason the patch results in the
> >intermediate *and* root certificates ending up in the file in which the
> >intermediate certificate should be placed.
>
> In this context "the patc
Kevin J. McCarthy wrote:
> Ah. I see my mistake. I didn't realize mutt was prompting for the
> label first. The current patch added a prompt for *each* certificate
> leaf+chain, but that won't work. I will change it to prompt only once
> for the whole thing.
Here's a revised patch loosening up
Hi David,
Thanks for testing my patch so quickly.
David J. Weller-Fahy wrote:
> It does handle all the certificates, but does not end up using the label
> entered in mutt for all the certificates, nor does it allow the user to
> enter labels for the certificates individually when used from within
* David J. Weller-Fahy [2015-05-23 13:52
-0400]:
Second, the request: For some reason the patch results in the
intermediate *and* root certificates ending up in the file in which the
intermediate certificate should be placed.
In this context "the patch" refers to my patch on top of your patch
* Kevin J. McCarthy [2015-05-22 17:21 -0400]:
Attached is a patch which hopefully implements better certificate chain
handling for add_cert. Although I've tried to test it, I am not a
S/MIME user and don't have access to a large number of certificates to
play with. I would greatly appreciate i
Attached is a patch which hopefully implements better certificate chain
handling for add_cert. Although I've tried to test it, I am not a
S/MIME user and don't have access to a large number of certificates to
play with. I would greatly appreciate if smime_keys users would help me
test this out.
10 matches
Mail list logo
