[PATCH] Improve f=f interoperability (was: [PATCH] fix indent_string handling with format=flowed)

2007-10-23 Thread Rocco Rutte
Hi, * Johannes Stezenbach [07-10-19 14:39:48 +0200] wrote: On Thu, Oct 18, 2007, Rocco Rutte wrote: But I see your point and agree there's a problem and "format=flawed" is true once more. If trimming spaces is the preferred solution, I need more time to come up with the logic of when to do i

Re: [PATCH] fix indent_string handling with format=flowed

2007-10-19 Thread Johannes Stezenbach
Hi, On Thu, Oct 18, 2007, Rocco Rutte wrote: > > Well, technically how mutt interprets the message is fully correct since > '>> >> foo' parses into quote depth 2 and content '>> Foo'. > > But I see your point and agree there's a problem and "format=flawed" is > true once more. If trimming spaces

Re: [PATCH] fix indent_string handling with format=flowed

2007-10-18 Thread Rocco Rutte
Hi, * Johannes Stezenbach [07-10-18 00:11:31 +0200] wrote: On Tue, Oct 16, 2007, Rocco Rutte wrote: My main concern is still that in a discussion you'll loose all f=f benefits if there's only one person doing a format=fixed reply that turns all flowed into fixed lines. For example, in this d

Re: [PATCH] fix indent_string handling with format=flowed

2007-10-17 Thread Johannes Stezenbach
Hi, On Tue, Oct 16, 2007, Rocco Rutte wrote: > > My main concern is still that in a discussion you'll loose all f=f benefits > if there's only one person doing a format=fixed reply that turns all flowed > into fixed lines. For example, in this discussion between us you would have > made message

Re: [PATCH] fix indent_string handling with format=flowed

2007-10-16 Thread Rocco Rutte
Hi, * Johannes Stezenbach [07-10-16 14:54:05 +0200] wrote: On Tue, Oct 16, 2007, Rocco Rutte wrote: * Johannes Stezenbach [07-10-15 23:46:23 +0200] wrote: 2. reply to a format=fixed mail: just add '> ', not '>' (sub optimal but IMHO correct according to RFC 3676 -- since the lines are fi

Re: [PATCH] fix indent_string handling with format=flowed

2007-10-16 Thread Johannes Stezenbach
Hi, On Tue, Oct 16, 2007, Rocco Rutte wrote: > * Johannes Stezenbach [07-10-15 23:46:23 +0200] wrote: > >> 2. reply to a format=fixed mail: just add '> ', not '>' >> (sub optimal but IMHO correct according to RFC 3676 -- since >> the lines are fixed they cannot be reflowed anyway and it >> d

Re: [PATCH] fix indent_string handling with format=flowed

2007-10-16 Thread Rocco Rutte
Hi, * Johannes Stezenbach [07-10-15 23:46:23 +0200] wrote: On Mon, Oct 15, 2007, Rocco Rutte wrote: * Johannes Stezenbach [07-10-14 21:54:36 +0200] wrote: According to RFC 3676: Note that because of space-stuffing, the lines >> Exit, Stage Left and >>Exit, Stage Left are

Re: [PATCH] fix indent_string handling with format=flowed

2007-10-15 Thread Johannes Stezenbach
Hi again, On Mon, Oct 15, 2007, Rocco Rutte wrote: > * Johannes Stezenbach [07-10-14 21:54:36 +0200] wrote: >> At the moment, with $text_flowed set, replies to non-flowed mails >> get ugly quoting with '>' instead of '> '. Mutt _displays_ such >> quoting as '> ', but to people with other MUAs it m

Re: [PATCH] fix indent_string handling with format=flowed

2007-10-15 Thread Johannes Stezenbach
Hi, damn, this stuff is so subtle it's really hard for me to find words to express myself without creating misunderstandings. Maybe I should state my goals before we go into details: - I want mutt to follow RFC 3676 by the book (currently I think it doesn't) - and I want a mode where I can disa

Re: [PATCH] fix indent_string handling with format=flowed

2007-10-15 Thread Johannes Stezenbach
Hi, On Mon, Oct 15, 2007, Rocco Rutte wrote: > Ah, now I see your point. I fixed this in changeset 35e5c34b7e91 which also > fixes bug #2917. Thanks! It seems things get fixed in no time if we can agree on the problem :-) Johannes

Re: [PATCH] fix indent_string handling with format=flowed

2007-10-15 Thread Rocco Rutte
Hi, * Johannes Stezenbach [07-10-14 21:54:36 +0200] wrote: On Sat, Oct 13, 2007, Rocco Rutte wrote: * Johannes Stezenbach [07-10-12 23:14:21 +0200] wrote: I still think that my patch does the right thing. I think I see a problem with it. It removes the space between quotes and text in the

Re: [PATCH] fix indent_string handling with format=flowed

2007-10-15 Thread Rocco Rutte
Hi, * Johannes Stezenbach [07-10-14 21:12:59 +0200] wrote: * Johannes Stezenbach [07-10-12 23:14:21 +0200] wrote: I think it would be useful to have a config option to disable RFC 3676 handling of received messages altogether and make mutt behave like a plain old non-f=f aware MUA. Mutt wit

Re: [PATCH] fix indent_string handling with format=flowed

2007-10-15 Thread Rocco Rutte
Hi, * Johannes Stezenbach [07-10-14 20:33:21 +0200] wrote: On Sat, Oct 13, 2007, Rocco Rutte wrote: * Johannes Stezenbach [07-10-12 23:14:21 +0200] wrote: Just as I write this I notice another thing which might be a bug: According to RFC 3676 "4.1. Interpreting Format=Flowed": A seri

Re: [PATCH] fix indent_string handling with format=flowed

2007-10-14 Thread Johannes Stezenbach
Hi, On Sat, Oct 13, 2007, Rocco Rutte wrote: > * Johannes Stezenbach [07-10-12 23:14:21 +0200] wrote: >> On Thu, Oct 11, 2007, Rocco Rutte wrote: > >>> Mutt currently tries to keep interoperability by assuming that non-f=f >>> aware clients (including mutt itself with $text_flowed unset) treat f=

Re: [PATCH] fix indent_string handling with format=flowed

2007-10-14 Thread Johannes Stezenbach
Hi, > * Johannes Stezenbach [07-10-12 23:14:21 +0200] wrote: >> I think it would be useful to have a config option to disable >> RFC 3676 handling of received messages altogether and make mutt >> behave like a plain old non-f=f aware MUA. > > Mutt with $text_flowed unset ignores the spaces and lea

Re: [PATCH] fix indent_string handling with format=flowed

2007-10-14 Thread Johannes Stezenbach
Hi, On Sat, Oct 13, 2007, Rocco Rutte wrote: > * Johannes Stezenbach [07-10-12 23:14:21 +0200] wrote: >> Just as I write this I notice another thing which might be a bug: >> According to RFC 3676 "4.1. Interpreting Format=Flowed": > >> A series of one or more flowed lines followed by one fixe

Re: [PATCH] fix indent_string handling with format=flowed

2007-10-13 Thread Rocco Rutte
Hi, * Johannes Stezenbach [07-10-12 23:14:21 +0200] wrote: On Thu, Oct 11, 2007, Rocco Rutte wrote: Mutt currently tries to keep interoperability by assuming that non-f=f aware clients (including mutt itself with $text_flowed unset) treat f=f mails just like any other mail and leave the spac

Re: [PATCH] fix indent_string handling with format=flowed

2007-10-12 Thread Johannes Stezenbach
Hi, I've taken some time to read RFC 3676 and conduct some experiments. Sorry for the long mail, the topic is tricky... On Thu, Oct 11, 2007, Rocco Rutte wrote: > * Johannes Stezenbach [07-10-10 20:49:38 +0200] wrote: > >> I think when the code which my patch changes is executed, the f=f >> messa

Re: [PATCH] fix indent_string handling with format=flowed

2007-10-11 Thread Rocco Rutte
Hi, * Johannes Stezenbach [07-10-10 18:01:15 +0200] wrote: BTW, I just noticed mutt crashes when I set indent_string="|" (single pipe character) and try to reply to a message (independent of my patch, also happens in Debian 1.5.16 package). I fixed the crash in changeset 40f2c0f4c597. The und

Re: [PATCH] fix indent_string handling with format=flowed

2007-10-11 Thread Rocco Rutte
Hi, * Johannes Stezenbach [07-10-10 20:49:38 +0200] wrote: "Don't use $indent_string to quote replies to flowed messages" is the regression. OK, sorry if I put you on the wrong track with the "|" thing -- this was just used during testing. What I really want to do (and what worked before but

Re: [PATCH] fix indent_string handling with format=flowed

2007-10-10 Thread Johannes Stezenbach
Hi, On Wed, Oct 10, 2007 at 07:01:50PM +0200, Rocco Rutte wrote: > * Johannes Stezenbach [07-10-10 18:01:15 +0200] wrote: > >> changeset: 5109:d3e0d6c60d87 >> branch: HEAD >> user:Brendan Cully <[EMAIL PROTECTED]> >> date:Tue Apr 10 13:46:09 2007 -0700 >> summary: Don't

Re: [PATCH] fix indent_string handling with format=flowed

2007-10-10 Thread Rocco Rutte
Hi, * Johannes Stezenbach [07-10-10 18:01:15 +0200] wrote: changeset: 5109:d3e0d6c60d87 branch: HEAD user:Brendan Cully <[EMAIL PROTECTED]> date:Tue Apr 10 13:46:09 2007 -0700 summary: Don't use $indent_string to quote replies to flowed messages (closes #2874). in

[PATCH] fix indent_string handling with format=flowed

2007-10-10 Thread Johannes Stezenbach
Hi, changeset: 5109:d3e0d6c60d87 branch: HEAD user:Brendan Cully <[EMAIL PROTECTED]> date:Tue Apr 10 13:46:09 2007 -0700 summary: Don't use $indent_string to quote replies to flowed messages (closes #2874). introduced a regression when replying to format=flowed mails.