Re: [PATCH] Use OpenSSL, GnuTLS, or LFSR113 PRNG for mutt's random needs

2020-05-30 Thread Gero Treuner
Hi Remco, On Fri, May 29, 2020 at 03:51:52PM -0400, Remco Rijnders wrote: > +/* Generate and Base64 encode 96 random bits and fill the buffer > + output_B64 with the result. */ > +void mutt_base64_random96(char output_B64[static 17]) > +{ > + u_int32_t randombits[3] = { mutt_random32(), mutt_ran

Re: [PATCH] Use OpenSSL, GnuTLS, or LFSR113 PRNG for mutt's random needs

2020-05-29 Thread Oswald Buddenhagen
On Fri, May 29, 2020 at 03:51:52PM -0400, Remco Rijnders wrote: When mutt is not configured with either of these two libraries, it will now use a built in PRNG function (the LFSR113 algorithm by Pierre L'Ecuyer) to generate high quality pseudo random numbers. fair enough, but you still should tr

[PATCH] Use OpenSSL, GnuTLS, or LFSR113 PRNG for mutt's random needs

2020-05-29 Thread Remco Rijnders
When mutt needs a random number (for example for naming the tmp files or generating a boundary for MIME attachments) it currently uses different implementation specific functions: random() and either lrand48() or rand() are used. Which one gets used in specific and the quality of its randomness is