Re: [PATCH] Add error when $sendmail has shell metachars

2022-05-25 Thread Richard Russon
> It looks like most commits in the last two years are Kevin's. > Many others are translation-related. You're right. This command shows how little support Kevin has had in the last five years. (it excludes commits that only touch 'po/') $ git shortlog --summary --numbered --no-merges e7c88e4b.. -

Re: [PATCH] Add error when $sendmail has shell metachars

2022-05-25 Thread raf
On Tue, May 24, 2022 at 06:58:46PM +0200, Magnus Groß wrote: > On Tue, May 24, 2022 at 09:38:50AM -0700, Kevin J. McCarthy wrote: > > As I mentioned, development is in maintenance mode, so I'm not > > committing patches to master at this point. > > Has there been any strategy on how to continue

Re: [PATCH] Add error when $sendmail has shell metachars

2022-05-25 Thread raf
On Tue, May 24, 2022 at 11:19:43AM -0700, "Kevin J. McCarthy" wrote: > On Tue, May 24, 2022 at 09:58:08AM -0700, Kevin J. McCarthy wrote: > > On Fri, May 20, 2022 at 05:56:58PM +1000, raf wrote: > > > +#define SHELL_NON_SPACE_META_CHARACTERS "|&;()<>[]{}$`'~\"\\*?" > > > + if (Sendmail[strcspn(

Re: [PATCH] Add error when $sendmail has shell metachars

2022-05-24 Thread raf
On Tue, May 24, 2022 at 09:58:08AM -0700, "Kevin J. McCarthy" wrote: > On Fri, May 20, 2022 at 05:56:58PM +1000, raf wrote: > > +#define SHELL_NON_SPACE_META_CHARACTERS "|&;()<>[]{}$`'~\"\\*?" > > + if (Sendmail[strcspn(Sendmail, SHELL_NON_SPACE_META_CHARACTERS)] != '\0') > > + { > > +mutt

Re: [PATCH] Add error when $sendmail has shell metachars

2022-05-24 Thread raf
On Tue, May 24, 2022 at 09:38:50AM -0700, "Kevin J. McCarthy" wrote: > Thanks for the patch, raf. > > While it *probably* wouldn't cause any harm, I don't think the benefit > outweighs the potential risk for committing this to stable. (Also, I > generally don't commit new translation strings t

Re: [PATCH] Add error when $sendmail has shell metachars

2022-05-24 Thread Kevin J. McCarthy
On Tue, May 24, 2022 at 09:58:08AM -0700, Kevin J. McCarthy wrote: On Fri, May 20, 2022 at 05:56:58PM +1000, raf wrote: +#define SHELL_NON_SPACE_META_CHARACTERS "|&;()<>[]{}$`'~\"\\*?" + if (Sendmail[strcspn(Sendmail, SHELL_NON_SPACE_META_CHARACTERS)] != '\0') + { +mutt_error(_("$sendmail

Re: [PATCH] Add error when $sendmail has shell metachars

2022-05-24 Thread Magnus Groß
On Tue, May 24, 2022 at 09:38:50AM -0700, Kevin J. McCarthy wrote: As I mentioned, development is in maintenance mode, so I'm not committing patches to master at this point. Has there been any strategy on how to continue development? Surely it is not the plan to cease development completely. I

Re: [PATCH] Add error when $sendmail has shell metachars

2022-05-24 Thread Kevin J. McCarthy
On Fri, May 20, 2022 at 05:56:58PM +1000, raf wrote: +#define SHELL_NON_SPACE_META_CHARACTERS "|&;()<>[]{}$`'~\"\\*?" + if (Sendmail[strcspn(Sendmail, SHELL_NON_SPACE_META_CHARACTERS)] != '\0') + { +mutt_error(_("$sendmail cannot contain shell meta-characters.")); +return -1; + } Als

Re: [PATCH] Add error when $sendmail has shell metachars

2022-05-24 Thread Kevin J. McCarthy
Thanks for the patch, raf. While it *probably* wouldn't cause any harm, I don't think the benefit outweighs the potential risk for committing this to stable. (Also, I generally don't commit new translation strings to stable.) As I mentioned, development is in maintenance mode, so I'm not co

[PATCH] Add error when $sendmail has shell metachars

2022-05-22 Thread raf
--- sendlib.c | 8 1 file changed, 8 insertions(+) diff --git a/sendlib.c b/sendlib.c index 430b5d73..05039714 100644 --- a/sendlib.c +++ b/sendlib.c @@ -2706,6 +2706,14 @@ mutt_invoke_sendmail (ADDRESS *from, /* the sender */ return -1; } + /* check for shell meta-charact